Updating Timer sample to use Queue output binding

Author: mathewc

sample/TimerTrigger/function.json

@@ -3,9 +3,16 @@
     "input": [
       {
         "type": "timerTrigger",
-        "schedule": "*/15 * * * * *",
+        "schedule": "0 * * * * *",
         "runOnStartup": true
       }
+    ],
+    "output": [
+      {
+        "type": "queue",
+        "name": "message",
+        "queueName": "samples-fsharp"
+      }
     ]
   }
 }

sample/TimerTrigger/index.js

@@ -6,5 +6,13 @@ module.exports = function (context) {
     var timeStamp = new Date().toISOString();
     context.log('Node.js timer trigger function ran at ' + timeStamp);
 
+    var message = {
+        id: Math.floor(Math.random() * 10000) + 1,
+        notes: "Generated by Timer function"
+    };
+    context.output({
+        message: JSON.stringify(message)
+    })
+
     logger.log(timeStamp, context.done);
 }

src/WebJobs.Script/Binding/Binding.cs

@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
+using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.IO;
@@ -58,6 +59,10 @@ internal static Collection<Binding> GetBindings(JobHostConfiguration config, JAr
                     }
                     else if (type == "queue")
                     {
+                        if (fileAccess != FileAccess.Write)
+                        {
+                            throw new InvalidOperationException("Queue binding can only be used for output.");
+                        }
                         string queueName = (string)binding["queueName"];
                         bindings.Add(new QueueBinding(config, name, queueName, fileAccess, isTrigger: false));
                     }

src/WebJobs.Script/Binding/QueueBinding.cs

@@ -39,22 +39,14 @@ public override async Task BindAsync(IBinder binder, Stream stream, IReadOnlyDic
 
             boundQueueName = Resolve(boundQueueName);
 
-            if (FileAccess == FileAccess.Write)
+            IAsyncCollector<byte[]> collector = binder.Bind<IAsyncCollector<byte[]>>(new QueueAttribute(boundQueueName));
+            byte[] bytes;
+            using (MemoryStream ms = new MemoryStream())
             {
-                Stream queueStream = binder.Bind<Stream>(new QueueAttribute(boundQueueName));
-                await queueStream.CopyToAsync(stream);
-            }
-            else
-            {
-                IAsyncCollector<byte[]> collector = binder.Bind<IAsyncCollector<byte[]>>(new QueueAttribute(boundQueueName));
-                byte[] bytes;
-                using (MemoryStream ms = new MemoryStream())
-                {
-                    stream.CopyTo(ms);
-                    bytes = ms.ToArray();
-                }
-                await collector.AddAsync(bytes);
+                stream.CopyTo(ms);
+                bytes = ms.ToArray();
             }
+            await collector.AddAsync(bytes);
         }
     }
 }

test/WebJobs.Script.Tests/NodeFunctionGenerationTests.cs

@@ -156,9 +156,10 @@ private static MethodInfo GenerateMethod(JObject trigger)
             List<FunctionFolderInfo> functionFolderInfos = new List<FunctionFolderInfo>();
             functionFolderInfos.Add(functionFolderInfo);
 
+            JobHostConfiguration config = new JobHostConfiguration();
             FunctionDescriptorProvider[] descriptorProviders = new FunctionDescriptorProvider[]
             {
-                new NodeFunctionDescriptorProvider(Environment.CurrentDirectory)
+                new NodeFunctionDescriptorProvider(config, Environment.CurrentDirectory)
             };
             var functionDescriptors = ScriptHost.ReadFunctions(functionFolderInfos, descriptorProviders);
             Type t = FunctionGenerator.Generate("TestScriptHost", "Host.Functions", functionDescriptors);