Update Roslyn references

fabiocav · brettsam · commit 42e7c86c83d4 · 2019-10-11T05:27:08.000-07:00
diff --git a/build/common.props b/build/common.props
@@ -43,8 +43,8 @@
     <AdditionalFiles Include="$(MSBuildThisFileDirectory)..\stylecop.json" Link="stylecop.json" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis" Version="2.8.2" />
-    <PackageReference Include="Microsoft.CodeAnalysis.Common" Version="2.8.2" />
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="2.8.2" />
+    <PackageReference Include="Microsoft.CodeAnalysis" Version="3.3.1" />
+    <PackageReference Include="Microsoft.CodeAnalysis.Common" Version="3.3.1" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.3.1" />
   </ItemGroup>
 </Project>
diff --git a/src/WebJobs.Script/Description/DotNet/Compilation/CSharp/Analyzers/AsyncVoidAnalyzer.cs b/src/WebJobs.Script/Description/DotNet/Compilation/CSharp/Analyzers/AsyncVoidAnalyzer.cs
@@ -27,6 +27,8 @@ public AsyncVoidAnalyzer()
 
         public override void Initialize(AnalysisContext context)
         {
+            context.EnableConcurrentExecution();
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
             context.RegisterSymbolAction(AnalyzeSymbol, SymbolKind.Method);
         }
 
diff --git a/src/WebJobs.Script/Description/DotNet/Compilation/CSharp/Analyzers/InvalidFileMetadataReferenceAnalyzer.cs b/src/WebJobs.Script/Description/DotNet/Compilation/CSharp/Analyzers/InvalidFileMetadataReferenceAnalyzer.cs
@@ -33,6 +33,8 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
 
         public override void Initialize(AnalysisContext context)
         {
+            context.EnableConcurrentExecution();
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
             context.RegisterCompilationAction(AnalyzeCompilation);
         }
 
diff --git a/src/WebJobs.Script/Description/DotNet/Compilation/CSharp/CSharpCompilation.cs b/src/WebJobs.Script/Description/DotNet/Compilation/CSharp/CSharpCompilation.cs
@@ -78,7 +78,7 @@ private static string GetFullTypeName(ITypeSymbol type)
 
         private static bool IsOrUsesAssemblyType(ITypeSymbol typeSymbol, IAssemblySymbol assemblySymbol)
         {
-            if (typeSymbol.ContainingAssembly == assemblySymbol)
+            if (Equals(typeSymbol.ContainingAssembly, assemblySymbol))
             {
                 return true;
             }
diff --git a/src/WebJobs.Script/WebJobs.Script.csproj b/src/WebJobs.Script/WebJobs.Script.csproj
@@ -43,7 +43,7 @@
     <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Http" Version="3.0.5-10763" />
     <PackageReference Include="Microsoft.Azure.WebJobs.Logging.ApplicationInsights" Version="3.0.14" />
     <PackageReference Include="Microsoft.Build" Version="15.8.166" />
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="2.8.2" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="3.3.1" />
     <PackageReference Include="Microsoft.DotNet.PlatformAbstractions" Version="2.1.0" />
     <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="3.0.0" />
     <PackageReference Include="Microsoft.Extensions.Logging" Version="2.2.0" />

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,8 @@ public AsyncVoidAnalyzer()`
`27`	`27`
`28`	`28`	`public override void Initialize(AnalysisContext context)`
`29`	`29`	`{`
	`30`	`+ context.EnableConcurrentExecution();`
	`31`	`+ context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);`
`30`	`32`	`context.RegisterSymbolAction(AnalyzeSymbol, SymbolKind.Method);`
`31`	`33`	`}`
`32`	`34`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,8 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics`
`33`	`33`
`34`	`34`	`public override void Initialize(AnalysisContext context)`
`35`	`35`	`{`
	`36`	`+ context.EnableConcurrentExecution();`
	`37`	`+ context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);`
`36`	`38`	`context.RegisterCompilationAction(AnalyzeCompilation);`
`37`	`39`	`}`
`38`	`40`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ private static string GetFullTypeName(ITypeSymbol type)`
`78`	`78`
`79`	`79`	`private static bool IsOrUsesAssemblyType(ITypeSymbol typeSymbol, IAssemblySymbol assemblySymbol)`
`80`	`80`	`{`
`81`		`- if (typeSymbol.ContainingAssembly == assemblySymbol)`
	`81`	`+ if (Equals(typeSymbol.ContainingAssembly, assemblySymbol))`
`82`	`82`	`{`
`83`	`83`	`return true;`
`84`	`84`	`}`