Update active profile when multiple runtimes use worker description profiles (#9084)

* Handle multiple worker runtime profiles

* Adding unit tests

* Review comments

Author: shreyas-gopalakrishna

src/WebJobs.Script/Workers/Profiles/WorkerProfileManager.cs

@@ -18,14 +18,15 @@ internal class WorkerProfileManager : IWorkerProfileManager
         private readonly IEnvironment _environment;
         private readonly IEnumerable<IWorkerProfileConditionProvider> _conditionProviders;
 
-        private string _activeProfile = string.Empty;
+        private Dictionary<string, string> _activeProfiles;
         private Dictionary<string, List<WorkerDescriptionProfile>> _profiles;
 
         public WorkerProfileManager(ILogger<WorkerProfileManager> logger, IEnvironment environment)
         {
             _environment = environment ?? throw new ArgumentNullException(nameof(environment));
             _logger = logger ?? throw new ArgumentNullException(nameof(logger));
 
+            _activeProfiles = new Dictionary<string, string>();
             _profiles = new Dictionary<string, List<WorkerDescriptionProfile>>();
             _conditionProviders = new List<IWorkerProfileConditionProvider>
             {
@@ -63,7 +64,7 @@ public void LoadWorkerDescriptionFromProfiles(RpcWorkerDescription defaultWorker
             if (GetEvaluatedProfile(defaultWorkerDescription.Language, out WorkerDescriptionProfile profile))
             {
                 _logger?.LogInformation($"Worker initialized with profile - {profile.Name}, Profile ID {profile.ProfileId} from worker config.");
-                _activeProfile = profile.ProfileId;
+                _activeProfiles[defaultWorkerDescription.Language] = profile.ProfileId;
                 workerDescription = profile.ApplyProfile(defaultWorkerDescription);
             }
             else
@@ -97,7 +98,13 @@ public bool IsCorrectProfileLoaded(string workerRuntime)
             {
                 profileId = profile.ProfileId;
             }
-            return _activeProfile.Equals(profileId);
+
+            string activeProfile;
+            if (!_activeProfiles.TryGetValue(workerRuntime, out activeProfile))
+            {
+                activeProfile = string.Empty;
+            }
+            return activeProfile.Equals(profileId);
         }
     }
 }

test/WebJobs.Script.Tests/Workers/Profiles/WorkerProfileManagerTests.cs

@@ -116,6 +116,81 @@ public void IsCorrectProfileLoaded_ConditionChange_ReturnsFalse()
             Assert.False(profileManager.IsCorrectProfileLoaded("java"));
         }
 
+        [Fact]
+        public void IsCorrectProfileLoaded_DifferentRuntimeNoProfile_ReturnsTrue()
+        {
+            var argumentList = new string[] { "-TestArg=1" };
+            var description = RpcWorkerConfigTestUtilities.GetTestDefaultWorkerDescription("java", argumentList);
+            var profiles = WorkerDescriptionProfileData("java", description);
+
+            _testEnvironment.SetEnvironmentVariable("APPLICATIONINSIGHTS_ENABLE_AGENT", "true");
+
+            WorkerProfileManager profileManager = new(_testLogger, _testEnvironment);
+            profileManager.SetWorkerDescriptionProfiles(profiles, "java");
+            profileManager.LoadWorkerDescriptionFromProfiles(description, out var workerDescription);
+
+            // Same profile should load as we didn't change any condition outcomes
+            Assert.True(profileManager.IsCorrectProfileLoaded("java"));
+
+            // Different runtime without profiles
+            Assert.True(profileManager.IsCorrectProfileLoaded("dotnet"));
+        }
+
+        [Fact]
+        public void IsCorrectProfileLoaded_DifferentRuntimeWithProfile_ReturnsTrue()
+        {
+            var argumentList = new string[] { "-TestArg=1" };
+            var description = RpcWorkerConfigTestUtilities.GetTestDefaultWorkerDescription("java", argumentList);
+            var profiles = WorkerDescriptionProfileData("java", description);
+
+            _testEnvironment.SetEnvironmentVariable("APPLICATIONINSIGHTS_ENABLE_AGENT", "true");
+
+            WorkerProfileManager profileManager = new(_testLogger, _testEnvironment);
+            profileManager.SetWorkerDescriptionProfiles(profiles, "java");
+            profileManager.LoadWorkerDescriptionFromProfiles(description, out var javaWorkerDescription);
+
+            var dotnetArgumentList = new string[] { "-TestArg=2" };
+            var dotnetDescription = RpcWorkerConfigTestUtilities.GetTestDefaultWorkerDescription("dotnet", dotnetArgumentList);
+            var dotnetProfiles = WorkerDescriptionProfileData("dotnet", dotnetDescription);
+
+            profileManager.SetWorkerDescriptionProfiles(dotnetProfiles, "dotnet");
+            profileManager.LoadWorkerDescriptionFromProfiles(dotnetDescription, out var dotnetWorkerDescription);
+
+            // Same profile should load as we didn't change any condition outcomes
+            Assert.True(profileManager.IsCorrectProfileLoaded("java"));
+
+            // Different runtime also loads same profile as we didn't change any condition outcomes
+            Assert.True(profileManager.IsCorrectProfileLoaded("dotnet"));
+        }
+
+        [Fact]
+        public void IsCorrectProfileLoaded_DifferentRuntimeWithProfile_ReturnsFalse()
+        {
+            var argumentList = new string[] { "-TestArg=1" };
+            var description = RpcWorkerConfigTestUtilities.GetTestDefaultWorkerDescription("java", argumentList);
+            var profiles = WorkerDescriptionProfileData("java", description);
+
+            _testEnvironment.SetEnvironmentVariable("APPLICATIONINSIGHTS_ENABLE_AGENT", "true");
+
+            WorkerProfileManager profileManager = new(_testLogger, _testEnvironment);
+            profileManager.SetWorkerDescriptionProfiles(profiles, "java");
+            profileManager.LoadWorkerDescriptionFromProfiles(description, out var javaWorkerDescription);
+
+            var dotnetArgumentList = new string[] { "-TestArg=2" };
+            var dotnetDescription = RpcWorkerConfigTestUtilities.GetTestDefaultWorkerDescription("dotnet", dotnetArgumentList);
+            var dotnetProfiles = WorkerDescriptionProfileData("dotnet", dotnetDescription);
+
+            profileManager.SetWorkerDescriptionProfiles(dotnetProfiles, "dotnet");
+            profileManager.LoadWorkerDescriptionFromProfiles(dotnetDescription, out var dotnetWorkerDescription);
+
+            // Same profile should load as we didn't change any condition outcomes
+            Assert.True(profileManager.IsCorrectProfileLoaded("java"));
+
+            // Changing the condition so a different profile evaluates to true
+            _testEnvironment.SetEnvironmentVariable("APPLICATIONINSIGHTS_ENABLE_AGENT", "false");
+            Assert.False(profileManager.IsCorrectProfileLoaded("dotnet"));
+        }
+
         public static List<WorkerDescriptionProfile> WorkerDescriptionProfileData(string language, RpcWorkerDescription description)
         {
             var conditionLogger = new TestLogger("ConditionLogger");