Fixing issue preserving script encoding

fabiocav · fabiocav · commit 4a460f182c66 · 2016-11-21T15:32:56.000-08:00
diff --git a/src/WebJobs.Script/Description/DotNet/CSharp/CSharpCompilationService.cs b/src/WebJobs.Script/Description/DotNet/CSharp/CSharpCompilationService.cs
@@ -63,10 +63,12 @@ private static string GetFunctionSource(FunctionMetadata functionMetadata)
 
             if (File.Exists(functionMetadata.ScriptFile))
             {
-                code = File.ReadAllText(functionMetadata.ScriptFile);
+                // We use ReadAllBytes here to make sure we preserve the BOM, if present.
+                var codeBytes = File.ReadAllBytes(functionMetadata.ScriptFile);
+                code = Encoding.UTF8.GetString(codeBytes);
             }
 
-            return Utility.RemoveUtf8ByteOrderMark(code ?? string.Empty);
+            return code ?? string.Empty;
         }
 
         private Compilation GetScriptCompilation(Script<object> script, FunctionMetadata functionMetadata)

Original file line number	Diff line number	Diff line change
`@@ -63,10 +63,12 @@ private static string GetFunctionSource(FunctionMetadata functionMetadata)`
`63`	`63`
`64`	`64`	`if (File.Exists(functionMetadata.ScriptFile))`
`65`	`65`	`{`
`66`		`- code = File.ReadAllText(functionMetadata.ScriptFile);`
	`66`	`+ // We use ReadAllBytes here to make sure we preserve the BOM, if present.`
	`67`	`+ var codeBytes = File.ReadAllBytes(functionMetadata.ScriptFile);`
	`68`	`+ code = Encoding.UTF8.GetString(codeBytes);`
`67`	`69`	`}`
`68`	`70`
`69`		`- return Utility.RemoveUtf8ByteOrderMark(code ?? string.Empty);`
	`71`	`+ return code ?? string.Empty;`
`70`	`72`	`}`
`71`	`73`
`72`	`74`	`private Compilation GetScriptCompilation(Script<object> script, FunctionMetadata functionMetadata)`