Adding error handling for host/log endpoint

Author: mathewc

src/WebJobs.Script.WebHost/Controllers/AdminController.cs

@@ -152,6 +152,11 @@ public IHttpActionResult Ping()
         [AllowAnonymous]
         public IHttpActionResult Log(IEnumerable<HostLogEntry> logEntries)
         {
+            if (logEntries == null)
+            {
+                return BadRequest("An array of log entry objects is expected.");
+            }
+
             var authorizationLevel = Request.GetAuthorizationLevel();
             if (Request.IsAuthDisabled() ||
                 authorizationLevel == AuthorizationLevel.Admin ||

test/WebJobs.Script.Tests.Integration/SamplesEndToEndTests.cs

@@ -1000,10 +1000,14 @@ public async Task HostLog_Anonymous_Fails()
         {
             var request = new HttpRequestMessage(HttpMethod.Post, "admin/host/log");
             request.Headers.Add(ScriptConstants.AntaresLogIdHeaderName, "xyz");
+            request.Content = new StringContent("[]");
+            request.Content.Headers.ContentType = new MediaTypeHeaderValue("application/json");
             var response = await this._fixture.HttpClient.SendAsync(request);
             Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
 
             request = new HttpRequestMessage(HttpMethod.Post, "admin/host/log");
+            request.Content = new StringContent("[]");
+            request.Content.Headers.ContentType = new MediaTypeHeaderValue("application/json");
             response = await this._fixture.HttpClient.SendAsync(request);
             Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
         }
@@ -1060,6 +1064,26 @@ public async Task HostLog_AdminLevel_Succeeds()
             }
         }
 
+        [Fact]
+        public async Task HostLog_SingletonLog_ReturnsBadRequest()
+        {
+            var request = new HttpRequestMessage(HttpMethod.Post, "admin/host/log");
+            request.Headers.Add(AuthorizationLevelAttribute.FunctionsKeyHeaderName, MasterKey);
+            var log = new HostLogEntry
+            {
+                Level = TraceLevel.Verbose,
+                Source = "ScaleController",
+                Message = string.Format("Test Verbose log {0}", Guid.NewGuid().ToString())
+            };
+            request.Content = new StringContent(log.ToString());
+            request.Content.Headers.ContentType = new MediaTypeHeaderValue("application/json");
+
+            var response = await this._fixture.HttpClient.SendAsync(request);
+            Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
+            var error = await response.Content.ReadAsAsync<HttpError>();
+            Assert.Equal("An array of log entry objects is expected.", error.Message);
+        }
+
         [Fact]
         public async Task HostStatus_AdminLevel_Succeeds()
         {