Skip to content

Commit 5019ba4

Browse files
authored
remove unused DocumentDD.Core package (#10503)
* remove unused DocumentDD.Core package * update release_notes.md * Update deps.json * Explicitly reference STJ in WebHost * Publish deps.json as artifact * Always copy deps.json artifact * Fix copy deps.json task * Update deps.json
1 parent 501d547 commit 5019ba4

File tree

6 files changed

+119
-510
lines changed

6 files changed

+119
-510
lines changed

eng/ci/templates/jobs/run-unit-tests.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,16 @@ jobs:
22
- job: RunUnitTests
33
displayName: Run Unit Tests
44

5+
templateContext:
6+
outputParentDirectory: $(Build.ArtifactStagingDirectory)
7+
outputs:
8+
# We publish this deps.json as differences in exact dotnet SDK version between dev and CI may make it impossible to generate locally.
9+
- output: pipelineArtifact
10+
displayName: Publish deps.json
11+
path: $(Build.ArtifactStagingDirectory)
12+
artifact: WebHost_Deps
13+
condition: always()
14+
515
steps:
616
- template: /eng/ci/templates/install-dotnet.yml@self
717

@@ -14,3 +24,11 @@ jobs:
1424
projects: |
1525
**\ExtensionsMetadataGeneratorTests.csproj
1626
**\WebJobs.Script.Tests.csproj
27+
28+
- task: CopyFiles@2
29+
displayName: Copy deps.json
30+
condition: always()
31+
inputs:
32+
SourceFolder: out/bin/WebJobs.Script.WebHost/debug
33+
Contents: '**/Microsoft.Azure.WebJobs.Script.WebHost.deps.json'
34+
TargetFolder: $(Build.ArtifactStagingDirectory)

release_notes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@
1414
- Sanitize exception logs (#10443)
1515
- Improving console log handling during specialization (#10345)
1616
- Update Node.js Worker Version to [3.10.1](https://github.com/Azure/azure-functions-nodejs-worker/releases/tag/v3.10.1)
17+
- Remove packages `Microsoft.Azure.Cosmos.Table` and `Microsoft.Azure.DocumentDB.Core` (#10503)

src/WebJobs.Script.WebHost/WebJobs.Script.WebHost.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@
7575
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.1" />
7676
<PackageReference Include="Microsoft.Azure.AppService.Middleware.Functions" Version="1.5.5" />
7777
<PackageReference Include="Microsoft.Azure.AppService.Proxy.Client" Version="2.3.20240307.67" />
78-
<PackageReference Include="Microsoft.Azure.Cosmos.Table" Version="1.0.8" />
7978
<PackageReference Include="Microsoft.Azure.Storage.File" Version="11.1.7" />
8079

8180
<PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.41" />

test/WebJobs.Script.Tests.Integration/WebJobs.Script.Tests.Integration.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
<NoWarn>NU1701</NoWarn>
4242
</PackageReference>
4343
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.1" />
44-
<PackageReference Include="Microsoft.Azure.DocumentDB.Core" Version="2.11.2" />
4544
<PackageReference Include="Microsoft.Azure.Functions.NodeJsWorker" Version="3.10.1" />
4645
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Storage" Version="4.0.5-11874" />
4746
<PackageReference Include="Microsoft.Azure.Functions.JavaWorker" Version="2.17.0" />

test/WebJobs.Script.Tests/DependencyTests.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ public void Verify_DepsJsonChanges()
6161
Assert.True(File.Exists(oldDepsJson), $"{oldDepsJson} not found.");
6262
Assert.True(File.Exists(newDepsJson), $"{newDepsJson} not found.");
6363

64-
IEnumerable<RuntimeFile> oldAssets = GetRuntimeFiles(oldDepsJson);
65-
IEnumerable<RuntimeFile> newAssets = GetRuntimeFiles(newDepsJson);
64+
IEnumerable<RuntimeFile> oldAssets = GetRuntimeFiles(oldDepsJson).ToList();
65+
IEnumerable<RuntimeFile> newAssets = GetRuntimeFiles(newDepsJson).ToList();
6666

6767
var comparer = new RuntimeFileComparer();
6868

@@ -163,8 +163,7 @@ public bool Equals([AllowNull] RuntimeFile x, [AllowNull] RuntimeFile y)
163163

164164
public int GetHashCode([DisallowNull] RuntimeFile obj)
165165
{
166-
string code = obj.Path + obj.AssemblyVersion + obj.FileVersion;
167-
return code.GetHashCode();
166+
return HashCode.Combine(obj.Path, obj.AssemblyVersion, obj.FileVersion);
168167
}
169168
}
170169
}

0 commit comments

Comments
 (0)