Rename WorkerChannelBase to WorkerChannel; replace OnDisposing with Dispose(bool) override

Address PR feedback:
- Rename WorkerChannelBase -> WorkerChannel (naming nit)
- Remove OnDisposing() virtual hook to avoid race with _disposing flag
- GrpcWorkerChannel now overrides Dispose(bool) directly, calling
  StopWorkerProcess() before base cleanup
- Set _disposing = true before Dispose(true) in base class

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: brettsam

src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs

@@ -20,7 +20,7 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Grpc
 {
-    internal class GrpcWorkerChannel : WorkerChannelBase
+    internal class GrpcWorkerChannel : WorkerChannel
     {
         private IWorkerProcess _rpcWorkerProcess;
 
@@ -86,9 +86,14 @@ public override async Task StartWorkerProcessAsync(CancellationToken cancellatio
             }
         }
 
-        protected override void OnDisposing()
+        protected override void Dispose(bool disposing)
         {
-            StopWorkerProcess();
+            if (disposing)
+            {
+                StopWorkerProcess();
+            }
+
+            base.Dispose(disposing);
         }
 
         protected override void DisposeWorkerResources()

…Script.Grpc/Channel/WorkerChannelBase.cs …obs.Script.Grpc/Channel/WorkerChannel.cssrc/WebJobs.Script.Grpc/Channel/WorkerChannelBase.cs renamed to src/WebJobs.Script.Grpc/Channel/WorkerChannel.cs src/WebJobs.Script.Grpc/Channel/WorkerChannelBase.cs renamed to src/WebJobs.Script.Grpc/Channel/WorkerChannel.cs

@@ -39,7 +39,7 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Grpc
 {
-    internal abstract partial class WorkerChannelBase : IRpcWorkerChannel, IDisposable
+    internal abstract partial class WorkerChannel : IRpcWorkerChannel, IDisposable
     {
         private readonly IScriptEventManager _eventManager;
         private readonly RpcWorkerConfig _workerConfig;
@@ -91,7 +91,7 @@ internal abstract partial class WorkerChannelBase : IRpcWorkerChannel, IDisposab
         private bool _functionMetadataRequestSent = false;
         private IOptions<ScriptJobHostOptions> _scriptHostOptions;
 
-        internal WorkerChannelBase(
+        internal WorkerChannel(
             string workerId,
             IScriptEventManager eventManager,
             IScriptHostManager hostManager,
@@ -180,8 +180,6 @@ protected RpcWorkerChannelState State
             set => _state = value;
         }
 
-        protected virtual void OnDisposing() { }
-
         protected virtual void DisposeWorkerResources() { }
 
         public abstract Task StartWorkerProcessAsync(CancellationToken cancellationToken);
@@ -1523,7 +1521,6 @@ protected virtual void Dispose(bool disposing)
 
         public void Dispose()
         {
-            OnDisposing();
             _disposing = true;
             Dispose(true);
         }