Making TryDeleteFunction async #5641

Author: mathewc

src/WebJobs.Script.WebHost/Controllers/FunctionsController.cs

@@ -167,7 +167,7 @@ public async Task<IActionResult> Delete(string name)
                 return NotFound();
             }
 
-            (var deleted, var error) = _functionsManager.TryDeleteFunction(function);
+            (var deleted, var error) = await _functionsManager.TryDeleteFunction(function);
 
             if (deleted)
             {

src/WebJobs.Script.WebHost/Management/IWebFunctionsManager.cs

@@ -16,6 +16,6 @@ public interface IWebFunctionsManager
 
         Task<(bool, bool, FunctionMetadataResponse)> CreateOrUpdate(string name, FunctionMetadataResponse functionMetadata, HttpRequest request);
 
-        (bool, string) TryDeleteFunction(FunctionMetadataResponse function);
+        Task<(bool, string)> TryDeleteFunction(FunctionMetadataResponse function);
     }
 }

src/WebJobs.Script.WebHost/Management/WebFunctionsManager.cs

@@ -184,7 +184,7 @@ await functionMetadata
         /// </summary>
         /// <param name="function">Function to be deleted</param>
         /// <returns>(success, errorMessage)</returns>
-        public (bool, string) TryDeleteFunction(FunctionMetadataResponse function)
+        public async Task<(bool, string)> TryDeleteFunction(FunctionMetadataResponse function)
         {
             try
             {
@@ -197,7 +197,7 @@ await functionMetadata
 
                 DeleteFunctionArtifacts(function);
 
-                _functionsSyncManager.TrySyncTriggersAsync();
+                await _functionsSyncManager.TrySyncTriggersAsync();
 
                 return (true, string.Empty);
             }