UploadFromFileAsync adds the byte order mark (BOM) unicode character

Author: alrod

src/WebJobs.Script.WebHost/Security/KeyManagement/BlobStorageSecretsMigrationRepository.cs

@@ -132,7 +132,9 @@ private async Task CopyKeysFromFileSystemToBlobStorage(BlobStorageSecretsReposit
                 {
                     string blobName = Path.GetFileName(file);
                     CloudBlockBlob cloudBlockBlob = blobStorageSecretsRepository.BlobContainer.GetBlockBlobReference(blobStorageSecretsRepository.SecretsBlobPath + "/" + blobName);
-                    Task copyTask = cloudBlockBlob.UploadFromFileAsync(file);
+
+                    string contents = File.ReadAllText(file);
+                    Task copyTask = cloudBlockBlob.UploadTextAsync(contents);
                     copyTasks.Add(copyTask);
                     _logger?.LogTrace("'{0}' was migrated.", cloudBlockBlob.StorageUri.PrimaryUri.AbsoluteUri.ToString());
                 }

test/WebJobs.Script.Tests.Integration/Host/SecretsRepositoryMigrationTests.cs

@@ -54,9 +54,9 @@ public async Task SecretMigrate_Successful()
                     var logs = loggerProvider.GetAllLogMessages().ToArray();
                     Assert.Contains(logs[logs.Length - 1].FormattedMessage, "Finished successfully.");
                     string hostContentFromBlob = await blobRepoMigration.ReadAsync(ScriptSecretsType.Host, "");
-                    Assert.Contains(hostContent, hostContentFromBlob);
+                    Assert.Equal(hostContent, hostContentFromBlob);
                     string hostContentFromFunction = await blobRepoMigration.ReadAsync(ScriptSecretsType.Function, "test1");
-                    Assert.Contains(functionContent, hostContentFromFunction);
+                    Assert.Equal(functionContent, hostContentFromFunction);
 
                     var blobRepoMigration2 = _fixture.GetBlobStorageSecretsMigrationRepository(loggerProvider.CreateLogger(""));
                     await blobRepoMigration2.ReadAsync(ScriptSecretsType.Host, "host");
@@ -105,7 +105,6 @@ public async Task SecretMigrate_Conflict()
                 {
                     _settingsManager.SetSetting(EnvironmentSettingNames.AzureWebsiteSlotName, null);
                     _settingsManager.SetSetting(EnvironmentSettingNames.AzureWebsiteName, null);
-                    
                 }
             }
         }