Skip to content

Commit 5e4e4a1

Browse files
committed
Removing unecessary response details trace
1 parent 9664f5f commit 5e4e4a1

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

src/WebJobs.Script.WebHost/Handlers/SystemTraceHandler.cs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,10 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
6565
{ "requestId", request.GetRequestId() },
6666
{ "method", request.Method.ToString() },
6767
{ "uri", request.RequestUri.LocalPath.ToString() },
68-
{ "authorizationLevel", request.GetAuthorizationLevel().ToString() }
69-
};
70-
TraceWriter.Info($"Executed HTTP request: {details}");
71-
72-
details = new JObject
73-
{
74-
{ "requestId", request.GetRequestId() },
68+
{ "authorizationLevel", request.GetAuthorizationLevel().ToString() },
7569
{ "status", response.StatusCode.ToString() }
7670
};
77-
TraceWriter.Info($"Response details: {details}");
71+
TraceWriter.Info($"Executed HTTP request: {details}");
7872

7973
return response;
8074
}

test/WebJobs.Script.Tests/Handlers/SystemTraceHandlerTests.cs

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public async Task SendAsync_WritesExpectedTraces()
5151
await _invoker.SendAsync(request, CancellationToken.None);
5252

5353
var traces = _traceWriter.GetTraces().ToArray();
54-
Assert.Equal(3, traces.Length);
54+
Assert.Equal(2, traces.Length);
5555

5656
// validate executing trace
5757
var trace = traces[0];
@@ -64,14 +64,7 @@ public async Task SendAsync_WritesExpectedTraces()
6464
trace = traces[1];
6565
Assert.Equal(TraceLevel.Info, trace.Level);
6666
message = Regex.Replace(trace.Message, @"\s+", string.Empty);
67-
Assert.Equal($"ExecutedHTTPrequest:{{\"requestId\":\"{requestId}\",\"method\":\"GET\",\"uri\":\"/api/testfunc\",\"authorizationLevel\":\"Function\"}}", message);
68-
Assert.Equal(ScriptConstants.TraceSourceHttpHandler, trace.Source);
69-
70-
// validate response trace
71-
trace = traces[2];
72-
Assert.Equal(TraceLevel.Info, trace.Level);
73-
message = Regex.Replace(trace.Message, @"\s+", string.Empty);
74-
Assert.Equal($"Responsedetails:{{\"requestId\":\"{requestId}\",\"status\":\"OK\"}}", message);
67+
Assert.Equal($"ExecutedHTTPrequest:{{\"requestId\":\"{requestId}\",\"method\":\"GET\",\"uri\":\"/api/testfunc\",\"authorizationLevel\":\"Function\",\"status\":\"OK\"}}", message);
7568
Assert.Equal(ScriptConstants.TraceSourceHttpHandler, trace.Source);
7669
}
7770
}

0 commit comments

Comments
 (0)