Fix functionName case in KubernetesSecretsRepository (#7362)

Author: ahmelsayed

src/WebJobs.Script.WebHost/Security/KeyManagement/KubernetesSecretsRepository.cs

@@ -59,6 +59,12 @@ public KubernetesSecretsRepository(IEnvironment environment, IKubernetesClient k
 
         public async Task<ScriptSecrets> ReadAsync(ScriptSecretsType type, string functionName)
         {
+            if (type == ScriptSecretsType.Function && string.IsNullOrEmpty(functionName))
+            {
+                throw new ArgumentNullException($"{nameof(functionName)} cannot be null or empty with {nameof(type)} = {nameof(ScriptSecretsType.Function)}");
+            }
+
+            functionName = functionName?.ToLowerInvariant();
             return type == ScriptSecretsType.Host ? await ReadHostSecrets() : await ReadFunctionSecrets(functionName);
         }
 
@@ -69,6 +75,12 @@ public async Task WriteAsync(ScriptSecretsType type, string functionName, Script
                 throw new InvalidOperationException($"{nameof(KubernetesSecretsRepository)} is readonly when no {EnvironmentSettingNames.AzureWebJobsKubernetesSecretName} is specified.");
             }
 
+            if (type == ScriptSecretsType.Function && string.IsNullOrEmpty(functionName))
+            {
+                throw new ArgumentNullException($"{nameof(functionName)} cannot be null or empty with {nameof(type)} = {nameof(ScriptSecretsType.Function)}");
+            }
+
+            functionName = functionName?.ToLowerInvariant();
             var newKeys = await Mergekeys(type, functionName, secrets);
             await _kubernetesClient.UpdateSecrets(newKeys);
         }

test/WebJobs.Script.Tests/Security/KubernetesSecretsRepositoryTests.cs

@@ -0,0 +1,66 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using System;
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using Microsoft.Azure.WebJobs.Script.WebHost;
+using Moq;
+using Xunit;
+
+namespace Microsoft.Azure.WebJobs.Script.Tests
+{
+    public class KubernetesSecretsRepositoryTests
+    {
+        [Fact]
+        public async Task Read_Write_Functions_Keys()
+        {
+            var environment = new TestEnvironment();
+            environment.SetEnvironmentVariable(EnvironmentSettingNames.AzureWebJobsKubernetesSecretName, "test");
+            environment.SetEnvironmentVariable(EnvironmentSettingNames.KubernetesServiceHost, "127.0.0.1");
+            environment.SetEnvironmentVariable(EnvironmentSettingNames.KubernetesServiceHttpsPort, "443");
+            IDictionary<string, string> configMapData = new Dictionary<string, string>();
+            var clientMock = new Mock<IKubernetesClient>(MockBehavior.Strict);
+            clientMock.Setup(c => c.GetSecrets()).ReturnsAsync(configMapData);
+            clientMock.SetupGet(c => c.IsWritable).Returns(true);
+            clientMock.Setup(c => c.OnSecretChange(It.IsAny<Action>()));
+            clientMock.Setup(c => c.UpdateSecrets(It.IsAny<IDictionary<string, string>>())).Returns<IDictionary<string, string>>(a =>
+            {
+                foreach (var k in a)
+                {
+                    configMapData[k.Key] = k.Value;
+                }
+                return Task.CompletedTask;
+            });
+
+            var repo = new KubernetesSecretsRepository(environment, clientMock.Object);
+
+            await repo.WriteAsync(ScriptSecretsType.Function, "FUNCTION1", new FunctionSecrets
+            {
+                Keys = new List<Key>
+                {
+                    new Key { Name = "Key1", Value = "value" },
+                    new Key { Name = "key2", Value = "value" }
+                }
+            });
+            await repo.WriteAsync(ScriptSecretsType.Function, "function2", new FunctionSecrets
+            {
+                Keys = new List<Key>
+                {
+                    new Key { Name = "Key1", Value = "value" },
+                    new Key { Name = "key2", Value = "value" }
+                }
+            });
+
+            var result = await repo.ReadAsync(ScriptSecretsType.Function, "function1");
+            Assert.NotNull(result);
+            Assert.Equal("value", result.GetFunctionKey("Key1", "function1").Value);
+            Assert.Equal("value", result.GetFunctionKey("key2", "function1").Value);
+
+            result = await repo.ReadAsync(ScriptSecretsType.Function, "function2");
+            Assert.NotNull(result);
+            Assert.Equal("value", result.GetFunctionKey("Key1", "function2").Value);
+            Assert.Equal("value", result.GetFunctionKey("key2", "function2").Value);
+        }
+    }
+}