Flaky test: FunctionsSyncServiceTests: Increase test due time & add tsc callback (#10146)

Author: liliankasem

test/WebJobs.Script.Tests/FunctionsSyncServiceTests.cs

@@ -24,7 +24,7 @@ public class FunctionsSyncServiceTests
         private readonly Mock<IFunctionsSyncManager> _mockSyncManager;
         private readonly Mock<IScriptWebHostEnvironment> _mockWebHostEnvironment;
         private readonly Mock<IEnvironment> _mockEnvironment;
-        private readonly int _testDueTime = 250;
+        private readonly int _testDueTime = 1000;
 
         public FunctionsSyncServiceTests()
         {
@@ -38,7 +38,6 @@ public FunctionsSyncServiceTests()
 
             _mockPrimaryHostStateProviderMock.Setup(p => p.IsPrimary).Returns(true);
             _mockScriptHostManager.Setup(p => p.State).Returns(ScriptHostState.Running);
-            _mockSyncManager.Setup(p => p.TrySyncTriggersAsync(true)).ReturnsAsync(new SyncTriggersResult { Success = true });
 
             _mockWebHostEnvironment = new Mock<IScriptWebHostEnvironment>(MockBehavior.Strict);
             _mockWebHostEnvironment.SetupGet(p => p.InStandbyMode).Returns(false);
@@ -67,9 +66,12 @@ public void ShouldSyncTriggers_ReturnsExpectedResult(bool isPrimary, ScriptHostS
         [Fact]
         public async Task StartAsync_PrimaryHost_Running_SyncsTriggers_AfterTimeout()
         {
+            TaskCompletionSource syncTriggers = new TaskCompletionSource();
+            _mockSyncManager.Setup(p => p.TrySyncTriggersAsync(true)).ReturnsAsync(new SyncTriggersResult { Success = true }).Callback(() => syncTriggers.TrySetResult());
+
             await _syncService.StartAsync(CancellationToken.None);
-            await Task.Delay(2 * _testDueTime);
 
+            await syncTriggers.Task.WaitAsync(TimeSpan.FromMilliseconds(2 * _testDueTime));
             _mockSyncManager.Verify(p => p.TrySyncTriggersAsync(true), Times.Once);
 
             var logMessage = _loggerProvider.GetAllLogMessages().Select(p => p.FormattedMessage).Single();
@@ -100,11 +102,12 @@ public async Task StopCalledBeforeTimeout_DoesNotSyncTriggers()
         [Fact]
         public async Task UnhandledExceptions_HandledInCallback()
         {
-            _mockSyncManager.Setup(p => p.TrySyncTriggersAsync(true)).ThrowsAsync(new Exception("Kaboom!"));
+            TaskCompletionSource syncTriggers = new TaskCompletionSource();
+            _mockSyncManager.Setup(p => p.TrySyncTriggersAsync(true)).ThrowsAsync(new Exception("Kaboom!")).Callback(() => syncTriggers.TrySetResult());
 
             await _syncService.StartAsync(CancellationToken.None);
-            await Task.Delay(2 * _testDueTime);
 
+            await syncTriggers.Task.WaitAsync(TimeSpan.FromMilliseconds(2 * _testDueTime));
             _mockSyncManager.Verify(p => p.TrySyncTriggersAsync(true), Times.Once);
         }