improve timeout if TestFunctionHost does not start

Author: brettsam

test/WebJobs.Script.Tests.Integration/TestFunctionHost.cs

@@ -167,10 +167,11 @@ public async Task RestartAsync(CancellationToken cancellationToken)
 
         private Task StartAsync()
         {
+            bool exit = false;
             var startTask = Task.Run(async () =>
             {
                 bool running = false;
-                while (!running)
+                while (!running && !exit)
                 {
                     running = await IsHostStarted();
 
@@ -187,6 +188,7 @@ private Task StartAsync()
             }
             else
             {
+                exit = true;
                 throw new Exception("Functions Host timed out trying to start.");
             }
 
@@ -282,7 +284,7 @@ public void Dispose()
             _testServer.Dispose();
         }
 
-        internal virtual async Task<bool> IsHostStarted()
+        private async Task<bool> IsHostStarted()
         {
             HostStatus status = await GetHostStatusAsync();
             return status.State == $"{ScriptHostState.Running}" || status.State == $"{ScriptHostState.Error}";

test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/HostConfigurationExceptionTests.cs

@@ -92,15 +92,6 @@ public TemporaryTestFunctionHost(string scriptPath, string logPath,
                 : base(scriptPath, logPath, configureWebHostServices, configureScriptHostWebJobsBuilder, configureScriptHostAppConfiguration, configureScriptHostLogging, configureScriptHostServices)
             {
             }
-
-            // Overriding this function as currently there's that causes HostState to be "Initialized" in case host.json has errors
-            // TODO: Once the issue is fixed, this class needs to be removed.
-            // https://github.com/Azure/azure-functions-host/issues/5959
-            internal override async Task<bool> IsHostStarted()
-            {
-                HostStatus status = await GetHostStatusAsync();
-                return status.State == $"{ScriptHostState.Running}" || status.State == $"{ScriptHostState.Error}" || status.State == $"{ScriptHostState.Initialized}";
-            }
         }
     }
 }