Updating the TryGetFunctions to refresh cache and allowing for an empty match. (#5101)

Author: soninaren

src/WebJobs.Script.WebHost/Management/WebFunctionsManager.cs

@@ -164,7 +164,7 @@ await functionMetadata
         public async Task<(bool, FunctionMetadataResponse)> TryGetFunction(string name, HttpRequest request)
         {
             var hostOptions = _applicationHostOptions.CurrentValue.ToHostOptions();
-            var functionMetadata = _functionMetadataProvider.GetFunctionMetadata().First(metadata => metadata.Name == name);
+            var functionMetadata = _functionMetadataProvider.GetFunctionMetadata(false).FirstOrDefault(metadata => metadata.Name == name);
             if (functionMetadata != null)
             {
                 string routePrefix = await GetRoutePrefix(hostOptions.RootScriptPath);

test/WebJobs.Script.Tests/Managment/WebFunctionsManagerTests.cs

@@ -7,17 +7,21 @@
 using System.IO;
 using System.IO.Abstractions;
 using System.Linq;
+using System.Net;
 using System.Net.Http;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.AspNetCore.Http;
 using Microsoft.Azure.WebJobs.Host.Executors;
+using Microsoft.Azure.WebJobs.Script.Binding;
 using Microsoft.Azure.WebJobs.Script.Description;
 using Microsoft.Azure.WebJobs.Script.Management.Models;
 using Microsoft.Azure.WebJobs.Script.Rpc;
 using Microsoft.Azure.WebJobs.Script.WebHost;
 using Microsoft.Azure.WebJobs.Script.WebHost.Extensions;
 using Microsoft.Azure.WebJobs.Script.WebHost.Management;
+using Microsoft.CodeAnalysis.VisualBasic.Syntax;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Abstractions;
@@ -38,6 +42,7 @@ public class WebFunctionsManagerTests : IDisposable
         private readonly ScriptApplicationHostOptions _hostOptions;
         private readonly WebFunctionsManager _webFunctionsManager;
         private readonly Mock<IEnvironment> _mockEnvironment;
+        private readonly IFileSystem _fileSystem;
 
         public WebFunctionsManagerTests()
         {
@@ -84,6 +89,7 @@ public WebFunctionsManagerTests()
 
             var workerOptions = new LanguageWorkerOptions();
             FileUtility.Instance = fileSystem;
+            _fileSystem = fileSystem;
             var languageWorkerOptions = new OptionsWrapper<LanguageWorkerOptions>(CreateLanguageWorkerConfigSettings());
             var metadataProvider = new FunctionMetadataProvider(optionsMonitor, languageWorkerOptions, NullLogger<FunctionMetadataProvider>.Instance);
             var functionsSyncManager = new FunctionsSyncManager(configurationMock.Object, hostIdProviderMock.Object, optionsMonitor, languageWorkerOptions, loggerFactory.CreateLogger<FunctionsSyncManager>(), httpClient, secretManagerProviderMock.Object, mockWebHostEnvironment.Object, _mockEnvironment.Object, hostNameProvider, metadataProvider);
@@ -101,6 +107,28 @@ public async Task ReadFunctionsMetadataSucceeds()
             Assert.Equal(1, unknownFunctions.Count());
         }
 
+        [Fact]
+        public async Task TryGetFunction_NoMatchingFunction_ReturnsEmpty()
+        {
+            var result = await _webFunctionsManager.TryGetFunction("non-function", null);
+            Assert.False(result.Item1);
+        }
+
+        [Fact]
+        public async Task TryGetFunction_NoFunction_ReturnsEmpty()
+        {
+            try
+            {
+                FileUtility.Instance = CreateEmptyFileSystem(_hostOptions);
+                var action = await _webFunctionsManager.TryGetFunction("function1", null);
+                Assert.False(action.Item1);
+            }
+            finally
+            {
+                FileUtility.Instance = _fileSystem;
+            }
+        }
+
         [Theory]
         [InlineData(null, "api")]
         [InlineData("", "api")]
@@ -177,6 +205,31 @@ private static LanguageWorkerOptions CreateLanguageWorkerConfigSettings()
             };
         }
 
+        private static IFileSystem CreateEmptyFileSystem(ScriptApplicationHostOptions options)
+        {
+            string rootPath = options.ScriptPath;
+            string testDataPath = options.TestDataPath;
+
+            var fullFileSystem = new FileSystem();
+            var fileSystem = new Mock<IFileSystem>();
+            var fileBase = new Mock<FileBase>();
+            var dirBase = new Mock<DirectoryBase>();
+
+            fileSystem.SetupGet(f => f.Path).Returns(fullFileSystem.Path);
+            fileSystem.SetupGet(f => f.File).Returns(fileBase.Object);
+            fileBase.Setup(f => f.Exists(Path.Combine(rootPath, "host.json"))).Returns(true);
+
+            var hostJson = new MemoryStream(Encoding.UTF8.GetBytes(@"{ ""durableTask"": { ""HubName"": ""TestHubValue"", ""azureStorageConnectionStringName"": ""DurableStorage"" }}"));
+            hostJson.Position = 0;
+            fileBase.Setup(f => f.Open(Path.Combine(rootPath, @"host.json"), It.IsAny<FileMode>(), It.IsAny<FileAccess>(), It.IsAny<FileShare>())).Returns(hostJson);
+
+            fileSystem.SetupGet(f => f.Directory).Returns(dirBase.Object);
+
+            dirBase.Setup(d => d.Exists(options.ScriptPath)).Returns(true);
+            dirBase.Setup(d => d.EnumerateDirectories(rootPath)).Returns(new string[0]);
+            return fileSystem.Object;
+        }
+
         private static IFileSystem CreateFileSystem(ScriptApplicationHostOptions options)
         {
             string rootPath = options.ScriptPath;