Restrict details message length to 10K characters (#5264)

divyagandhisethi · web-flow · commit 6d341d250c0c · 2019-11-18T17:36:54.000-08:00
diff --git a/src/WebJobs.Script.WebHost/Diagnostics/LinuxContainerEventGenerator.cs b/src/WebJobs.Script.WebHost/Diagnostics/LinuxContainerEventGenerator.cs
@@ -11,6 +11,7 @@ namespace Microsoft.Azure.WebJobs.Script.WebHost.Diagnostics
 {
     internal class LinuxContainerEventGenerator : LinuxEventGenerator
     {
+        private const int MaxDetailsLength = 10000;
         private readonly Action<string> _writeEvent;
         private readonly bool _consoleEnabled = true;
         private readonly IEnvironment _environment;
@@ -68,6 +69,7 @@ public override void LogFunctionTraceEvent(LogLevel level, string subscriptionId
             string eventTimestamp = DateTime.UtcNow.ToString(EventTimestampFormat);
             string hostVersion = ScriptHost.Version;
             FunctionsSystemLogsEventSource.Instance.SetActivityId(activityId);
+            details = details.Length > MaxDetailsLength ? details.Substring(0, MaxDetailsLength) : details;
 
             _writeEvent($"{ScriptConstants.LinuxLogEventStreamName} {(int)ToEventLevel(level)},{subscriptionId},{appName},{functionName},{eventName},{source},{NormalizeString(details)},{NormalizeString(summary)},{hostVersion},{eventTimestamp},{exceptionType},{NormalizeString(exceptionMessage)},{functionInvocationId},{hostInstanceId},{activityId},{_containerName},{StampName},{TenantId}");
         }

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ namespace Microsoft.Azure.WebJobs.Script.WebHost.Diagnostics`
`11`	`11`	`{`
`12`	`12`	`internal class LinuxContainerEventGenerator : LinuxEventGenerator`
`13`	`13`	`{`
	`14`	`+ private const int MaxDetailsLength = 10000;`
`14`	`15`	`private readonly Action<string> _writeEvent;`
`15`	`16`	`private readonly bool _consoleEnabled = true;`
`16`	`17`	`private readonly IEnvironment _environment;`
`@@ -68,6 +69,7 @@ public override void LogFunctionTraceEvent(LogLevel level, string subscriptionId`
`68`	`69`	`string eventTimestamp = DateTime.UtcNow.ToString(EventTimestampFormat);`
`69`	`70`	`string hostVersion = ScriptHost.Version;`
`70`	`71`	`FunctionsSystemLogsEventSource.Instance.SetActivityId(activityId);`
	`72`	`+ details = details.Length > MaxDetailsLength ? details.Substring(0, MaxDetailsLength) : details;`
`71`	`73`
`72`	`74`	`_writeEvent($"{ScriptConstants.LinuxLogEventStreamName} {(int)ToEventLevel(level)},{subscriptionId},{appName},{functionName},{eventName},{source},{NormalizeString(details)},{NormalizeString(summary)},{hostVersion},{eventTimestamp},{exceptionType},{NormalizeString(exceptionMessage)},{functionInvocationId},{hostInstanceId},{activityId},{_containerName},{StampName},{TenantId}");`
`73`	`75`	`}`