First pieces of native placeholder support (#9145)

Co-authored-by: Shyju Krishnankutty <[email protected]>

Author: brettsam

src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs

@@ -589,8 +589,11 @@ internal FunctionEnvironmentReloadRequest GetFunctionEnvironmentReloadRequest(ID
                     request.EnvironmentVariables.Add(entry.Key.ToString(), entry.Value.ToString());
                 }
             }
-            request.EnvironmentVariables.Add(WorkerConstants.FunctionsWorkerDirectorySettingName, _workerConfig.Description.WorkerDirectory);
-            request.FunctionAppDirectory = _applicationHostOptions.CurrentValue.ScriptPath;
+
+            string scriptRoot = _applicationHostOptions.CurrentValue.ScriptPath;
+            request.EnvironmentVariables.TryAdd(WorkerConstants.FunctionsWorkerDirectorySettingName, _workerConfig.Description.WorkerDirectory);
+            request.EnvironmentVariables.TryAdd(WorkerConstants.FunctionsApplicationDirectorySettingName, scriptRoot);
+            request.FunctionAppDirectory = scriptRoot;
 
             return request;
         }

src/WebJobs.Script/Environment/EnvironmentExtensions.cs

@@ -36,6 +36,11 @@ public static bool IsPlaceholderModeEnabled(this IEnvironment environment)
             return environment.GetEnvironmentVariable(AzureWebsitePlaceholderMode) == "1";
         }
 
+        public static bool UsePlaceholderDotNetIsolated(this IEnvironment environment)
+        {
+            return environment.GetEnvironmentVariable(AzureWebsiteUsePlaceholderDotNetIsolated) == "1";
+        }
+
         public static bool IsLegacyPlaceholderTemplateSite(this IEnvironment environment)
         {
             string siteName = environment.GetEnvironmentVariable(AzureWebsiteName);

src/WebJobs.Script/Environment/EnvironmentSettingNames.cs

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
-using System.Dynamic;
-
 namespace Microsoft.Azure.WebJobs.Script
 {
     public static class EnvironmentSettingNames
@@ -15,6 +13,7 @@ public static class EnvironmentSettingNames
         public const string AzureWebsiteSku = "WEBSITE_SKU";
         public const string RemoteDebuggingPort = "REMOTEDEBUGGINGPORT";
         public const string AzureWebsitePlaceholderMode = "WEBSITE_PLACEHOLDER_MODE";
+        public const string AzureWebsiteUsePlaceholderDotNetIsolated = "WEBSITE_USE_PLACEHOLDER_DOTNETISOLATED";
         public const string InitializedFromPlaceholder = "INITIALIZED_FROM_PLACEHOLDER";
         public const string AzureWebsiteHomePath = "HOME";
         public const string AzureWebJobsScriptRoot = "AzureWebJobsScriptRoot";
@@ -123,7 +122,7 @@ public static class EnvironmentSettingNames
         public const string CorsAllowedOrigins = "CORS_ALLOWED_ORIGINS";
         public const string CorsSupportCredentials = "CORS_SUPPORT_CREDENTIALS";
 
-       // EasyAuth settings
+        // EasyAuth settings
         public const string EasyAuthClientId = "WEBSITE_AUTH_CLIENT_ID";
         public const string EasyAuthSigningKey = "WEBSITE_AUTH_SIGNING_KEY";
 

src/WebJobs.Script/Host/FunctionMetadataManager.cs

@@ -14,7 +14,6 @@
 using Microsoft.Azure.WebJobs.Script.Workers.Http;
 using Microsoft.Azure.WebJobs.Script.Workers.Rpc;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 
@@ -51,9 +50,12 @@ public FunctionMetadataManager(IOptions<ScriptJobHostOptions> scriptOptions, IFu
 
             // Every time script host is re-intializing, we also need to re-initialize
             // services that change with the scope of the script host.
-            scriptHostManager.HostInitializing += (s, e) =>
+            scriptHostManager.ActiveHostChanged += (s, e) =>
             {
-                InitializeServices();
+                if (e.NewHost is not null)
+                {
+                    InitializeServices();
+                }
             };
         }
 

src/WebJobs.Script/WebJobs.Script.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <Import Project="..\..\build\common.props" />
   <PropertyGroup>
     <PackageId>Microsoft.Azure.WebJobs.Script</PackageId>
@@ -47,6 +47,7 @@
     <PackageReference Include="Microsoft.ApplicationInsights.DependencyCollector" Version="2.21.0" />
     <PackageReference Include="Microsoft.ApplicationInsights.WindowsServer" Version="2.21.0" />
     <PackageReference Include="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel" Version="2.21.0" />
+    <PackageReference Include="Microsoft.Azure.Functions.DotNetIsolatedNativeHost" Version="1.0.0-preview6" />
     <PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.36" />
     <PackageReference Include="Microsoft.Azure.WebJobs.Host.Storage" Version="5.0.0-beta.2-11957" />
     <PackageReference Include="Microsoft.Extensions.Azure" Version="1.1.1" />

src/WebJobs.Script/Workers/ProcessManagement/DefaultWorkerProcessFactory.cs

@@ -57,6 +57,7 @@ public virtual Process CreateWorkerProcess(WorkerContext context)
                 foreach (var envVar in processEnvVariables)
                 {
                     startInfo.EnvironmentVariables[envVar.Key] = envVar.Value;
+                    startInfo.FileName = startInfo.FileName.Replace($"%{envVar.Key}%", envVar.Value);
                     startInfo.Arguments = startInfo.Arguments.Replace($"%{envVar.Key}%", envVar.Value);
                 }
                 startInfo.Arguments = SanitizeExpandedArgument(startInfo.Arguments);

src/WebJobs.Script/Workers/ProcessManagement/WorkerDescription.cs

@@ -19,29 +19,29 @@ public abstract class WorkerDescription
         public string DefaultExecutablePath { get; set; }
 
         /// <summary>
-        /// Gets or sets the default path to the worker
+        /// Gets or sets the default path to the worker.
         /// </summary>
         public string DefaultWorkerPath { get; set; }
 
         /// <summary>
-        /// Gets or sets the default base directory for the worker
+        /// Gets or sets the default base directory for the worker.
         /// </summary>
         public string WorkerDirectory { get; set; }
 
         /// <summary>
-        /// Gets or sets the command line args to pass to the worker. Will be appended after DefaultExecutablePath but before DefaultWorkerPath
+        /// Gets or sets the command line args to pass to the worker. Will be appended after DefaultExecutablePath but before DefaultWorkerPath.
         /// </summary>
         public IList<string> Arguments { get; set; }
 
         /// <summary>
-        /// Gets or sets the command line args to pass to the worker. Will be appended after DefaultWorkerPath
+        /// Gets or sets the command line args to pass to the worker. Will be appended after DefaultWorkerPath.
         /// </summary>
         public IList<string> WorkerArguments { get; set; }
 
         /// <summary>
         /// Gets or sets a value indicating whether to use stderror stream for all console logs. Default false.
-        /// If set to false, Logs from stderr are written with info level by default. If Message contains keywords: error, servere then logs are written with error level.
-        /// If set to true, Logs from stdout stream will be written with info level and Logs from stderr steam will be written with error level
+        /// If set to false, Logs from stderr are written with info level by default. If Message contains keywords: error, severe then logs are written with error level.
+        /// If set to true, Logs from stdout stream will be written with info level and Logs from stderr steam will be written with error level.
         /// </summary>
         public abstract bool UseStdErrorStreamForErrorsOnly { get; set; }
 

src/WebJobs.Script/Workers/Rpc/RpcWorkerProcess.cs

@@ -55,6 +55,7 @@ internal override Process CreateWorkerProcess()
         {
             var workerContext = new RpcWorkerContext(Guid.NewGuid().ToString(), RpcWorkerConstants.DefaultMaxMessageLengthBytes, _workerId, _workerProcessArguments, _scriptRootPath, _serverUri);
             workerContext.EnvironmentVariables.Add(WorkerConstants.FunctionsWorkerDirectorySettingName, _workerDirectory);
+            workerContext.EnvironmentVariables.Add(WorkerConstants.FunctionsApplicationDirectorySettingName, _scriptRootPath);
             foreach (var pair in _hostingConfigOptions.Value.Features)
             {
                 workerContext.EnvironmentVariables[pair.Key] = pair.Value;

src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs

@@ -124,7 +124,7 @@ public async Task SpecializeAsync()
 
             if (_workerRuntime != null && rpcWorkerChannel != null)
             {
-                if (UsePlaceholderChannel(_workerRuntime))
+                if (UsePlaceholderChannel(rpcWorkerChannel))
                 {
                     _logger.LogDebug("Loading environment variables for runtime: {runtime}", _workerRuntime);
                     await rpcWorkerChannel.SendFunctionEnvironmentReloadRequest();
@@ -156,8 +156,10 @@ public async Task WorkerWarmupAsync()
             }
         }
 
-        private bool UsePlaceholderChannel(string workerRuntime)
+        private bool UsePlaceholderChannel(IRpcWorkerChannel channel)
         {
+            string workerRuntime = channel?.WorkerConfig?.Description?.Language;
+
             if (string.IsNullOrEmpty(workerRuntime))
             {
                 return false;
@@ -170,6 +172,26 @@ private bool UsePlaceholderChannel(string workerRuntime)
                 return false;
             }
 
+            if (workerRuntime.Equals(RpcWorkerConstants.DotNetIsolatedLanguageWorkerName, StringComparison.OrdinalIgnoreCase))
+            {
+                bool placeholderEnabled = _environment.UsePlaceholderDotNetIsolated();
+                _logger.LogDebug("UsePlaceholderDotNetIsolated: {placeholderEnabled}", placeholderEnabled);
+
+                if (!placeholderEnabled)
+                {
+                    return false;
+                }
+
+                // Do not specialize if the placeholder is 6.0 but the site is 7.0 (for example).
+                var currentWorkerRuntimeVersion = _environment.GetEnvironmentVariable(RpcWorkerConstants.FunctionWorkerRuntimeVersionSettingName);
+                channel.WorkerProcess.Process.StartInfo.Environment.TryGetValue(RpcWorkerConstants.FunctionWorkerRuntimeVersionSettingName, out string placeholderWorkerRuntimeVersion);
+                bool versionMatches = string.Equals(currentWorkerRuntimeVersion, placeholderWorkerRuntimeVersion, StringComparison.OrdinalIgnoreCase);
+                _logger.LogDebug("Placeholder runtime version: '{placeholderWorkerRuntimeVersion}'. Site runtime version: '{currentWorkerRuntimeVersion}'. Match: {versionMatches}",
+                    placeholderWorkerRuntimeVersion, currentWorkerRuntimeVersion, versionMatches);
+
+                return versionMatches;
+            }
+
             // Special case: node and PowerShell apps must be read-only to use the placeholder mode channel
             // Also cannot use placeholder worker that is targeting ~3 but has backwards compatibility with V2 enabled
             // TODO: Remove special casing when resolving https://github.com/Azure/azure-functions-host/issues/4534

src/WebJobs.Script/Workers/WorkerConstants.cs

@@ -19,6 +19,7 @@ public static class WorkerConstants
 
         // Environment variables names
         public const string FunctionsWorkerDirectorySettingName = "FUNCTIONS_WORKER_DIRECTORY";
+        public const string FunctionsApplicationDirectorySettingName = "FUNCTIONS_APPLICATION_DIRECTORY";
 
         // Worker description constants
         public const string WorkerDescriptionDefaultExecutablePath = "defaultExecutablePath";