Skip to content

Commit 71ec0ba

Browse files
committed
Fix conflicts and update Patch Version
1 parent c09e93a commit 71ec0ba

File tree

2 files changed

+1
-23
lines changed

2 files changed

+1
-23
lines changed

build/common.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<LangVersion>7.2</LangVersion>
66
<MajorVersion>3</MajorVersion>
77
<MinorVersion>4</MinorVersion>
8-
<PatchVersion>1</PatchVersion>
8+
<PatchVersion>2</PatchVersion>
99
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
1010
<Version Condition=" '$(BuildNumber)' != '' ">$(VersionPrefix)-$(BuildNumber)</Version>
1111
<Version Condition=" '$(Version)' == '' ">$(VersionPrefix)</Version>

src/WebJobs.Script.WebHost/Management/FunctionsSyncManager.cs

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -161,28 +161,6 @@ public async Task<SyncTriggersResult> TrySyncTriggersAsync(bool isBackgroundSync
161161
return result;
162162
}
163163

164-
/// <summary>
165-
/// SyncTriggers is performed whenever deployments or other changes are made to the application.
166-
/// There are some operations we want to perform whenever this happens.
167-
/// </summary>
168-
private void PrepareSyncTriggers()
169-
{
170-
// We clear cache to ensure that secrets are reloaded. This is important because secrets are part
171-
// of the StartupContext payload (see StartupContextProvider) and that payload comes from the
172-
// SyncTriggers operation. So there's a chicken and egg situation here. Consider the following scenario:
173-
// - app is using blob storage for keys
174-
// - a SyncTriggers operation has happened previously and the StartupContext has key info
175-
// - app instances initialize keys from StartupContext (keys aren't loaded from storage)
176-
// - user updates the app to use a new storage account
177-
// - a SyncTriggers operation is performed
178-
// - the app initializes from StartupContext, and **previous old key info is loaded**
179-
// - the SyncTriggers operation uses this old key info, so trigger cache is never updated with new key info
180-
// - Portal/ARM APIs will continue to show old key info.
181-
// By clearing cache, we ensure that this host instance reloads keys when they're requested, and the SyncTriggers
182-
// operation will contain current keys.
183-
_secretManagerProvider.Current.ClearCache();
184-
}
185-
186164
/// <summary>
187165
/// SyncTriggers is performed whenever deployments or other changes are made to the application.
188166
/// There are some operations we want to perform whenever this happens.

0 commit comments

Comments
 (0)