Skip to content

Commit 72dcf0f

Browse files
authored
Enable BreakingChangeAnalysis only when running in Azure (#6307)
1 parent 4478552 commit 72dcf0f

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/WebJobs.Script.WebHost/DependencyInjection/DependencyValidator/DependencyValidator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ private static ExpectedDependencyBuilder CreateExpectedDependencies()
4848
.Expect<FileMonitoringService>()
4949
.Expect<WorkerConsoleLogService>()
5050
.Expect<FunctionInvocationDispatcherShutdownManager>()
51-
.Expect<ChangeAnalysisService>()
51+
.Optional<ChangeAnalysisService>()
5252
.Optional<FunctionsScaleMonitorService>()
5353
.Optional<FuncAppFileProvisioningService>() // Used by powershell.
5454
.Optional<JobHostService>() // Missing when host is offline.

src/WebJobs.Script.WebHost/WebScriptHostBuilderExtension.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,12 @@ public static IHostBuilder AddWebScriptHost(this IHostBuilder builder, IServiceP
106106
}
107107
services.TryAddSingleton<IScaleMetricsRepository, TableStorageScaleMetricsRepository>();
108108

109-
services.AddSingleton<IChangeAnalysisStateProvider, BlobChangeAnalysisStateProvider>();
109+
if (environment.IsWindowsAzureManagedHosting() || environment.IsLinuxAzureManagedHosting())
110+
{
111+
// Enable breaking change analysis only when hosted in Azure
112+
services.AddSingleton<IChangeAnalysisStateProvider, BlobChangeAnalysisStateProvider>();
113+
services.AddSingleton<IHostedService, ChangeAnalysisService>();
114+
}
110115

111116
// Make sure the registered IHostIdProvider is used
112117
IHostIdProvider provider = rootServiceProvider.GetService<IHostIdProvider>();
@@ -123,7 +128,6 @@ public static IHostBuilder AddWebScriptHost(this IHostBuilder builder, IServiceP
123128

124129
// Hosted services
125130
services.TryAddEnumerable(ServiceDescriptor.Singleton<IHostedService, FileMonitoringService>());
126-
services.AddSingleton<IHostedService, ChangeAnalysisService>();
127131

128132
ConfigureRegisteredBuilders(services, rootServiceProvider);
129133
});

0 commit comments

Comments
 (0)