flattening errors before logging

Author: brettsam

src/WebJobs.Script/Host/ScriptHost.cs

@@ -635,7 +635,7 @@ private Collection<FunctionDescriptor> ReadFunctions(IEnumerable<FunctionDescrip
                 catch (Exception ex)
                 {
                     // log any unhandled exceptions and continue
-                    AddFunctionError(functionName, ex.Message);
+                    AddFunctionError(functionName, Utility.FlattenException(ex, includeSource: false));
                 }
             }
 
@@ -669,7 +669,7 @@ internal static bool TryParseFunctionMetadata(string functionName, JObject funct
             string scriptFile = DeterminePrimaryScriptFile(functionConfig, functionFiles);
             if (string.IsNullOrEmpty(scriptFile))
             {
-                error = 
+                error =
                     "Unable to determine the primary function script. Try renaming your entry point script to 'run' (or 'index' in the case of Node), " +
                     "or alternatively you can specify the name of the entry point script explicitly by adding a 'scriptFile' property to your function metadata.";
                 return false;
@@ -830,7 +830,7 @@ internal Collection<FunctionDescriptor> ReadFunctions(List<FunctionMetadata> fun
                 catch (Exception ex)
                 {
                     // log any unhandled exceptions and continue
-                    AddFunctionError(metadata.Name, ex.Message);
+                    AddFunctionError(metadata.Name, Utility.FlattenException(ex, includeSource: false));
                 }
             }
 

src/WebJobs.Script/Utility.cs

@@ -49,7 +49,7 @@ public static string GetFunctionShortName(string functionName)
             return functionName;
         }
 
-        public static string FlattenException(Exception ex, Func<string, string> sourceFormatter = null)
+        public static string FlattenException(Exception ex, Func<string, string> sourceFormatter = null, bool includeSource = true)
         {
             StringBuilder flattenedErrorsBuilder = new StringBuilder();
             string lastError = null;
@@ -63,7 +63,7 @@ public static string FlattenException(Exception ex, Func<string, string> sourceF
             do
             {
                 StringBuilder currentErrorBuilder = new StringBuilder();
-                if (!string.IsNullOrEmpty(ex.Source))
+                if (includeSource && !string.IsNullOrEmpty(ex.Source))
                 {
                     currentErrorBuilder.AppendFormat("{0}: ", sourceFormatter(ex.Source));
                 }