Added support for Excluded/Included types for App insights sampling.

Author: gzuber

src/WebJobs.Script/Config/ApplicationInsightsLoggerOptionsSetup.cs

@@ -33,7 +33,7 @@ public void Configure(ApplicationInsightsLoggerOptions options)
             // IConfiguration will cause the SnapshotConfiguration to be created and the TelemetryProcessor to be applied.
             _configuration.Bind(options);
 
-            ApplySamplingIsEnabled(options);
+            ApplySamplingSettings(options);
 
             string quickPulseKey = _environment.GetEnvironmentVariable(EnvironmentSettingNames.AppInsightsQuickPulseAuthApiKey);
             if (!string.IsNullOrEmpty(quickPulseKey))
@@ -42,7 +42,7 @@ public void Configure(ApplicationInsightsLoggerOptions options)
             }
         }
 
-        private void ApplySamplingIsEnabled(ApplicationInsightsLoggerOptions options)
+        private void ApplySamplingSettings(ApplicationInsightsLoggerOptions options)
         {
             // Sampling settings do not have a built-in "IsEnabled" value, so we are making our own.
             string samplingPath = nameof(ApplicationInsightsLoggerOptions.SamplingSettings);
@@ -51,7 +51,12 @@ private void ApplySamplingIsEnabled(ApplicationInsightsLoggerOptions options)
             if (!samplingEnabled)
             {
                 options.SamplingSettings = null;
+                return;
             }
+
+            // Excluded/Included types must be moved from SamplingSettings to their respective properties in logger options
+            options.SamplingExcludedTypes = _configuration.GetSection(samplingPath).GetValue<string>("ExcludedTypes", null);
+            options.SamplingIncludedTypes = _configuration.GetSection(samplingPath).GetValue<string>("IncludedTypes", null);
         }
     }
 }

test/WebJobs.Script.Tests/Configuration/ApplicationInsightsLoggerOptionsSetupTests.cs

@@ -52,6 +52,33 @@ public void Configure_SamplingDisabled_IgnoresOtherSettings()
             setup.Configure(options);
 
             Assert.Null(options.SamplingSettings);
+            Assert.Null(options.SamplingExcludedTypes);
+            Assert.Null(options.SamplingIncludedTypes);
+        }
+
+        [Fact]
+        public void Configure_SamplingExcludedIncludedTypes_AppliesSettings()
+        {
+            string excludedTypes = "Dependency;Event";
+            string includedTypes = "PageView;Trace";
+
+            IConfiguration config = new ConfigurationBuilder()
+               .AddInMemoryCollection(new Dictionary<string, string>
+               {
+                   { $"{SamplingSettings}:MaxTelemetryItemsPerSecond", "25" },
+                   { $"{SamplingSettings}:IsEnabled", "true" },
+                   { $"{SamplingSettings}:ExcludedTypes", excludedTypes },
+                   { $"{SamplingSettings}:IncludedTypes", includedTypes },
+               })
+               .Build();
+
+            ApplicationInsightsLoggerOptionsSetup setup = new ApplicationInsightsLoggerOptionsSetup(new MockLoggerConfiguration(config), _environment);
+
+            ApplicationInsightsLoggerOptions options = new ApplicationInsightsLoggerOptions();
+            setup.Configure(options);
+
+            Assert.Equal(excludedTypes, options.SamplingExcludedTypes);
+            Assert.Equal(includedTypes, options.SamplingIncludedTypes);
         }
 
         [Fact]