Ensuring function name comparison is done consistently

Author: fabiocav

src/WebJobs.Script.WebHost/Diagnostics/FunctionInstanceLogger.cs

@@ -126,7 +126,7 @@ private FunctionMetadata GetFunctionMetadata(string functionName)
         {
             FunctionMetadata GetMetadataFromCollection(IEnumerable<FunctionMetadata> functions)
             {
-                return functions.FirstOrDefault(p => string.Equals(p.Name, functionName, StringComparison.OrdinalIgnoreCase));
+                return functions.FirstOrDefault(p => Utility.FunctionNamesMatch(p.Name, functionName));
             }
 
             return GetMetadataFromCollection(_metadataManager.Functions)

src/WebJobs.Script.WebHost/Management/WebFunctionsManager.cs

@@ -165,7 +165,7 @@ await functionMetadata
         {
             var hostOptions = _applicationHostOptions.CurrentValue.ToHostOptions();
             var functionMetadata = _functionMetadataProvider.GetFunctionMetadata(true)
-                .FirstOrDefault(metadata => metadata.Name == name);
+                .FirstOrDefault(metadata => Utility.FunctionNamesMatch(metadata.Name, name));
 
             if (functionMetadata != null)
             {

src/WebJobs.Script/Host/FunctionMetadataManager.cs

@@ -47,7 +47,7 @@ private ImmutableArray<FunctionMetadata> LoadFunctionMetadata()
             if (functionsWhiteList != null)
             {
                 _logger.LogInformation($"A function whitelist has been specified, excluding all but the following functions: [{string.Join(", ", functionsWhiteList)}]");
-                metadata = metadata.Where(function => functionsWhiteList.Any(functionName => functionName.Equals(function.Name, StringComparison.CurrentCultureIgnoreCase))).ToImmutableArray();
+                metadata = metadata.Where(function => functionsWhiteList.Any(functionName => Utility.FunctionNamesMatch(function.Name, functionName))).ToImmutableArray();
                 Errors = _functionMetadataProvider.FunctionErrors.Where(kvp => functionsWhiteList.Any(functionName => functionName.Equals(kvp.Key, StringComparison.CurrentCultureIgnoreCase))).ToImmutableDictionary<string, ImmutableArray<string>>();
             }
             _logger.FunctionMetadataManagerFunctionsLoaded(metadata.Length);

src/WebJobs.Script/Utility.cs

@@ -172,6 +172,11 @@ public static bool IsValidFunctionName(string functionName)
             return FunctionNameValidationRegex.IsMatch(functionName);
         }
 
+        public static bool FunctionNamesMatch(string functionName, string comparand)
+        {
+            return string.Equals(functionName, comparand, StringComparison.OrdinalIgnoreCase);
+        }
+
         // "Namespace.Class.Method" --> "Namespace.Class"
         public static string GetFullClassName(string fullFunctionName)
         {

test/WebJobs.Script.Tests/UtilityTests.cs

@@ -99,6 +99,27 @@ public async Task DelayWithBackoffAsync_DelaysAsExpected()
             Assert.True(roundedElapsedSpan >= TimeSpan.FromSeconds(2), $"Expected roundedElapsedSpan >= TimeSpan.FromSeconds(2); Actual: {roundedElapsedSpan.TotalSeconds}");
         }
 
+        [Theory]
+        [InlineData("Function1", "Function1", "en-US", true)]
+        [InlineData("function1", "Function1", "en-US", true)]
+        [InlineData("Função", "FunçÃo", "pt-BR", true)]
+        [InlineData("HttptRIGGER", "Httptrigger", "ja-JP", true)]
+        [InlineData("Iasdf1", "iasdf1", "tr-TR", true)]
+        public void FunctionNamesMatch_ReturnsExpectedResult(string functionNameA, string functionNameB, string cultureInfo, bool expectMatch)
+        {
+            CultureInfo environmentCulture = Thread.CurrentThread.CurrentCulture;
+
+            try
+            {
+                Thread.CurrentThread.CurrentCulture = new CultureInfo(cultureInfo);
+                Assert.Equal(expectMatch, Utility.FunctionNamesMatch(functionNameA, functionNameB));
+            }
+            finally
+            {
+                Thread.CurrentThread.CurrentCulture = environmentCulture;
+            }
+        }
+
         [Theory]
         [InlineData(1, null, null, null, "00:00:00")]
         [InlineData(2, null, null, null, "00:00:02")]