Adding exception handling in container metrics publisher (#5460)

Author: divyagandhisethi

src/WebJobs.Script.WebHost/Metrics/LinuxContainerMetricsPublisher.cs

@@ -229,10 +229,17 @@ private async Task PublishActivity<T>(ConcurrentQueue<T> currentActivities, Bloc
 
         internal async Task SendRequest<T>(ConcurrentQueue<T> activitiesToPublish, string publishPath)
         {
-            var request = BuildRequest(HttpMethod.Post, publishPath, activitiesToPublish.ToArray());
-            _logger.LogDebug($"Publishing {activitiesToPublish.Count()} activities to {publishPath}.");
-            HttpResponseMessage response = await _httpClient.SendAsync(request);
-            response.EnsureSuccessStatusCode();
+            try
+            {
+                var request = BuildRequest(HttpMethod.Post, publishPath, activitiesToPublish.ToArray());
+
+                HttpResponseMessage response = await _httpClient.SendAsync(request);
+                response.EnsureSuccessStatusCode();
+            }
+            catch (Exception ex)
+            {
+                _logger.LogError(ex, $"Failed to publish status to {publishPath}");
+            }
         }
 
         public void Initialize()

test/WebJobs.Script.Tests/Metrics/LinuxContainerMetricsPublisherTests.cs

@@ -147,7 +147,7 @@ public void PublishFunctionActivity_SendsRequestHeaders()
 
             _metricsPublisher.OnFunctionMetricsPublishTimer(null);
             _metricsPublisher.OnFunctionMetricsPublishTimer(null);
-            Assert.Matches("Publishing", _testLoggerProvider.GetAllLogMessages().Single().FormattedMessage);
+            Assert.Empty(_testLoggerProvider.GetAllLogMessages());
         }
 
         [Fact]
@@ -160,14 +160,17 @@ public void PublishMemoryActivity_SendsRequestHeaders()
 
             _metricsPublisher.OnFunctionMetricsPublishTimer(null);
             _metricsPublisher.OnFunctionMetricsPublishTimer(null);
-            Assert.Matches("Publishing", _testLoggerProvider.GetAllLogMessages().Single().FormattedMessage);
+            Assert.Empty(_testLoggerProvider.GetAllLogMessages());
         }
 
         [Fact]
         public void SendRequest_FailsWithNullQueue()
         {
             ConcurrentQueue<string> testQueue = null;
-            Assert.Throws<NullReferenceException>(() => _metricsPublisher.SendRequest(testQueue, "testPath").GetAwaiter().GetResult());
+            _metricsPublisher.SendRequest(testQueue, "testPath").GetAwaiter().GetResult();
+            Assert.Matches("Failed to publish status to testPath", _testLoggerProvider.GetAllLogMessages().Single().FormattedMessage);
+            Assert.Matches("NullReferenceException", _testLoggerProvider.GetAllLogMessages().Single().Exception.ToString());
+            Assert.Equal(LogLevel.Error, _testLoggerProvider.GetAllLogMessages().Single().Level);
         }
 
         [Fact]