Removing process limit (CPU) checks from http throttle (#6986)

Author: mathewc

src/WebJobs.Script.WebHost/Middleware/HttpThrottleMiddleware.cs

@@ -47,7 +47,7 @@ public async Task Invoke(HttpContext httpContext, IOptions<HttpOptions> httpOpti
             {
                 // only check host status periodically
                 Collection<string> exceededCounters = new Collection<string>();
-                _rejectRequests = await performanceManager.IsUnderHighLoadAsync(exceededCounters);
+                _rejectRequests = performanceManager.PerformanceCountersExceeded(exceededCounters);
                 _lastPerformanceCheck = DateTime.UtcNow;
                 if (_rejectRequests)
                 {

test/WebJobs.Script.Tests/Middleware/HttpThrottleMiddlewareTests.cs

@@ -235,7 +235,7 @@ public async Task Invoke_HostIsOverloaded_RequestsAreRejected()
             _requestQueue = new HttpRequestQueue(new OptionsWrapper<HttpOptions>(_httpOptions));
 
             bool isOverloaded = false;
-            _performanceManager.Setup(p => p.IsUnderHighLoadAsync(It.IsAny<Collection<string>>(), null)).Returns(() => Task.FromResult(isOverloaded));
+            _performanceManager.Setup(p => p.PerformanceCountersExceeded(It.IsAny<Collection<string>>(), It.IsAny<ILogger>())).Returns(() => isOverloaded);
 
             RequestDelegate next = async (ctxt) =>
             {
@@ -269,7 +269,7 @@ public async Task Invoke_UnderLoad_RequestsAreRejected()
 
             bool highLoad = false;
             int highLoadQueryCount = 0;
-            _performanceManager.Setup(p => p.IsUnderHighLoadAsync(It.IsAny<Collection<string>>(), It.IsAny<ILogger>()))
+            _performanceManager.Setup(p => p.PerformanceCountersExceeded(It.IsAny<Collection<string>>(), It.IsAny<ILogger>()))
                 .Callback<Collection<string>, ILogger>((exceededCounters, tw) =>
                 {
                     if (highLoad)
@@ -280,7 +280,7 @@ public async Task Invoke_UnderLoad_RequestsAreRejected()
                 }).Returns(() =>
                 {
                     highLoadQueryCount++;
-                    return Task.FromResult(highLoad);
+                    return highLoad;
                 });
 
             // issue some requests while not under high load