Fix proxy behavior. (#6204)

Fix proxy behavior.

Author: yojagad

sample/HttpWorker/proxies.json

@@ -0,0 +1,17 @@
+{
+  "proxies": {
+    "proxyroute": {
+      "matchCondition": {
+        "methods": [
+          "GET"
+        ],
+        "route": "/something"
+      },
+      "responseOverrides": {
+        "response.statusCode": "200",
+        "response.headers.Content-Type": "text/plain",
+        "response.body": "something"
+      }
+    }
+  }
+}

sample/Node/proxies.json

@@ -0,0 +1,17 @@
+{
+  "proxies": {
+    "proxyroute": {
+      "matchCondition": {
+        "methods": [
+          "GET"
+        ],
+        "route": "/something"
+      },
+      "responseOverrides": {
+        "response.statusCode": "200",
+        "response.headers.Content-Type": "text/plain",
+        "response.body": "something"
+      }
+    }
+  }
+}

src/WebJobs.Script/Description/Workers/WorkerFunctionDescriptorProvider.cs

@@ -38,6 +38,13 @@ public WorkerFunctionDescriptorProvider(ScriptHost host, ScriptJobHostOptions co
             {
                 throw new ArgumentNullException(nameof(functionMetadata));
             }
+
+            // If a function exists exists with a proxy, there is a chance this could get evaluated first before ProxyFunctionDescriptorProvider.
+            if (functionMetadata.IsProxy())
+            {
+                return (false, null);
+            }
+
             return await base.TryCreate(functionMetadata);
         }
 

test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/SamplesEndToEndTests_HttpWorker.cs

@@ -34,6 +34,12 @@ public async Task HttpTrigger_HttpWorker_Get_Succeeds()
             await InvokeHttpTrigger("HttpTrigger");
         }
 
+        [Fact]
+        public async Task ProxyGetSucceeds()
+        {
+            await InvokeProxy();
+        }
+
         private async Task InvokeHttpTrigger(string functionName)
         {
             string functionKey = await _fixture.Host.GetFunctionSecretAsync($"{functionName}");
@@ -49,6 +55,18 @@ private async Task InvokeHttpTrigger(string functionName)
             Assert.True(res["functionName"].ToString().StartsWith(functionName));
         }
 
+        private async Task InvokeProxy()
+        {
+            string uri = "something";
+            HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, uri);
+            request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("text/plain"));
+
+            var response = await _fixture.Host.HttpClient.SendAsync(request);
+            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
+            string responseContent = await response.Content.ReadAsStringAsync();
+            Assert.Equal(responseContent, uri);
+        }
+
         public class TestFixture : EndToEndTestFixture
         {
             static TestFixture()

test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/SamplesEndToEndTests_Node.cs

@@ -255,6 +255,19 @@ public async Task HttpTrigger_Get_Succeeds()
             await SamplesTestHelpers.InvokeAndValidateHttpTrigger(_fixture, "HttpTrigger");
         }
 
+        [Fact]
+        public async Task InvokeProxy_GetsResponse()
+        {
+            string uri = "something";
+            HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, uri);
+            request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("text/plain"));
+
+            var response = await _fixture.Host.HttpClient.SendAsync(request);
+            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
+            string responseContent = await response.Content.ReadAsStringAsync();
+            Assert.Equal(responseContent, uri);
+        }
+
         [Fact]
         public async Task HttpTrigger_DuplicateQueryParams_Succeeds()
         {
@@ -480,7 +493,8 @@ public override void ConfigureScriptHost(IWebJobsBuilder webJobsBuilder)
                         "HttpTrigger-CustomRoute-Get",
                         "HttpTrigger-Disabled",
                         "HttpTrigger-Identities",
-                        "ManualTrigger"
+                        "ManualTrigger",
+                        "proxyroute"
                     };
                 });
             }