improving GetHostSecrets test

brettsam · brettsam · commit a58302a0de6b · 2018-03-07T11:00:26.000-08:00
diff --git a/test/WebJobs.Script.Tests/Security/SecretManagerTests.cs b/test/WebJobs.Script.Tests/Security/SecretManagerTests.cs
@@ -615,14 +615,17 @@ public async Task GetHostSecrets_WhenTooManyBackups_ThrowsException()
                     InvalidOperationException ioe = null;
                     try
                     {
-                        for (int i = 0; i < ScriptConstants.MaximumSecretBackupCount + 10; i++)
+                        for (int i = 0; i < ScriptConstants.MaximumSecretBackupCount + 20; i++)
                         {
                             File.WriteAllText(Path.Combine(directory.Path, functionName + ".json"), functionSecretsJson);
-                            functionSecrets = await secretManager.GetFunctionSecretsAsync(functionName);
-                            if (i > ScriptConstants.MaximumSecretBackupCount)
+
+                            // If we haven't hit the exception yet, pause to ensure the file contents are being flushed.
+                            if (i >= ScriptConstants.MaximumSecretBackupCount)
                             {
                                 await Task.Delay(500);
                             }
+
+                            functionSecrets = await secretManager.GetFunctionSecretsAsync(functionName);
                         }
                     }
                     catch (InvalidOperationException ex)

Original file line number	Diff line number	Diff line change
`@@ -615,14 +615,17 @@ public async Task GetHostSecrets_WhenTooManyBackups_ThrowsException()`
`615`	`615`	`InvalidOperationException ioe = null;`
`616`	`616`	`try`
`617`	`617`	`{`
`618`		`- for (int i = 0; i < ScriptConstants.MaximumSecretBackupCount + 10; i++)`
	`618`	`+ for (int i = 0; i < ScriptConstants.MaximumSecretBackupCount + 20; i++)`
`619`	`619`	`{`
`620`	`620`	`File.WriteAllText(Path.Combine(directory.Path, functionName + ".json"), functionSecretsJson);`
`621`		`- functionSecrets = await secretManager.GetFunctionSecretsAsync(functionName);`
`622`		`- if (i > ScriptConstants.MaximumSecretBackupCount)`
	`621`	`+`
	`622`	`+ // If we haven't hit the exception yet, pause to ensure the file contents are being flushed.`
	`623`	`+ if (i >= ScriptConstants.MaximumSecretBackupCount)`
`623`	`624`	`{`
`624`	`625`	`await Task.Delay(500);`
`625`	`626`	`}`
	`627`	`+`
	`628`	`+ functionSecrets = await secretManager.GetFunctionSecretsAsync(functionName);`
`626`	`629`	`}`
`627`	`630`	`}`
`628`	`631`	`catch (InvalidOperationException ex)`