adding regression tests for missing FUNCTION_WORKER_RUNTIME (#9284)

brettsam · web-flow · commit a9e69d28e221 · 2023-05-22T07:18:43.000-07:00
diff --git a/src/WebJobs.Script/Config/HostJsonFileConfigurationSource.cs b/src/WebJobs.Script/Config/HostJsonFileConfigurationSource.cs
@@ -198,7 +198,7 @@ internal JObject LoadHostConfig(string configFilePath)
                     JObject hostConfigObject;
                     try
                     {
-                        string json = File.ReadAllText(configFilePath);
+                        string json = FileUtility.Instance.File.ReadAllText(configFilePath);
                         hostConfigObject = JObject.Parse(json);
                     }
                     catch (JsonException ex)
diff --git a/test/CSharpPrecompiledTestProjects/WebJobsStartupTests/Function1.cs b/test/CSharpPrecompiledTestProjects/WebJobsStartupTests/Function1.cs
@@ -89,6 +89,17 @@ public void TimerRun([TimerTrigger("%Cron%", RunOnStartup = false)] TimerInfo ti
         {
         }
 
+        [FunctionName("Echo")]
+        public IActionResult Echo([HttpTrigger(AuthorizationLevel.Anonymous, "get", Route = null)] HttpRequest req)
+        {
+            if (req.Query.TryGetValue("echo", out var value))
+            {
+                return new OkObjectResult(value.Single());
+            }
+
+            return new BadRequestResult();
+        }
+
         private static bool ValidateConfig(IConfiguration _config)
         {
             if (_config is ConfigurationRoot root)
diff --git a/test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/CSharpPrecompiledEndToEndTests.cs b/test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/CSharpPrecompiledEndToEndTests.cs
@@ -0,0 +1,44 @@
+﻿using System;
+using System.Net;
+using System.Threading.Tasks;
+using Microsoft.Azure.WebJobs.Script.Description;
+using Microsoft.Extensions.DependencyInjection;
+using Xunit;
+
+namespace Microsoft.Azure.WebJobs.Script.Tests.Integration.WebHostEndToEnd
+{
+    public class CSharpPrecompiledEndToEndTests
+    {
+        [Theory]
+        [InlineData(null)]
+        [InlineData("dotnet")]
+        public async Task InProc_ChoosesCorrectLanguage(string functionWorkerRuntime)
+        {
+            var fixture = new CSharpPrecompiledEndToEndTestFixture("WebJobsStartupTests", functionWorkerRuntime: functionWorkerRuntime);
+            try
+            {
+                await fixture.InitializeAsync();
+                var client = fixture.Host.HttpClient;
+
+                var echo = Guid.NewGuid().ToString();
+                var response = await client.GetAsync($"api/echo?echo={echo}");
+
+                Assert.Equal(HttpStatusCode.OK, response.StatusCode);
+                Assert.Equal(echo, await response.Content.ReadAsStringAsync());
+
+                // Previous bug incorrectly chose dotnet-isolated as the Language for C# precompiled functions
+                // if FUNCTIONS_WORKER_RUNTIME was missing
+                var metadataManager = fixture.Host.WebHostServices.GetService<IFunctionMetadataManager>();
+                var metadata = metadataManager.GetFunctionMetadata();
+                foreach (var functionMetadata in metadata)
+                {
+                    Assert.Equal(DotNetScriptTypes.DotNetAssembly, functionMetadata.Language);
+                }
+            }
+            finally
+            {
+                await fixture.DisposeAsync();
+            }
+        }
+    }
+}
diff --git a/test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/CSharpPrecompiledTestFixture.cs b/test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/CSharpPrecompiledTestFixture.cs
@@ -9,8 +9,8 @@ public class CSharpPrecompiledEndToEndTestFixture : EndToEndTestFixture
         private const string TestPathTemplate = "..\\..\\..\\..\\CSharpPrecompiledTestProjects\\{0}\\bin\\Debug\\netcoreapp3.1";
         private readonly IDisposable _dispose;
 
-        public CSharpPrecompiledEndToEndTestFixture(string testProjectName, IDictionary<string, string> envVars = null)
-            : base(string.Format(TestPathTemplate, testProjectName), testProjectName, "dotnet")
+        public CSharpPrecompiledEndToEndTestFixture(string testProjectName, IDictionary<string, string> envVars = null, string functionWorkerRuntime = "dotnet")
+            : base(string.Format(TestPathTemplate, testProjectName), testProjectName, functionWorkerRuntime)
         {
             if (envVars != null)
             {
diff --git a/test/WebJobs.Script.Tests/ScriptHostTests.cs b/test/WebJobs.Script.Tests/ScriptHostTests.cs
@@ -5,6 +5,7 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.IO;
+using System.IO.Abstractions;
 using System.Linq;
 using System.Reflection;
 using System.Threading;
@@ -17,7 +18,6 @@
 using Microsoft.Azure.WebJobs.Script.Description;
 using Microsoft.Azure.WebJobs.Script.Diagnostics;
 using Microsoft.Azure.WebJobs.Script.Eventing;
-using Microsoft.Azure.WebJobs.Script.WebHost;
 using Microsoft.Azure.WebJobs.Script.Workers.Rpc;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
@@ -1512,6 +1512,97 @@ public async Task Initialize_LogsWarningForExplicitlySetHostId()
             Assert.Single(logger.GetLogMessages(), x => x.FormattedMessage.Contains("Host id explicitly set in configuration."));
         }
 
+        [Theory]
+        [InlineData("main.py", "python", "python")]
+        [InlineData("app.dll", "dotnet", DotNetScriptTypes.DotNetAssembly)] // if FUNCTIONS_WORKER_RUNTIME is missing, assume dotnet
+        public async Task Initialize_MissingWorkerRuntime_SetsCorrectRuntimeFromFunctionMetadata(string scriptFile, string expectedMetricLanguage, string expectedMetadataLanguage)
+        {
+            IFileSystem CreateFileSystem(string rootPath)
+            {
+                var fullFileSystem = new FileSystem();
+                var fileSystem = new Mock<IFileSystem>();
+                var fileBase = new Mock<FileBase>();
+                var dirBase = new Mock<DirectoryBase>();
+
+                fileSystem.SetupGet(f => f.Path).Returns(fullFileSystem.Path);
+                fileSystem.SetupGet(f => f.File).Returns(fileBase.Object);
+
+                var hostjson = """
+                    {
+                        "version": "2.0"
+                    }
+                    """;
+                fileBase.Setup(f => f.ReadAllText(Path.Combine(rootPath, "host.json"))).Returns(hostjson);
+
+                fileSystem.SetupGet(f => f.Directory).Returns(dirBase.Object);
+
+                dirBase.Setup(d => d.Exists(rootPath)).Returns(true);
+                dirBase.Setup(d => d.EnumerateDirectories(rootPath))
+                    .Returns(new[]
+                    {
+                        Path.Combine(rootPath, "function1"),
+                    });
+
+                var function1 = $$"""
+                    {
+                        "scriptFile": "{{scriptFile}}",
+                        "bindings": [
+                            {
+                                "type": "httpTrigger",
+                                "direction": "in",
+                                "name": "test"
+                            }
+                        ]
+                    }
+                    """;
+                fileBase.Setup(f => f.ReadAllText(Path.Combine(rootPath, @"function1", "function.json"))).Returns(function1);
+
+                fileBase.Setup(f => f.Exists(Path.Combine(rootPath, @"function1", "function.json"))).Returns(true);
+                fileBase.Setup(f => f.Exists(Path.Combine(rootPath, @"function1", scriptFile))).Returns(true);
+
+                return fileSystem.Object;
+            }
+
+            try
+            {
+                string rootPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+                var metricsLogger = new TestMetricsLogger();
+                var environment = new TestEnvironment();
+
+                FileUtility.Instance = CreateFileSystem(rootPath);
+
+                IHost host = new HostBuilder()
+                    .ConfigureServices(s =>
+                    {
+                        s.AddSingleton<IEnvironment>(environment);
+                    })
+                    .ConfigureDefaultTestWebScriptHost(null, o => o.ScriptPath = rootPath, false, s =>
+                    {
+                        s.AddSingleton<IMetricsLogger>(metricsLogger);
+                    })
+                    .Build();
+
+                var scriptHost = host.GetScriptHost();
+                await scriptHost.InitializeAsync();
+
+                Assert.Contains($"host.startup.runtime.language.{expectedMetricLanguage}", metricsLogger.LoggedEvents);
+
+                // Previous bug incorrectly chose dotnet-isolated as the Language for C# precompiled functions
+                // if FUNCTIONS_WORKER_RUNTIME was missing
+                var metadataManager = host.Services.GetService<IFunctionMetadataManager>();
+                var metadata = metadataManager.GetFunctionMetadata();
+                foreach (var functionMetadata in metadata)
+                {
+                    Assert.Equal(expectedMetadataLanguage, functionMetadata.Language);
+                }
+            }
+            finally
+            {
+                FileUtility.Instance = null;
+                EnvironmentExtensions.BaseDirectory = null;
+            }
+        }
+
         public class AssemblyMock : Assembly
         {
             public override object[] GetCustomAttributes(Type attributeType, bool inherit)
diff --git a/test/WebJobs.Script.Tests/WebJobs.Script.Tests.csproj b/test/WebJobs.Script.Tests/WebJobs.Script.Tests.csproj
@@ -6,6 +6,7 @@
     <IsPackable>false</IsPackable>
     <AssemblyName>Microsoft.Azure.WebJobs.Script.Tests</AssemblyName>
     <RootNamespace>Microsoft.Azure.WebJobs.Script.Tests</RootNamespace>
+    <LangVersion>preview</LangVersion>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
     <DefineConstants>TRACE;DEBUG;NETCOREAPP2_0;SCRIPT_TEST</DefineConstants>

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ internal JObject LoadHostConfig(string configFilePath)`
`198`	`198`	`JObject hostConfigObject;`
`199`	`199`	`try`
`200`	`200`	`{`
`201`		`- string json = File.ReadAllText(configFilePath);`
	`201`	`+ string json = FileUtility.Instance.File.ReadAllText(configFilePath);`
`202`	`202`	`hostConfigObject = JObject.Parse(json);`
`203`	`203`	`}`
`204`	`204`	`catch (JsonException ex)`
Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,17 @@ public void TimerRun([TimerTrigger("%Cron%", RunOnStartup = false)] TimerInfo ti`
`89`	`89`	`{`
`90`	`90`	`}`
`91`	`91`
	`92`	`+ [FunctionName("Echo")]`
	`93`	`+ public IActionResult Echo([HttpTrigger(AuthorizationLevel.Anonymous, "get", Route = null)] HttpRequest req)`
	`94`	`+ {`
	`95`	`+ if (req.Query.TryGetValue("echo", out var value))`
	`96`	`+ {`
	`97`	`+ return new OkObjectResult(value.Single());`
	`98`	`+ }`
	`99`	`+`
	`100`	`+ return new BadRequestResult();`
	`101`	`+ }`
	`102`	`+`
`92`	`103`	`private static bool ValidateConfig(IConfiguration _config)`
`93`	`104`	`{`
`94`	`105`	`if (_config is ConfigurationRoot root)`
Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,8 @@ public class CSharpPrecompiledEndToEndTestFixture : EndToEndTestFixture`
`9`	`9`	`private const string TestPathTemplate = "..\\..\\..\\..\\CSharpPrecompiledTestProjects\\{0}\\bin\\Debug\\netcoreapp3.1";`
`10`	`10`	`private readonly IDisposable _dispose;`
`11`	`11`
`12`		`- public CSharpPrecompiledEndToEndTestFixture(string testProjectName, IDictionary<string, string> envVars = null)`
`13`		`- : base(string.Format(TestPathTemplate, testProjectName), testProjectName, "dotnet")`
	`12`	`+ public CSharpPrecompiledEndToEndTestFixture(string testProjectName, IDictionary<string, string> envVars = null, string functionWorkerRuntime = "dotnet")`
	`13`	`+ : base(string.Format(TestPathTemplate, testProjectName), testProjectName, functionWorkerRuntime)`
`14`	`14`	`{`
`15`	`15`	`if (envVars != null)`
`16`	`16`	`{`