[HttpWorker][LinuxConsumption]Give executable permissions to user files (#5834)

Author: pragnagopa

src/WebJobs.Script/WebJobs.Script.csproj

@@ -54,6 +54,7 @@
     <PackageReference Include="Microsoft.Extensions.Logging" Version="2.2.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="2.2.0" />
     <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="2.2.0" />
+    <PackageReference Include="Mono.Posix.NETStandard" Version="1.0.0" />
     <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
     <PackageReference Include="NuGet.Frameworks" Version="4.7.0" />
     <PackageReference Include="NuGet.LibraryModel" Version="4.7.0" />

src/WebJobs.Script/Workers/Http/HttpWorkerProcess.cs

@@ -5,6 +5,7 @@
 using System.Diagnostics;
 using Microsoft.Azure.WebJobs.Script.Eventing;
 using Microsoft.Extensions.Logging;
+using Mono.Unix;
 
 namespace Microsoft.Azure.WebJobs.Script.Workers.Http
 {
@@ -17,6 +18,7 @@ internal class HttpWorkerProcess : WorkerProcess
         private readonly string _scriptRootPath;
         private readonly string _workerId;
         private readonly WorkerProcessArguments _workerProcessArguments;
+        private readonly IEnvironment _environment;
 
         internal HttpWorkerProcess(string workerId,
                                        string rootScriptPath,
@@ -25,7 +27,8 @@ internal HttpWorkerProcess(string workerId,
                                        IWorkerProcessFactory processFactory,
                                        IProcessRegistry processRegistry,
                                        ILogger workerProcessLogger,
-                                       IWorkerConsoleLogSource consoleLogSource)
+                                       IWorkerConsoleLogSource consoleLogSource,
+                                       IEnvironment environment)
             : base(eventManager, processRegistry, workerProcessLogger, consoleLogSource)
         {
             _processFactory = processFactory;
@@ -35,6 +38,7 @@ internal HttpWorkerProcess(string workerId,
             _scriptRootPath = rootScriptPath;
             _httpWorkerOptions = httpWorkerOptions;
             _workerProcessArguments = _httpWorkerOptions.Arguments;
+            _environment = environment;
         }
 
         internal override Process CreateWorkerProcess()
@@ -49,7 +53,31 @@ internal override Process CreateWorkerProcess()
             };
             workerContext.EnvironmentVariables.Add(HttpWorkerConstants.PortEnvVarName, _httpWorkerOptions.Port.ToString());
             workerContext.EnvironmentVariables.Add(HttpWorkerConstants.WorkerIdEnvVarName, _workerId);
-            return _processFactory.CreateWorkerProcess(workerContext);
+            Process workerProcess = _processFactory.CreateWorkerProcess(workerContext);
+            if (_environment.IsLinuxConsumption())
+            {
+                AssignUserExecutePermissionsIfNotExists(workerProcess.StartInfo.FileName);
+            }
+            return workerProcess;
+        }
+
+        private void AssignUserExecutePermissionsIfNotExists(string filePath)
+        {
+            try
+            {
+                UnixFileInfo fileInfo = new UnixFileInfo(filePath);
+                if (!fileInfo.FileAccessPermissions.HasFlag(FileAccessPermissions.UserExecute))
+                {
+                    _workerProcessLogger.LogDebug("Assigning execute permissions to file: {filePath}", filePath);
+                    fileInfo.FileAccessPermissions |= FileAccessPermissions.UserExecute |
+                                                      FileAccessPermissions.GroupExecute |
+                                                      FileAccessPermissions.OtherExecute;
+                }
+            }
+            catch (Exception ex)
+            {
+                _workerProcessLogger.LogWarning(ex, "Error while assigning execute permission.");
+            }
         }
 
         internal override void HandleWorkerProcessExitError(WorkerProcessExitException httpWorkerProcessExitException)

src/WebJobs.Script/Workers/Http/HttpWorkerProcessFactory.cs

@@ -15,24 +15,27 @@ internal class HttpWorkerProcessFactory : IHttpWorkerProcessFactory
         private readonly ILoggerFactory _loggerFactory = null;
         private readonly IScriptEventManager _eventManager = null;
         private readonly IWorkerConsoleLogSource _consoleLogSource;
+        private readonly IEnvironment _environment;
 
         public HttpWorkerProcessFactory(IScriptEventManager eventManager,
                                        ILoggerFactory loggerFactory,
                                        IWorkerProcessFactory defaultWorkerProcessFactory,
                                        IProcessRegistry processRegistry,
-                                       IWorkerConsoleLogSource consoleLogSource)
+                                       IWorkerConsoleLogSource consoleLogSource,
+                                       IEnvironment environment)
         {
             _loggerFactory = loggerFactory ?? throw new ArgumentNullException(nameof(loggerFactory));
             _eventManager = eventManager ?? throw new ArgumentNullException(nameof(eventManager));
             _consoleLogSource = consoleLogSource ?? throw new ArgumentNullException(nameof(consoleLogSource));
             _workerProcessFactory = defaultWorkerProcessFactory ?? throw new ArgumentNullException(nameof(defaultWorkerProcessFactory));
             _processRegistry = processRegistry ?? throw new ArgumentNullException(nameof(processRegistry));
+            _environment = environment;
         }
 
         public IWorkerProcess Create(string workerId, string scriptRootPath, HttpWorkerOptions httpWorkerOptions)
         {
             ILogger workerProcessLogger = _loggerFactory.CreateLogger($"Worker.HttpWorkerProcess.{workerId}");
-            return new HttpWorkerProcess(workerId, scriptRootPath, httpWorkerOptions, _eventManager, _workerProcessFactory, _processRegistry, workerProcessLogger, _consoleLogSource);
+            return new HttpWorkerProcess(workerId, scriptRootPath, httpWorkerOptions, _eventManager, _workerProcessFactory, _processRegistry, workerProcessLogger, _consoleLogSource, _environment);
         }
     }
 }

test/WebJobs.Script.Tests/Workers/Http/HttpWorkerProcessTests.cs

@@ -23,7 +23,7 @@ public class HttpWorkerProcessTests
         private readonly IWorkerProcessFactory _defaultWorkerProcessFactory = new DefaultWorkerProcessFactory();
         private readonly IProcessRegistry _processRegistry = new EmptyProcessRegistry();
         private readonly Mock<IWorkerConsoleLogSource> _languageWorkerConsoleLogSource = new Mock<IWorkerConsoleLogSource>();
-        private readonly ILogger _testLogger = new TestLogger("test");
+        private readonly TestLogger _testLogger = new TestLogger("test");
         private readonly HttpWorkerOptions _httpWorkerOptions;
 
         public HttpWorkerProcessTests()
@@ -48,13 +48,25 @@ public void CreateWorkerProcess_VerifyEnvVars(string processEnvValue)
                 {
                     Assert.Equal(Environment.GetEnvironmentVariable(HttpWorkerConstants.PortEnvVarName), processEnvValue);
                 }
-                HttpWorkerProcess httpWorkerProcess = new HttpWorkerProcess(_testWorkerId, _rootScriptPath, _httpWorkerOptions, _mockEventManager.Object, _defaultWorkerProcessFactory, _processRegistry, _testLogger, _languageWorkerConsoleLogSource.Object);
+                HttpWorkerProcess httpWorkerProcess = new HttpWorkerProcess(_testWorkerId, _rootScriptPath, _httpWorkerOptions, _mockEventManager.Object, _defaultWorkerProcessFactory, _processRegistry, _testLogger, _languageWorkerConsoleLogSource.Object, new TestEnvironment());
                 Process childProcess = httpWorkerProcess.CreateWorkerProcess();
                 Assert.NotNull(childProcess.StartInfo.EnvironmentVariables);
                 Assert.Equal(childProcess.StartInfo.EnvironmentVariables[HttpWorkerConstants.PortEnvVarName], _workerPort.ToString());
                 Assert.Equal(childProcess.StartInfo.EnvironmentVariables[HttpWorkerConstants.WorkerIdEnvVarName], _testWorkerId);
                 childProcess.Dispose();
             }
         }
+
+        [Fact]
+        public void CreateWorkerProcess_LinuxConsumption_AssingnsExecutePermissions_invoked()
+        {
+            TestEnvironment testEnvironment = new TestEnvironment();
+            testEnvironment.SetEnvironmentVariable(EnvironmentSettingNames.ContainerName, "TestContainer");
+            var mockHttpWorkerProcess = new HttpWorkerProcess(_testWorkerId, _rootScriptPath, _httpWorkerOptions, _mockEventManager.Object, _defaultWorkerProcessFactory, _processRegistry, _testLogger, _languageWorkerConsoleLogSource.Object, testEnvironment);
+            mockHttpWorkerProcess.CreateWorkerProcess();
+            // Verify method invocation
+            var testLogs = _testLogger.GetLogMessages();
+            Assert.Contains("Error while assigning execute permission", testLogs[0].FormattedMessage);
+        }
     }
 }