[HttpWorker]Fix identities serialization (#5459)

Author: pragnagopa

src/WebJobs.Script/Extensions/HttpRequestExtensions.cs

@@ -5,6 +5,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Net.Http.Headers;
+using System.Security.Claims;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Http.Extensions;
@@ -110,7 +111,7 @@ public static bool IsMediaTypeOctetOrMultipart(this HttpRequest request)
         public static async Task<JObject> GetRequestAsJObject(this HttpRequest request)
         {
             var jObjectHttp = new JObject();
-            jObjectHttp["Url"] = $"{(request.IsHttps ? "https" : "http")}://{request.Host.ToString()}{request.Path.ToString()}{request.QueryString.ToString()}"; // [http|https]://{url}{path}{query}
+            jObjectHttp["Url"] = $"{(request.IsHttps ? "https" : "http")}://{request.Host.ToString()}{request.Path.ToString()}{request.QueryString.ToString()}";
             jObjectHttp["Method"] = request.Method.ToString();
             if (request.Query != null)
             {
@@ -131,7 +132,7 @@ public static async Task<JObject> GetRequestAsJObject(this HttpRequest request)
 
             if (request.HttpContext?.User?.Identities != null)
             {
-                jObjectHttp["Identities"] = JsonConvert.SerializeObject(request.HttpContext.User.Identities);
+                jObjectHttp["Identities"] = GetUserIdentitiesAsString(request.HttpContext.User.Identities);
             }
 
             // parse request body as content-type
@@ -165,5 +166,14 @@ internal static IDictionary<string, string> GetQueryCollectionAsDictionary(this
             }
             return queryParamsDictionary;
         }
+
+        internal static string GetUserIdentitiesAsString(IEnumerable<ClaimsIdentity> claimsIdentities)
+        {
+            return JsonConvert.SerializeObject(claimsIdentities, new JsonSerializerSettings
+            {
+                // Claims property in Identities had circular reference to property 'Subject'
+                ReferenceLoopHandling = ReferenceLoopHandling.Ignore
+            });
+        }
     }
 }

test/WebJobs.Script.Tests/Extensions/HttpRequestExtensionsTest.cs

@@ -3,6 +3,8 @@
 
 using System;
 using System.Collections.Generic;
+using System.Security.Claims;
+using System.Security.Principal;
 using System.Text;
 using Microsoft.AspNetCore.Http;
 using Microsoft.Azure.WebJobs.Script.Config;
@@ -39,5 +41,27 @@ public void IsAppServiceInternalRequest_ReturnsExpectedResult()
                 Assert.True(request.IsAppServiceInternalRequest());
             }
         }
+
+        [Fact]
+        public void ConvertUserIdentitiesToString_RemovesCircularReference()
+        {
+            string expectedUserIdentities = "[{\"AuthenticationType\":\"TestAuthType\",\"IsAuthenticated\":true";
+            IIdentity identity = new TestIdentity();
+            Claim claim = new Claim("authlevel", "admin", "test", "LOCAL AUTHORITY", "LOCAL AUTHORITY");
+            List<Claim> claims = new List<Claim>() { claim };
+            ClaimsIdentity claimsIdentity = new ClaimsIdentity(identity, claims);
+            List<ClaimsIdentity> claimsIdentities = new List<ClaimsIdentity>() { claimsIdentity };
+            string userIdentitiesString = HttpRequestExtensions.GetUserIdentitiesAsString(claimsIdentities);
+            Assert.Contains(expectedUserIdentities, userIdentitiesString);
+        }
+    }
+
+    internal class TestIdentity : IIdentity
+    {
+        public string AuthenticationType => "TestAuthType";
+
+        public bool IsAuthenticated => true;
+
+        public string Name => "TestIdentityName";
     }
 }