Skip to content

Commit bba26a3

Browse files
pragnagopapragnagopa
authored
Skip flaky tests (#3865)
1 parent 664768f commit bba26a3

File tree

1 file changed

+53
-39
lines changed

1 file changed

+53
-39
lines changed

‎test/WebJobs.Script.Tests/Rpc/RpcInitializationServiceTests.cs‎

Lines changed: 53 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ public class RpcInitializationServiceTests
1818
private RpcInitializationService _rpcInitializationService;
1919
private IOptionsMonitor<ScriptApplicationHostOptions> _optionsMonitor;
2020
private Mock<ILanguageWorkerChannelManager> _mockLanguageWorkerChannelManager;
21-
private IRpcServer _testRpcServer;
2221
private LoggerFactory _loggerFactory;
2322
private string _rootPath;
2423

@@ -27,7 +26,7 @@ public RpcInitializationServiceTests()
2726
_rootPath = Path.GetTempPath();
2827
_mockLanguageWorkerChannelManager = new Mock<ILanguageWorkerChannelManager>();
2928
_loggerFactory = new LoggerFactory();
30-
_testRpcServer = new TestRpcServer();
29+
3130
var applicationHostOptions = new ScriptApplicationHostOptions
3231
{
3332
IsSelfHost = true,
@@ -38,101 +37,116 @@ public RpcInitializationServiceTests()
3837
.Returns(Task.CompletedTask);
3938
}
4039

41-
[Fact]
40+
[Fact(Skip = "https://github.com/Azure/azure-functions-host/issues/3868")]
4241
public async Task RpcInitializationService_Initializes_RpcServerAndChannels_PlaceHolderMode()
4342
{
44-
var testEnvironment = new TestEnvironment();
45-
testEnvironment.SetEnvironmentVariable(EnvironmentSettingNames.AzureWebsitePlaceholderMode, "1");
46-
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, testEnvironment, _testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
43+
IRpcServer testRpcServer = new TestRpcServer();
44+
var mockEnvironment = new Mock<IEnvironment>();
45+
mockEnvironment.Setup(p => p.GetEnvironmentVariable(EnvironmentSettingNames.AzureWebsitePlaceholderMode)).Returns("1");
46+
mockEnvironment.Setup(p => p.GetEnvironmentVariable(LanguageWorkerConstants.FunctionWorkerRuntimeSettingName)).Returns(string.Empty);
47+
48+
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
4749
await _rpcInitializationService.StartAsync(CancellationToken.None);
4850
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Once);
49-
Assert.Contains("testserver", _testRpcServer.Uri.ToString());
51+
Assert.Contains("testserver", testRpcServer.Uri.ToString());
5052
}
5153

52-
[Fact]
54+
[Fact(Skip = "https://github.com/Azure/azure-functions-host/issues/3868")]
5355
public async Task RpcInitializationService_LinuxConsumption_Initializes_RpcServer()
5456
{
55-
var testEnvironment = new TestEnvironment();
56-
testEnvironment.SetEnvironmentVariable(EnvironmentSettingNames.ContainerName, "testContainer");
57-
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, testEnvironment, _testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
57+
IRpcServer testRpcServer = new TestRpcServer();
58+
var mockEnvironment = new Mock<IEnvironment>();
59+
mockEnvironment.Setup(p => p.GetEnvironmentVariable(EnvironmentSettingNames.ContainerName)).Returns("testContainer");
60+
mockEnvironment.Setup(p => p.GetEnvironmentVariable(LanguageWorkerConstants.FunctionWorkerRuntimeSettingName)).Returns("java");
61+
62+
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
5863
await _rpcInitializationService.StartAsync(CancellationToken.None);
5964
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
60-
Assert.Contains("testserver", _testRpcServer.Uri.ToString());
65+
Assert.Contains("testserver", testRpcServer.Uri.ToString());
6166
}
6267

63-
[Fact]
68+
[Fact(Skip = "https://github.com/Azure/azure-functions-host/issues/3868")]
6469
public async Task RpcInitializationService_LinuxAppService_Initializes_RpcServer()
6570
{
66-
var testEnvironment = new TestEnvironment();
67-
testEnvironment.SetEnvironmentVariable(EnvironmentSettingNames.FunctionsLogsMountPath, "d:\\test\\mount");
68-
testEnvironment.SetEnvironmentVariable(EnvironmentSettingNames.AzureWebsiteInstanceId, "1234");
69-
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, testEnvironment, _testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
71+
IRpcServer testRpcServer = new TestRpcServer();
72+
var mockEnvironment = new Mock<IEnvironment>();
73+
mockEnvironment.Setup(p => p.GetEnvironmentVariable(EnvironmentSettingNames.FunctionsLogsMountPath)).Returns(@"d:\test");
74+
mockEnvironment.Setup(p => p.GetEnvironmentVariable(EnvironmentSettingNames.AzureWebsiteInstanceId)).Returns("1234");
75+
76+
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
7077
await _rpcInitializationService.StartAsync(CancellationToken.None);
7178
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
72-
Assert.Contains("testserver", _testRpcServer.Uri.ToString());
79+
Assert.Contains("testserver", testRpcServer.Uri.ToString());
7380
}
7481

75-
[Fact]
82+
[Fact(Skip = "https://github.com/Azure/azure-functions-host/issues/3868")]
7683
public async Task RpcInitializationService_AppOffline()
7784
{
78-
var testEnvironment = new TestEnvironment();
85+
IRpcServer testRpcServer = new TestRpcServer();
86+
var mockEnvironment = new Mock<IEnvironment>();
7987
var offlineFilePath = TestHelpers.CreateOfflineFile(_rootPath);
8088
try
8189
{
82-
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, testEnvironment, _testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
90+
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
8391
await _rpcInitializationService.StartAsync(CancellationToken.None);
8492
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
85-
Assert.DoesNotContain("testserver", _testRpcServer.Uri.ToString());
93+
Assert.DoesNotContain("testserver", testRpcServer.Uri.ToString());
8694
}
8795
finally
8896
{
8997
DeleteTestFile(offlineFilePath);
9098
}
9199
}
92100

93-
[Fact]
101+
[Fact(Skip = "https://github.com/Azure/azure-functions-host/issues/3868")]
94102
public async Task RpcInitializationService_Initializes_WorkerRuntime_Set()
95103
{
96-
var testEnvironment = new TestEnvironment();
97-
testEnvironment.SetEnvironmentVariable(LanguageWorkerConstants.FunctionWorkerRuntimeSettingName, LanguageWorkerConstants.NodeLanguageWorkerName);
98-
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, testEnvironment, _testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
104+
IRpcServer testRpcServer = new TestRpcServer();
105+
var mockEnvironment = new Mock<IEnvironment>();
106+
mockEnvironment.Setup(p => p.GetEnvironmentVariable(LanguageWorkerConstants.FunctionWorkerRuntimeSettingName)).Returns(LanguageWorkerConstants.NodeLanguageWorkerName);
107+
108+
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
99109
_rpcInitializationService.AddSupportedRuntime(LanguageWorkerConstants.NodeLanguageWorkerName);
100110
await _rpcInitializationService.StartAsync(CancellationToken.None);
101111
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.NodeLanguageWorkerName), Times.Once);
102-
Assert.Contains("testserver", _testRpcServer.Uri.ToString());
112+
Assert.Contains("testserver", testRpcServer.Uri.ToString());
103113
}
104114

105-
[Fact]
115+
[Fact(Skip = "https://github.com/Azure/azure-functions-host/issues/3868")]
106116
public async Task RpcInitializationService_Initializes_WorkerRuntime_Set_RuntimeNotSupported()
107117
{
108-
var testEnvironment = new TestEnvironment();
109-
testEnvironment.SetEnvironmentVariable(LanguageWorkerConstants.FunctionWorkerRuntimeSettingName, LanguageWorkerConstants.NodeLanguageWorkerName);
110-
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, testEnvironment, _testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
118+
IRpcServer testRpcServer = new TestRpcServer();
119+
var mockEnvironment = new Mock<IEnvironment>();
120+
mockEnvironment.Setup(p => p.GetEnvironmentVariable(LanguageWorkerConstants.FunctionWorkerRuntimeSettingName)).Returns(LanguageWorkerConstants.NodeLanguageWorkerName);
121+
122+
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
111123
await _rpcInitializationService.StartAsync(CancellationToken.None);
112124
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.NodeLanguageWorkerName), Times.Never);
113125
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
114-
Assert.Contains("testserver", _testRpcServer.Uri.ToString());
126+
Assert.Contains("testserver", testRpcServer.Uri.ToString());
115127
}
116128

117-
[Fact]
129+
[Fact(Skip = "https://github.com/Azure/azure-functions-host/issues/3868")]
118130
public async Task RpcInitializationService_Initializes_WorkerRuntime_NotSet_NoPlaceholder()
119131
{
120-
var testEnvironment = new TestEnvironment();
121-
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, testEnvironment, _testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
132+
IRpcServer testRpcServer = new TestRpcServer();
133+
var mockEnvironment = new Mock<IEnvironment>();
134+
135+
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _loggerFactory);
122136
_rpcInitializationService.AddSupportedRuntime(LanguageWorkerConstants.NodeLanguageWorkerName);
123137
await _rpcInitializationService.StartAsync(CancellationToken.None);
124138
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
125139
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.NodeLanguageWorkerName), Times.Never);
126-
Assert.Contains("testserver", _testRpcServer.Uri.ToString());
140+
Assert.Contains("testserver", testRpcServer.Uri.ToString());
127141
}
128142

129-
private static void DeleteTestFile(string testFile)
143+
private static void DeleteTestFile(string testDir)
130144
{
131-
if (File.Exists(testFile))
145+
if (Directory.Exists(testDir))
132146
{
133147
try
134148
{
135-
File.Delete(testFile);
149+
Directory.Delete(testDir);
136150
}
137151
catch
138152
{

0 commit comments

Comments
 (0)