RpcInitialization service should ignore workerRuntime case (#5012)

Author: pragnagopa

src/WebJobs.Script/Rpc/RpcInitializationService.cs

@@ -153,7 +153,7 @@ private Task InitializePlaceholderChannelsAsync(OSPlatform os)
 
         private Task InitializeWebHostRuntimeChannelsAsync()
         {
-            if (_webHostLevelWhitelistedRuntimes.Contains(_workerRuntime))
+            if (_webHostLevelWhitelistedRuntimes.Contains(_workerRuntime, StringComparer.OrdinalIgnoreCase))
             {
                 return _webHostlanguageWorkerChannelManager.InitializeChannelAsync(_workerRuntime);
             }
@@ -180,7 +180,7 @@ internal bool ShouldStartAsPlaceholderPool()
             // We are in placeholder mode but a worker runtime IS set
             return _environment.IsPlaceholderModeEnabled()
                 && !string.IsNullOrEmpty(_workerRuntime)
-                && _placeholderPoolWhitelistedRuntimes.Contains(_workerRuntime);
+                && _placeholderPoolWhitelistedRuntimes.Contains(_workerRuntime, StringComparer.OrdinalIgnoreCase);
         }
 
         // To help with unit tests

src/WebJobs.Script/Rpc/WebHostLanguageWorkerChannelManager.cs

@@ -26,7 +26,7 @@ public class WebHostLanguageWorkerChannelManager : IWebHostLanguageWorkerChannel
         private string _workerRuntime;
         private Action _shutdownStandbyWorkerChannels;
 
-        private ConcurrentDictionary<string, Dictionary<string, TaskCompletionSource<ILanguageWorkerChannel>>> _workerChannels = new ConcurrentDictionary<string, Dictionary<string, TaskCompletionSource<ILanguageWorkerChannel>>>();
+        private ConcurrentDictionary<string, Dictionary<string, TaskCompletionSource<ILanguageWorkerChannel>>> _workerChannels = new ConcurrentDictionary<string, Dictionary<string, TaskCompletionSource<ILanguageWorkerChannel>>>(StringComparer.OrdinalIgnoreCase);
 
         public WebHostLanguageWorkerChannelManager(IScriptEventManager eventManager, IEnvironment environment, ILoggerFactory loggerFactory, ILanguageWorkerChannelFactory languageWorkerChannelFactory, IOptionsMonitor<ScriptApplicationHostOptions> applicationHostOptions)
         {
@@ -129,7 +129,7 @@ private bool UsePlaceholderChannel(string workerRuntime)
             {
                 // Special case: node apps must be read-only to use the placeholder mode channel
                 // TODO: Remove special casing when resolving https://github.com/Azure/azure-functions-host/issues/4534
-                if (string.Equals(workerRuntime, LanguageWorkerConstants.NodeLanguageWorkerName))
+                if (string.Equals(workerRuntime, LanguageWorkerConstants.NodeLanguageWorkerName, StringComparison.OrdinalIgnoreCase))
                 {
                     return _environment.FileSystemIsReadOnly();
                 }

test/WebJobs.Script.Tests/Rpc/RpcInitializationServiceTests.cs

@@ -309,8 +309,10 @@ public void ShouldStartStandbyPlaceholderChannels_Returns_ExpectedValue(string p
         [InlineData("1", "node", "1234", true)]
         [InlineData("0", "node", "1234", false)]
         [InlineData("1", "node", "", true)]
+        [InlineData("1", "Node", "", true)]
         [InlineData("1", "java", "1234", true)]
         [InlineData("0", "java", "1234", false)]
+        [InlineData("0", "JAVA", "1234", false)]
         [InlineData("1", "java", "", true)]
         [InlineData("1", "", "1234", false)]
         [InlineData("1", "dotnet", "1234", false)]

test/WebJobs.Script.Tests/Rpc/WebHostLanguageWorkerChannelManagerTests.cs

@@ -148,10 +148,12 @@ public async Task ShutdownStandyChannels_WorkerRuntime_Node_Set()
             Assert.Null(initializedChannel);
         }
 
-        [Fact]
-        public async Task SpecializeAsync_Node_ReadOnly_KeepsProcessAlive()
+        [Theory]
+        [InlineData("nOde")]
+        [InlineData("Node")]
+        public async Task SpecializeAsync_Node_ReadOnly_KeepsProcessAlive(string runtime)
         {
-            _testEnvironment.SetEnvironmentVariable(LanguageWorkerConstants.FunctionWorkerRuntimeSettingName, LanguageWorkerConstants.NodeLanguageWorkerName);
+            _testEnvironment.SetEnvironmentVariable(LanguageWorkerConstants.FunctionWorkerRuntimeSettingName, runtime);
             _testEnvironment.SetEnvironmentVariable(EnvironmentSettingNames.AzureWebsiteZipDeployment, "1");
 
             _languageWorkerChannelManager = new WebHostLanguageWorkerChannelManager(_eventManager, _testEnvironment, _loggerFactory, _languageWorkerChannelFactory, _optionsMonitor);