Fixing an issue leading to a race when proxying HTTP requests to the worker. (#10121) (#10122)

Author: fabiocav

release_notes.md

@@ -3,4 +3,4 @@
 <!-- Please add your release notes in the following format:
 - My change description (#PR)
 -->
-- Ensuring non http invocation responses are not processed by IHttpProxyService (#10085)
+- Fixed an issue leading to a race when invocation responses returned prior to HTTP requests being sent in proxied scenarios.

src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs

@@ -877,6 +877,14 @@ internal async Task SendInvocationRequest(ScriptInvocationContext context)
                 _executingInvocations.TryAdd(invocationRequest.InvocationId, new(context, _messageDispatcherFactory.Create(invocationRequest.InvocationId)));
                 _metricsLogger.LogEvent(string.Format(MetricEventNames.WorkerInvoked, Id), functionName: Sanitizer.Sanitize(context.FunctionMetadata.Name));
 
+                // If the worker supports HTTP proxying, ensure this request is forwarded prior
+                // to sending the invocation request to the worker, as this will ensure the context
+                // is properly set up.
+                if (IsHttpProxyingWorker && context.FunctionMetadata.IsHttpTriggerFunction())
+                {
+                    _httpProxyService.StartForwarding(context, _httpProxyEndpoint);
+                }
+
                 await SendStreamingMessageAsync(new StreamingMessage
                 {
                     InvocationRequest = invocationRequest
@@ -887,11 +895,6 @@ await SendStreamingMessageAsync(new StreamingMessage
                     var cancellationCtr = context.CancellationToken.Register(() => SendInvocationCancel(invocationRequest.InvocationId));
                     context.Properties.Add(ScriptConstants.CancellationTokenRegistration, cancellationCtr);
                 }
-
-                if (IsHttpProxyingWorker && context.FunctionMetadata.IsHttpTriggerFunction())
-                {
-                    _ = _httpProxyService.ForwardAsync(context, _httpProxyEndpoint);
-                }
             }
             catch (Exception invokeEx)
             {

src/WebJobs.Script.Grpc/Server/DefaultHttpProxyService.cs

@@ -66,7 +66,7 @@ public async Task EnsureSuccessfulForwardingAsync(ScriptInvocationContext contex
             }
         }
 
-        public Task ForwardAsync(ScriptInvocationContext context, Uri httpUri)
+        public void StartForwarding(ScriptInvocationContext context, Uri httpUri)
         {
             ArgumentNullException.ThrowIfNull(context);
 
@@ -89,8 +89,6 @@ public Task ForwardAsync(ScriptInvocationContext context, Uri httpUri)
 
             var forwardingTask = _httpForwarder.SendAsync(httpContext, httpUri.ToString(), _messageInvoker, _forwarderRequestConfig).AsTask();
             context.Properties.Add(ScriptConstants.HttpProxyTask, forwardingTask);
-
-            return forwardingTask;
         }
     }
 }

src/WebJobs.Script.Grpc/Server/IHttpProxyService.cs

@@ -11,6 +11,11 @@ public interface IHttpProxyService
     {
         Task EnsureSuccessfulForwardingAsync(ScriptInvocationContext context);
 
-        Task ForwardAsync(ScriptInvocationContext context, Uri httpUri);
+        /// <summary>
+        /// Initiates a request forward and updates the current context to track forwarding operation.
+        /// </summary>
+        /// <param name="context">The <see cref="ScriptInvocationContext"/> for the HTTP invocation.</param>
+        /// <param name="httpUri">The target URI used for forwarding.</param>
+        void StartForwarding(ScriptInvocationContext context, Uri httpUri);
     }
 }