Code cleanup and updating stylecop settings

Author: fabiocav

src/WebJobs.Script.Grpc/Abstractions/ArgumentsDescription.cs

@@ -1,5 +1,5 @@
 // Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+// Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System.Collections.Generic;
 
@@ -8,22 +8,22 @@ namespace Microsoft.Azure.WebJobs.Script.Abstractions
     public class ArgumentsDescription
     {
         /// <summary>
-        /// The path to the executable (java, node, etc).
+        /// Gets or sets the path to the executable (java, node, etc).
         /// </summary>
         public string ExecutablePath { get; set; }
 
         /// <summary>
-        /// Arguments to be passed to the executable. Optional.
+        /// Gets or sets arguments to be passed to the executable. Optional.
         /// </summary>
         public List<string> ExecutableArguments { get; set; } = new List<string>();
 
         /// <summary>
-        /// The path to the worker file, i.e. nodejsWorker.js.
+        /// Gets or sets the path to the worker file, i.e. nodejsWorker.js.
         /// </summary>
         public string WorkerPath { get; set; }
 
         /// <summary>
-        /// Arguments to be passed to the worker. Optional.
+        /// Gets or sets arguments to be passed to the worker. Optional.
         /// </summary>
         public List<string> WorkerArguments { get; set; } = new List<string>();
     }

src/WebJobs.Script.Grpc/Abstractions/DefaultWorkerOptions.cs

@@ -1,17 +1,17 @@
 // Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+// Licensed under the MIT License. See License.txt in the project root for license information.
 
 namespace Microsoft.Azure.WebJobs.Script.Abstractions
 {
     public class DefaultWorkerOptions
     {
         /// <summary>
-        /// The path to the worker
+        /// Gets or sets the path to the worker
         /// </summary>
         public string Path { get; set; } = string.Empty;
 
         /// <summary>
-        /// The debugging port
+        /// Gets or sets the debugging port
         /// </summary>
         public string Debug { get; set; } = string.Empty;
 

src/WebJobs.Script.Grpc/Abstractions/IRpcServer.cs

@@ -1,5 +1,5 @@
 // Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+// Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;
 using System.Collections.Generic;
@@ -10,6 +10,11 @@ namespace Microsoft.Azure.WebJobs.Script.Abstractions
 {
     public interface IRpcServer
     {
+        /// <summary>
+        /// Gets the address that the rpc server is listening on
+        /// </summary>
+        Uri Uri { get; }
+
         /// <summary>
         /// Starts a server which will listen for rpc connections
         /// </summary>
@@ -21,10 +26,5 @@ public interface IRpcServer
         /// </summary>
         /// <returns>A task that completes when the server has shutdown</returns>
         Task ShutdownAsync();
-
-        /// <summary>
-        /// The address that the rpc server is listening on
-        /// </summary>
-        Uri Uri { get; }
     }
 }

src/WebJobs.Script.Grpc/Abstractions/IWorkerProvider.cs

@@ -1,5 +1,5 @@
 // Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+// Licensed under the MIT License. See License.txt in the project root for license information.
 
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;

src/WebJobs.Script.Grpc/Abstractions/WorkerDescription.cs

@@ -1,27 +1,27 @@
 // Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+// Licensed under the MIT License. See License.txt in the project root for license information.
 
 namespace Microsoft.Azure.WebJobs.Script.Abstractions
 {
     public class WorkerDescription
     {
         /// <summary>
-        /// The name of the supported language. This is the same name as the IConfiguration section for the worker.
+        /// Gets or sets the name of the supported language. This is the same name as the IConfiguration section for the worker.
         /// </summary>
         public string Language { get; set; }
 
         /// <summary>
-        /// The supported file extension type. Functions are registered with workers based on extension.
+        /// Gets or sets the supported file extension type. Functions are registered with workers based on extension.
         /// </summary>
         public string Extension { get; set; }
 
         /// <summary>
-        /// The default executable path.
+        /// Gets or sets the default executable path.
         /// </summary>
         public string DefaultExecutablePath { get; set; }
 
         /// <summary>
-        /// The default path to the worker (relative to the bin/workers/{language} directory)
+        /// Gets or sets the default path to the worker (relative to the bin/workers/{language} directory)
         /// </summary>
         public string DefaultWorkerPath { get; set; }
     }

src/WebJobs.Script.Grpc/Server/GrpcServer.cs

@@ -9,10 +9,11 @@
 using Microsoft.Azure.WebJobs.Script.Grpc.Messages;
 
 namespace Microsoft.Azure.WebJobs.Script.Grpc
-{ 
+{
     public class GrpcServer : IRpcServer, IDisposable
     {
         private Server _server;
+        private bool _disposed = false;
 
         public GrpcServer(FunctionRpc.FunctionRpcBase serviceImpl)
         {
@@ -23,34 +24,31 @@ public GrpcServer(FunctionRpc.FunctionRpcBase serviceImpl)
             };
         }
 
-        public Task StartAsync() {
+        public Uri Uri => new Uri($"http://127.0.0.1:{_server.Ports.First().BoundPort}");
+
+        public Task StartAsync()
+        {
             _server.Start();
             return Task.CompletedTask;
         }
 
         public Task ShutdownAsync() => _server.ShutdownAsync();
 
-        public Uri Uri => new Uri($"http://127.0.0.1:{_server.Ports.First().BoundPort}");
-
-        #region IDisposable Support
-        private bool disposedValue = false; // To detect redundant calls
-
         protected virtual void Dispose(bool disposing)
         {
-            if (!disposedValue)
+            if (!_disposed)
             {
                 if (disposing)
                 {
                     _server.ShutdownAsync();
                 }
-                disposedValue = true;
+                _disposed = true;
             }
         }
 
         public void Dispose()
         {
             Dispose(true);
         }
-        #endregion
     }
 }

src/WebJobs.Script.Grpc/WebJobs.Script.Grpc.csproj

@@ -17,6 +17,9 @@
     </PackageReference>
     <PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" />
     <PackageReference Include="Microsoft.Extensions.Configuration" Version="2.0.0" />
+    <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004">
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
   </ItemGroup>
 
   <Target Name="GenerateProtoFiles" BeforeTargets="BeforeBuild" Inputs="Proto/FunctionRpc.proto" Outputs="Messages/DotNet/FunctionRpc.cs;Messages/DotNet/FunctionRpcGrpc.cs">

src/WebJobs.Script.WebHost/Middleware/ScriptHostCheckMiddleware.cs

@@ -1,4 +1,7 @@
-using System;
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;

src/WebJobs.Script.WebHost/Routing/ScriptRouteHandler.cs

@@ -65,7 +65,7 @@ private async Task<IActionResult> GetResultAsync(HttpContext context, string fun
             // Add rounte data to request info
             // TODO: Keeping this here for now as other code depend on this property, but this can be done in the HTTP binding.
             var routingFeature = context.Features.Get<IRoutingFeature>();
-            context.Items.Add(HttpExtensionConstants.AzureWebJobsHttpRouteDataKey, new Dictionary<string,object>(routingFeature.RouteData.Values));
+            context.Items.Add(HttpExtensionConstants.AzureWebJobsHttpRouteDataKey, new Dictionary<string, object>(routingFeature.RouteData.Values));
             context.Features.Set<IFunctionExecutionFeature>(new FunctionExecutionFeature { Descriptor = descriptor });
 
             bool authorized = await AuthenticateAndAuthorizeAsync(context, descriptor);

src/WebJobs.Script.WebHost/Security/Authentication/AuthLevelExtensions.cs

@@ -1,5 +1,5 @@
 // Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+// Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;
 using Microsoft.AspNetCore.Authentication;