Skip to content

Commit d264e18

Browse files
committed
Ensuring diagnostics compilation uses consistent optimization level
1 parent 7b81f1f commit d264e18

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/WebJobs.Script/Description/CSharp/CSharpFunctionInvoker.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ public class CSharpFunctionInvoker : FunctionInvokerBase
3737
private readonly IFunctionEntryPointResolver _functionEntryPointResolver;
3838
private readonly IMetricsLogger _metrics;
3939
private readonly ReaderWriterLockSlim _functionValueLoaderLock = new ReaderWriterLockSlim();
40+
// TODO:Get this from some context set in/by the host.
41+
private bool _compileWithDebugOptmization = true;
4042

4143
private CSharpFunctionSignature _functionSignature;
4244
private IFunctionMetadataResolver _metadataResolver;
@@ -113,7 +115,7 @@ private void ReloadScript()
113115
TraceWriter.Verbose("Compiling function script.");
114116

115117
Script<object> script = CreateScript();
116-
Compilation compilation = script.GetCompilation();
118+
Compilation compilation = GetScriptCompilation(script, _compileWithDebugOptmization);
117119
ImmutableArray<Diagnostic> compilationResult = compilation.GetDiagnostics();
118120

119121
CSharpFunctionSignature signature = CSharpFunctionSignature.FromCompilation(compilation, _functionEntryPointResolver);
@@ -288,15 +290,13 @@ internal async Task<MethodInfo> GetFunctionTargetAsync(int attemptCount = 0)
288290

289291
private MethodInfo CreateFunctionTarget(CancellationToken cancellationToken)
290292
{
291-
// TODO:Get this from some context set in/by the host.
292-
bool debug = true;
293293
MemoryStream assemblyStream = null;
294294
MemoryStream pdbStream = null;
295295

296296
try
297297
{
298298
Script<object> script = CreateScript();
299-
Compilation compilation = GetScriptCompilation(script, debug);
299+
Compilation compilation = GetScriptCompilation(script, _compileWithDebugOptmization);
300300
CSharpFunctionSignature functionSignature = CSharpFunctionSignature.FromCompilation(compilation, _functionEntryPointResolver);
301301

302302
ValidateFunctionBindingArguments(functionSignature, throwIfFailed: true);

0 commit comments

Comments
 (0)