Skip to content

Commit d30073f

Browse files
committed
Updating ASP.NET Core references
1 parent 6038158 commit d30073f

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/WebJobs.Script.WebHost/WebJobs.Script.WebHost.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353

5454
<ItemGroup>
5555
<PackageReference Include="DotNetTI.BreakingChangeAnalysis" Version="1.0.5-preview" />
56-
<PackageReference Include="Microsoft.AspNetCore.App" Version="2.2.7" />
56+
<PackageReference Include="Microsoft.AspNetCore.App" Version="2.2.8" />
5757
<PackageReference Include="Microsoft.Azure.AppService.Proxy.Client" Version="2.0.8100001-0126c21e" />
5858
<PackageReference Include="Microsoft.Azure.Services.AppAuthentication" Version="1.0.3" />
5959
<PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.15" />

src/WebJobs.Script/Binding/Http/RawScriptResult.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ public async Task ExecuteResultAsync(ActionContext context)
8080
{
8181
foreach (var cookie in Cookies)
8282
{
83-
// Item3 (CookieOptions) should not be null, but this will behave correctly if it is
8483
if (cookie.Item3 != null)
8584
{
8685
response.Cookies.Append(cookie.Item1, cookie.Item2, cookie.Item3);

src/WebJobs.Script/Workers/Rpc/MessageExtensions/RpcMessageExtensionUtilities.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ private static SameSiteMode RpcSameSiteEnumConverter(RpcHttpCookie.Types.SameSit
8686
case RpcHttpCookie.Types.SameSite.Lax:
8787
return SameSiteMode.Lax;
8888
case RpcHttpCookie.Types.SameSite.None:
89-
return SameSiteMode.None;
89+
return (SameSiteMode)(-1);
9090
default:
91-
return SameSiteMode.None;
91+
return (SameSiteMode)(-1);
9292
}
9393
}
9494
}

test/WebJobs.Script.Tests/Binding/ActionResults/RawScriptResultTests.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,14 @@ public async Task AddsHttpCookies()
6262
{
6363
new Tuple<string, string, CookieOptions>("firstCookie", "cookieValue", new CookieOptions()
6464
{
65-
SameSite = SameSiteMode.None
65+
SameSite = SameSiteMode.Lax
6666
}),
6767
new Tuple<string, string, CookieOptions>("secondCookie", "cookieValue2", new CookieOptions()
6868
{
6969
Path = "/",
7070
HttpOnly = true,
71-
MaxAge = TimeSpan.FromSeconds(20)
71+
MaxAge = TimeSpan.FromSeconds(20),
72+
SameSite = (SameSiteMode)(-1)
7273
})
7374
}
7475
};
@@ -79,8 +80,8 @@ public async Task AddsHttpCookies()
7980
context.HttpContext.Response.Headers.TryGetValue("Set-Cookie", out StringValues cookies);
8081

8182
Assert.Equal(2, cookies.Count);
82-
Assert.Equal("firstCookie=cookieValue; path=/", cookies[0]);
83-
Assert.Equal("secondCookie=cookieValue2; max-age=20; path=/; samesite=lax; httponly", cookies[1]);
83+
Assert.Equal("firstCookie=cookieValue; path=/; samesite=lax", cookies[0]);
84+
Assert.Equal("secondCookie=cookieValue2; max-age=20; path=/; httponly", cookies[1]);
8485
}
8586

8687
[Fact]

0 commit comments

Comments
 (0)