updating the bundle version resolution to pick the maximum version allowed by the version range (#4333)

* updating the bundle version resolution to pick the maximum version allowed by the version range

* Updating version resolution logic to use FirstorDefualt()

Author: soninaren

src/WebJobs.Script/ExtensionBundle/ExtensionBundleManager.cs

@@ -187,10 +187,14 @@ private static string FindBestVersionMatch(VersionRange versionRange, IEnumerabl
             {
                 var dirName = Path.GetFileName(p);
                 NuGetVersion.TryParse(dirName, out NuGetVersion version);
+                if (version != null)
+                {
+                    version = versionRange.Satisfies(version) ? version : null;
+                }
                 return version;
             }).Where(v => v != null);
 
-            return versionRange.FindBestMatch(bundleVersions)?.ToString();
+            return bundleVersions.OrderByDescending(version => version.Version).FirstOrDefault()?.ToString();
         }
     }
 }

test/WebJobs.Script.Tests/ExtensionBundle/ExtensionBundleManagerTests.cs

@@ -71,10 +71,12 @@ public void TryLocateExtensionBundle_BundleNotPersent_ReturnsFalse()
             Assert.Null(path);
         }
 
-        [Fact]
-        public async Task GetExtensionBundle_BundlePresentAtProbingLocation_ReturnsTrue()
+        [Theory]
+        [InlineData("[2.*, 3.0.0)")]
+        [InlineData("[2.0.0, 3.0.0)")]
+        public async Task GetExtensionBundle_BundlePresentAtProbingLocation_ReturnsTrue(string versionRange)
         {
-            var options = GetTestExtensionBundleOptions(BundleId, "[2.*, 3.0.0)");
+            var options = GetTestExtensionBundleOptions(BundleId, versionRange);
             var fileSystemTuple = CreateFileSystem();
             var directoryBase = fileSystemTuple.Item2;
             var fileBase = fileSystemTuple.Item3;
@@ -87,11 +89,13 @@ public async Task GetExtensionBundle_BundlePresentAtProbingLocation_ReturnsTrue(
             {
                     Path.Combine(firstDefaultProbingPath, "1.0.0"),
                     Path.Combine(firstDefaultProbingPath, "2.0.0"),
+                    Path.Combine(firstDefaultProbingPath, "2.0.1"),
+                    Path.Combine(firstDefaultProbingPath, "2.0.2"),
                     Path.Combine(firstDefaultProbingPath, "3.0.2"),
                     Path.Combine(firstDefaultProbingPath, "invalidVersion")
             });
 
-            string defaultPath = Path.Combine(firstDefaultProbingPath, "2.0.0");
+            string defaultPath = Path.Combine(firstDefaultProbingPath, "2.0.2");
             fileBase.Setup(f => f.Exists(Path.Combine(defaultPath, "bundle.json"))).Returns(true);
 
             FileUtility.Instance = fileSystemTuple.Item1.Object;