Skip to content

Commit e837680

Browse files
authored
Add AssistantSkillTrigger to WebHook triggers (#10120) (#10138)
1 parent d223fa7 commit e837680

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

src/WebJobs.Script/Extensions/BindingMetadataExtensions.cs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,19 @@ public static class BindingMetadataExtensions
1313
private const string HttpTrigger = "httpTrigger";
1414
private const string EventGridTrigger = "eventGridTrigger";
1515
private const string SignalRTrigger = "signalRTrigger";
16+
public const string AssistantSkillTrigger = "assistantSkillTrigger";
1617
private const string BlobTrigger = "blobTrigger";
1718

1819
private const string BlobSourceKey = "source";
1920
private const string EventGridSource = "eventGrid";
2021

22+
private static readonly HashSet<string> WebHookTriggers = new(StringComparer.OrdinalIgnoreCase)
23+
{
24+
EventGridTrigger,
25+
SignalRTrigger,
26+
AssistantSkillTrigger,
27+
};
28+
2129
private static readonly HashSet<string> DurableTriggers = new(StringComparer.OrdinalIgnoreCase)
2230
{
2331
"entityTrigger",
@@ -46,7 +54,7 @@ public static bool IsHttpTrigger(this BindingMetadata binding)
4654
/// <param name="binding">The binding metadata to check.</param>
4755
/// <returns><c>true</c> if a webhook trigger, <c>false</c> otherwise.</returns>
4856
/// <remarks>
49-
/// Known webhook triggers includes SignalR, Event Grid triggers.
57+
/// Known webhook triggers includes SignalR, Event Grid, and Assistant Skill triggers.
5058
/// </remarks>
5159
public static bool IsWebHookTrigger(this BindingMetadata binding)
5260
{
@@ -55,13 +63,7 @@ public static bool IsWebHookTrigger(this BindingMetadata binding)
5563
throw new ArgumentNullException(nameof(binding));
5664
}
5765

58-
if (string.Equals(EventGridTrigger, binding.Type, StringComparison.OrdinalIgnoreCase)
59-
|| string.Equals(SignalRTrigger, binding.Type, StringComparison.OrdinalIgnoreCase))
60-
{
61-
return true;
62-
}
63-
64-
return false;
66+
return WebHookTriggers.Contains(binding.Type);
6567
}
6668

6769
/// <summary>

test/WebJobs.Script.Tests/Extensions/BindingMetadataExtensionsTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public void IsHttpTrigger_ReturnsExpectedValue(string type, bool expected)
7373
[Theory]
7474
[InlineData("eventGridTrigger", true)]
7575
[InlineData("signalRTrigger", true)]
76+
[InlineData("assistantSkillTrigger", true)]
7677
[InlineData("blobTrigger", false, "eventGrid")]
7778
[InlineData("blobTrigger", false, "other")]
7879
[InlineData("httpTrigger", false)]

0 commit comments

Comments
 (0)