Fix for ISO string modification during function metadata binding parsing (#10735)

Author: satvu

release_notes.md

@@ -11,4 +11,6 @@
   - [Added net9 prelaunch app.](https://github.com/Azure/azure-functions-dotnet-worker/pull/2898)
 - Update the `DefaultHttpProxyService` to better handle client disconnect scenarios (#10688)
   - Replaced `InvalidOperationException` with `HttpForwardingException` when there is a ForwarderError
+- Fix modification of ISO strings during the parsing of function metadata bindings.
+  - This fixes the listener errors related to the CosmosDB trigger's `StartFromTime` parameter. (#10735)
 - Updated `WebJobs.Script` to target .NET 8 (instead of .NET Standard 2.1)

src/WebJobs.Script/Host/WorkerFunctionMetadataProvider.cs

@@ -13,6 +13,7 @@
 using Microsoft.Azure.WebJobs.Script.Workers.Rpc;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
+using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 
 namespace Microsoft.Azure.WebJobs.Script
@@ -26,6 +27,7 @@ internal class WorkerFunctionMetadataProvider : IWorkerFunctionMetadataProvider
         private readonly IEnvironment _environment;
         private readonly IWebHostRpcWorkerChannelManager _channelManager;
         private readonly IScriptHostManager _scriptHostManager;
+        private readonly JsonSerializerSettings _dateTimeSerializerSettings;
         private string _workerRuntime;
         private ImmutableArray<FunctionMetadata> _functions;
 
@@ -42,6 +44,7 @@ public WorkerFunctionMetadataProvider(
             _channelManager = webHostRpcWorkerChannelManager;
             _scriptHostManager = scriptHostManager;
             _workerRuntime = _environment.GetEnvironmentVariable(EnvironmentSettingNames.FunctionWorkerRuntime);
+            _dateTimeSerializerSettings = new JsonSerializerSettings { DateParseHandling = DateParseHandling.None };
         }
 
         public ImmutableDictionary<string, ImmutableArray<string>> FunctionErrors
@@ -146,7 +149,7 @@ public async Task<FunctionMetadataResult> GetFunctionMetadataAsync(IEnumerable<R
             return new FunctionMetadataResult(useDefaultMetadataIndexing: false, _functions);
         }
 
-        internal static void ValidateFunctionAppFormat(string scriptPath, ILogger logger, IEnvironment environment, IFileSystem fileSystem = null)
+        internal void ValidateFunctionAppFormat(string scriptPath, ILogger logger, IEnvironment environment, IFileSystem fileSystem = null)
         {
             fileSystem = fileSystem ?? FileUtility.Instance;
             bool mixedApp = false;
@@ -244,13 +247,14 @@ internal IEnumerable<FunctionMetadata> ValidateMetadata(IEnumerable<RawFunctionM
             return validatedMetadata;
         }
 
-        internal static FunctionMetadata ValidateBindings(IEnumerable<string> rawBindings, FunctionMetadata function)
+        internal FunctionMetadata ValidateBindings(IEnumerable<string> rawBindings, FunctionMetadata function)
         {
             HashSet<string> bindingNames = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
 
             foreach (string binding in rawBindings)
             {
-                var functionBinding = BindingMetadata.Create(JObject.Parse(binding));
+                var deserializedObj = JsonConvert.DeserializeObject<JObject>(binding, _dateTimeSerializerSettings);
+                var functionBinding = BindingMetadata.Create(deserializedObj);
 
                 Utility.ValidateBinding(functionBinding);
 

test/WebJobs.Script.Tests/WorkerFunctionMetadataProviderTests.cs

@@ -8,18 +8,34 @@
 using System.Linq;
 using System.Threading.Tasks;
 using Microsoft.Azure.WebJobs.Script.Description;
-using Microsoft.Azure.WebJobs.Script.Grpc.Messages;
-using Microsoft.Azure.WebJobs.Script.Workers;
 using Microsoft.Azure.WebJobs.Script.Workers.Rpc;
 using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Options;
 using Moq;
-using NuGet.ContentModel;
 using Xunit;
 
 namespace Microsoft.Azure.WebJobs.Script.Tests
 {
     public class WorkerFunctionMetadataProviderTests
     {
+        private readonly WorkerFunctionMetadataProvider _workerFunctionMetadataProvider;
+
+        public WorkerFunctionMetadataProviderTests()
+        {
+            var mockScriptOptions = new Mock<IOptionsMonitor<ScriptApplicationHostOptions>>();
+            var mockLogger = new Mock<ILogger<WorkerFunctionMetadataProvider>>();
+            var mockEnvironment = new Mock<IEnvironment>();
+            var mockChannelManager = new Mock<IWebHostRpcWorkerChannelManager>();
+            var mockScriptHostManager = new Mock<IScriptHostManager>();
+
+            _workerFunctionMetadataProvider = new WorkerFunctionMetadataProvider(
+             mockScriptOptions.Object,
+             mockLogger.Object,
+             mockEnvironment.Object,
+             mockChannelManager.Object,
+             mockScriptHostManager.Object);
+        }
+
         [Fact]
         public void ValidateBindings_NoBindings_Throws()
         {
@@ -28,7 +44,7 @@ public void ValidateBindings_NoBindings_Throws()
 
             var ex = Assert.Throws<FormatException>(() =>
             {
-                WorkerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
+                _workerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
             });
 
             Assert.Equal("At least one binding must be declared.", ex.Message);
@@ -45,7 +61,7 @@ public void ValidateBindings_DuplicateBindingNames_Throws()
 
             var ex = Assert.Throws<InvalidOperationException>(() =>
             {
-                WorkerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
+                _workerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
             });
 
             Assert.Equal("Multiple bindings with name 'dupe' discovered. Binding names must be unique.", ex.Message);
@@ -60,7 +76,7 @@ public void ValidateBindings_NoTriggerBinding_Throws()
 
             var ex = Assert.Throws<InvalidOperationException>(() =>
             {
-                WorkerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
+                _workerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
             });
 
             Assert.Equal("No trigger binding specified. A function must have a trigger input binding.", ex.Message);
@@ -81,7 +97,7 @@ public void ValidateBindings_InvalidName_Throws(string bindingName)
 
             var ex = Assert.Throws<ArgumentException>(() =>
             {
-                WorkerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
+                _workerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
             });
 
             Assert.Equal($"The binding name {bindingName} is invalid. Please assign a valid name to the binding.", ex.Message);
@@ -108,7 +124,7 @@ public void ValidateBindings_ValidName_DoesNotThrow(string bindingName)
 
             try
             {
-                WorkerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
+                _workerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
             }
             catch (ArgumentException)
             {
@@ -123,7 +139,7 @@ public void ValidateFunctionAppFormat_InputMixedApp()
             logger.ClearLogMessages();
             string scriptPath = Path.Combine(Environment.CurrentDirectory, @"..", "..", "..", "..", "sample", "node");
             var environment = SystemEnvironment.Instance;
-            WorkerFunctionMetadataProvider.ValidateFunctionAppFormat(scriptPath, logger, environment);
+            _workerFunctionMetadataProvider.ValidateFunctionAppFormat(scriptPath, logger, environment);
             var traces = logger.GetLogMessages();
             var functionLoadLogs = traces.Where(m => m.FormattedMessage.Contains("Detected mixed function app. Some functions may not be indexed"));
             Assert.True(functionLoadLogs.Any());
@@ -139,7 +155,7 @@ public void ValidateBindings_OutputNameWithoutDirection_Throws()
 
             var ex = Assert.Throws<ArgumentException>(() =>
             {
-                WorkerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
+                _workerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
             });
 
             Assert.Equal($"{ScriptConstants.SystemReturnParameterBindingName} bindings must specify a direction of 'out'.", ex.Message);
@@ -180,5 +196,19 @@ public async void ValidateFunctionMetadata_Logging()
             Assert.Equal("Reading functions metadata (Worker)", traces[1].FormattedMessage);
             // The third log is Host is running without any initialized channels, restarting the JobHost. This is not relevant to this test.
         }
+
+        [Fact]
+        public void ValidateFunctionMetadata_IsoStringNotAltered()
+        {
+            FunctionMetadata functionMetadata = new FunctionMetadata();
+            List<string> rawBindings = new List<string>();
+            var isoString = "2025-02-10T22:45:33Z";
+            rawBindings.Add("{\"type\": \"cosmosDBTrigger\",\"name\": \"cosmosTrigger\",\"direction\": \"in\",\"databaseName\":\"databaseName\"," +
+                "\"containerName\":\"containerNameFoo\",\"leaseContainerName\":\"leaseContanerFoo\",\"createLeaseContainerIfNotExists\":true," +
+                "\"connection\":\"CosmosConnection\",\"startFromTime\":\"" + isoString + "\",\"dataType\":\"String\"}");
+
+            var function = _workerFunctionMetadataProvider.ValidateBindings(rawBindings, functionMetadata);
+            Assert.Equal(isoString, function.Bindings.FirstOrDefault().Raw["startFromTime"].ToString());
+        }
     }
 }