Fixing type name formatting to handle scenarios where namesapace and assembly symbols do not exist (e.g. 'dynamic')

fabiocav · fabiocav · commit f1d991029d07 · 2016-07-15T11:47:53.000-07:00
diff --git a/src/WebJobs.Script/Description/DotNet/CSharp/CSharpCompilation.cs b/src/WebJobs.Script/Description/DotNet/CSharp/CSharpCompilation.cs
@@ -60,7 +60,9 @@ private static string GetFullTypeName(ITypeSymbol type)
                 return string.Empty;
             }
 
-            return string.Format(CultureInfo.InvariantCulture, "{0}.{1}, {2}", type.ContainingNamespace.MetadataName, type.MetadataName, type.ContainingAssembly.ToDisplayString());
+            return type.ContainingAssembly == null
+                ? type.ToDisplayString()
+                : string.Format(CultureInfo.InvariantCulture, "{0}, {1}", type.ToDisplayString(), type.ContainingAssembly.ToDisplayString());
         }
 
         private static bool IsOrUsesAssemblyType(ITypeSymbol typeSymbol, IAssemblySymbol assemblySymbol)

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,9 @@ private static string GetFullTypeName(ITypeSymbol type)`
`60`	`60`	`return string.Empty;`
`61`	`61`	`}`
`62`	`62`
`63`		`- return string.Format(CultureInfo.InvariantCulture, "{0}.{1}, {2}", type.ContainingNamespace.MetadataName, type.MetadataName, type.ContainingAssembly.ToDisplayString());`
	`63`	`+ return type.ContainingAssembly == null`
	`64`	`+ ? type.ToDisplayString()`
	`65`	`+ : string.Format(CultureInfo.InvariantCulture, "{0}, {1}", type.ToDisplayString(), type.ContainingAssembly.ToDisplayString());`
`64`	`66`	`}`
`65`	`67`
`66`	`68`	`private static bool IsOrUsesAssemblyType(ITypeSymbol typeSymbol, IAssemblySymbol assemblySymbol)`