Fix Blob Trigger Error (#9419)

Co-authored-by: Tony Choi <[email protected]>
Co-authored-by: Brett Samblanet <[email protected]>

Author: 3 people

src/WebJobs.Script/Extensions/FunctionMetadataExtensions.cs

@@ -55,8 +55,9 @@ public static bool IsLegacyBlobTriggerFunction(this FunctionMetadata metadata)
                         return !string.Equals(token.ToString(), BlobEventGridSourceValue, StringComparison.OrdinalIgnoreCase);
                     }
                 }
+                return true;
             }
-            return true;
+            return false;
         }
 
         public static string GetFunctionId(this FunctionMetadata metadata)

test/WebJobs.Script.Tests/ScriptHostTests.cs

@@ -1452,6 +1452,39 @@ public void ValidateFunction_ThrowsForLegacyBlobTrigger_OnFlexConsumption()
             ScriptHost.ValidateFunction(function.Object, httpFunctions, testEnvironment);
         }
 
+        [Fact]
+        public void ValidateFunction_DoesntThrowForHttpTrigger_OnFlexConsumption()
+        {
+            var httpFunctions = new Dictionary<string, HttpTriggerAttribute>();
+            var name = "test";
+
+            BindingMetadata httpTriggerMetadata = BindingMetadata.Create(JObject.Parse("{\"type\": \"httpTrigger\",\"name\": \"req\",\"direction\": \"in\"}"));
+
+            var metadata = new FunctionMetadata();
+            metadata.Bindings.Add(httpTriggerMetadata);
+            var function = new Mock<FunctionDescriptor>(MockBehavior.Strict, name, null, metadata, null, null, null, null);
+            function.SetupGet(p => p.HttpTriggerAttribute).Returns(() => null);
+
+            TestEnvironment testEnvironment = new TestEnvironment();
+            testEnvironment.SetEnvironmentVariable(EnvironmentSettingNames.AzureWebsiteSku, ScriptConstants.FlexConsumptionSku);
+
+            var exception = Record.Exception(() =>
+            {
+                ScriptHost.ValidateFunction(function.Object, httpFunctions, testEnvironment);
+            });
+            Assert.Null(exception);
+
+            metadata.Bindings.Clear();
+
+            exception = Record.Exception(() =>
+            {
+                ScriptHost.ValidateFunction(function.Object, httpFunctions, testEnvironment);
+            });
+            Assert.Null(exception);
+
+            ScriptHost.ValidateFunction(function.Object, httpFunctions, testEnvironment);
+        }
+
         [Fact]
         public async Task IsFunction_ReturnsExpectedResult()
         {