bumping stylecop and addressing all errors (#8975)

Co-authored-by: Jacob Viau <[email protected]>

Author: brettsam

src/WebJobs.Script.Abstractions/WebJobs.Script.Abstractions.csproj

@@ -38,7 +38,7 @@
     <PackageReference Include="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel" Version="2.21.0" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
     <PackageReference Include="System.Collections.Immutable" Version="1.5.0" />
-    <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004">
+    <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.435">
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
   </ItemGroup>

src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs

@@ -50,7 +50,7 @@ internal class GrpcWorkerChannel : IRpcWorkerChannel, IDisposable
         private readonly IOptions<WorkerConcurrencyOptions> _workerConcurrencyOptions;
         private readonly WaitCallback _processInbound;
         private readonly object _syncLock = new object();
-        private readonly Dictionary<MsgType, Queue<PendingItem>> _pendingActions = new ();
+        private readonly Dictionary<MsgType, Queue<PendingItem>> _pendingActions = new();
         private readonly ChannelWriter<OutboundGrpcEvent> _outbound;
         private readonly ChannelReader<InboundGrpcEvent> _inbound;
         private readonly IOptions<FunctionsHostingConfigOptions> _hostingConfigOptions;

src/WebJobs.Script.Grpc/Extensions/ScriptInvocationContextExtensions.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.IO;
 using System.Linq;
 using System.Text;
@@ -53,12 +52,12 @@ public static async Task<InvocationRequest> ToRpcInvocationRequest(this ScriptIn
                 if (isSharedMemoryDataTransferEnabled)
                 {
                     // Try to transfer this data over shared memory instead of RPC
-                    if (input.val == null || !sharedMemValueCache.TryGetValue(input.val, out sharedMemValue))
+                    if (input.Val == null || !sharedMemValueCache.TryGetValue(input.Val, out sharedMemValue))
                     {
-                        sharedMemValue = await input.val.ToRpcSharedMemoryAsync(input.type, logger, invocationRequest.InvocationId, sharedMemoryManager);
-                        if (input.val != null)
+                        sharedMemValue = await input.Val.ToRpcSharedMemoryAsync(input.Type, logger, invocationRequest.InvocationId, sharedMemoryManager);
+                        if (input.Val != null)
                         {
-                            sharedMemValueCache.Add(input.val, sharedMemValue);
+                            sharedMemValueCache.Add(input.Val, sharedMemValue);
                         }
                     }
                 }
@@ -68,35 +67,35 @@ public static async Task<InvocationRequest> ToRpcInvocationRequest(this ScriptIn
                     // Data was successfully transferred over shared memory; create a ParameterBinding accordingly
                     parameterBinding = new ParameterBinding
                     {
-                        Name = input.name,
+                        Name = input.Name,
                         RpcSharedMemory = sharedMemValue
                     };
 
                     usedSharedMemory = true;
-                    logBuilder.AppendFormat("{0}:{1},", input.name, sharedMemValue.Count);
+                    logBuilder.AppendFormat("{0}:{1},", input.Name, sharedMemValue.Count);
                 }
                 else
                 {
-                    if (!TryConvertObjectIfNeeded(input.val, logger, out object val))
+                    if (!TryConvertObjectIfNeeded(input.Val, logger, out object val))
                     {
                         // Conversion did not take place, keep the existing value as it is
-                        val = input.val;
+                        val = input.Val;
                     }
 
                     // Data was not transferred over shared memory (either disabled, type not supported or some error); resort to RPC
                     TypedData rpcValue = null;
                     if (val == null || !rpcValueCache.TryGetValue(val, out rpcValue))
                     {
                         rpcValue = await val.ToRpc(logger, capabilities);
-                        if (input.val != null)
+                        if (input.Val != null)
                         {
                             rpcValueCache.Add(val, rpcValue);
                         }
                     }
 
                     parameterBinding = new ParameterBinding
                     {
-                        Name = input.name,
+                        Name = input.Name,
                         Data = rpcValue
                     };
                 }

src/WebJobs.Script.Grpc/WebJobs.Script.Grpc.csproj

@@ -27,7 +27,7 @@
     <PackageReference Include="Microsoft.ApplicationInsights.WindowsServer" Version="2.21.0" />
     <PackageReference Include="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel" Version="2.21.0" />
     <PackageReference Include="System.IO.FileSystem.Primitives" Version="4.3.0" />
-    <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004">
+    <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.435">
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="System.Threading.Channels" Version="6.0.0" />

src/WebJobs.Script.WebHost/Extensions/ExceptionExtensions.cs

@@ -7,7 +7,7 @@ namespace System
 {
     internal static class ExceptionExtensions
     {
-        public static (string exceptionType, string exceptionMessage, string exceptionDetails) GetExceptionDetails(this Exception exception)
+        public static (string ExceptionType, string ExceptionMessage, string ExceptionDetails) GetExceptionDetails(this Exception exception)
         {
             if (exception == null)
             {

src/WebJobs.Script.WebHost/Management/FunctionsSyncManager.cs

@@ -687,7 +687,7 @@ internal HttpRequestMessage BuildSetTriggersRequest()
 
         // This function will call POST https://{app}.azurewebsites.net/operation/settriggers with the content
         // of triggers. It'll verify app ownership using a SWT token valid for 5 minutes. It should be plenty.
-        private async Task<(bool, string)> SetTriggersAsync(string content)
+        private async Task<(bool Success, string ErrorMessage)> SetTriggersAsync(string content)
         {
             var token = SimpleWebTokenHelper.CreateToken(DateTime.UtcNow.AddMinutes(5));
 

src/WebJobs.Script.WebHost/Management/IWebFunctionsManager.cs

@@ -12,10 +12,10 @@ public interface IWebFunctionsManager
     {
         Task<IEnumerable<FunctionMetadataResponse>> GetFunctionsMetadata(bool includeProxies);
 
-        Task<(bool, FunctionMetadataResponse)> TryGetFunction(string name, HttpRequest request);
+        Task<(bool Success, FunctionMetadataResponse Response)> TryGetFunction(string name, HttpRequest request);
 
-        Task<(bool, bool, FunctionMetadataResponse)> CreateOrUpdate(string name, FunctionMetadataResponse functionMetadata, HttpRequest request);
+        Task<(bool Success, bool ConfigChanged, FunctionMetadataResponse Response)> CreateOrUpdate(string name, FunctionMetadataResponse functionMetadata, HttpRequest request);
 
-        Task<(bool, string)> TryDeleteFunction(FunctionMetadataResponse function);
+        Task<(bool Success, string ErrorMessage)> TryDeleteFunction(FunctionMetadataResponse function);
     }
 }

src/WebJobs.Script.WebHost/Management/InstanceManager.cs

@@ -214,7 +214,7 @@ public async Task<string> ValidateContext(HostAssignmentContext assignmentContex
             }
         }
 
-        private async Task<(string, long?)> ValidateBlobPackageContext(RunFromPackageContext context)
+        private async Task<(string Error, long? ContentLength)> ValidateBlobPackageContext(RunFromPackageContext context)
         {
             string blobUri = context.Url;
             string eventName = context.IsWarmUpRequest

src/WebJobs.Script.WebHost/Management/LinuxSpecialization/BashCommandHandler.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Diagnostics;
-using Microsoft.Azure.WebJobs.Logging;
 using Microsoft.Azure.WebJobs.Script.Diagnostics;
 using Microsoft.Extensions.Logging;
 
@@ -22,7 +21,7 @@ public BashCommandHandler(IMetricsLogger metricsLogger, ILogger<BashCommandHandl
             _logger = logger ?? throw new ArgumentNullException(nameof(logger));
         }
 
-        public (string, string, int) RunBashCommand(string command, string metricName)
+        public (string Output, string Error, int ExitCode) RunBashCommand(string command, string metricName)
         {
             try
             {

src/WebJobs.Script.WebHost/Management/LinuxSpecialization/IBashCommandHandler.cs

@@ -5,6 +5,6 @@ namespace Microsoft.Azure.WebJobs.Script.WebHost.Management.LinuxSpecialization
 {
     public interface IBashCommandHandler
     {
-        (string, string, int) RunBashCommand(string command, string metricName);
+        (string Output, string Error, int ExitCode) RunBashCommand(string command, string metricName);
     }
 }