Skip to content

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Jun 28, 2024

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR -- TODO
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Updates 1ES tests to use release config and splits out restore & build phase. This also updates the dotnet worker host to 1.0.13

@jviau jviau added the 1es 1 engineering system label Jun 28, 2024
@jviau jviau requested a review from a team as a code owner June 28, 2024 19:33
@jviau jviau force-pushed the jviau/eng/test-release branch from 7c279fa to 3b79f5d Compare June 28, 2024 19:34
@jviau jviau requested review from fabiocav and brettsam as code owners July 1, 2024 20:00
@jviau jviau force-pushed the jviau/eng/test-release branch from c3a43bd to 9ffef10 Compare July 1, 2024 20:01
@jviau
Copy link
Contributor Author

jviau commented Sep 30, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

liliankasem
liliankasem previously approved these changes Oct 4, 2024
@mattchenderson mattchenderson added the area: engineering Engineering improvements label Dec 2, 2024
@jviau
Copy link
Contributor Author

jviau commented Dec 4, 2024

/azp run host.public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jviau
Copy link
Contributor Author

jviau commented May 14, 2025

/azp run host.integration-tests

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@jviau jviau requested a review from kshyju June 3, 2025 17:10
@Copilot Copilot AI review requested due to automatic review settings August 29, 2025 16:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI/CD pipeline configuration to use release builds instead of debug builds and separates the restore and build phases for better build optimization. It also updates the dotnet worker host version and improves test organization.

  • Splits restore and build phases in CI pipelines for better performance
  • Updates all test configurations to use release builds instead of debug builds
  • Updates dotnet worker host to version 1.0.13

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/WebJobs.Script.Tests/FunctionsSyncServiceTests.cs Refactors test setup and adds new test case for token cancellation scenarios
test/WebJobs.Script.Tests.Shared/TestHelpers.cs Adds BuildConfig constant to determine debug/release configuration
test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/WebHostStartupEndToEndTests.cs Updates path to use dynamic build configuration
test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/SpecializationE2ETests.cs Updates paths to use dynamic build configuration
test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/HostProcessLauncher.cs Updates path to use dynamic build configuration
test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/CSharpPrecompiledTestFixture.cs Updates path template to use dynamic build configuration
eng/ci/templates/official/jobs/run-non-e2e-tests.yml Splits restore/build phases and switches to release configuration
eng/ci/templates/official/jobs/run-integration-tests.yml Splits restore/build phases and switches to release configuration
eng/ci/templates/jobs/run-unit-tests.yml Splits restore/build phases and switches to release configuration
eng/ci/official-build.yml Adds SDL suppression configuration
eng/ci/integration-tests.yml Adds SDL suppression configuration
eng/build/Workers.Dotnet.props Updates dotnet worker host version from 1.0.12 to 1.0.13

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1es 1 engineering system area: engineering Engineering improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants