Enabling worker indexing for Logic apps behind an enviornment setting #11377
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables worker indexing for Logic Apps when they operate in codeful mode, controlled by the WORKFLOW_CODEFUL_ENABLED environment variable. This allows Logic Apps with .NET codeful functions to leverage worker-based indexing while maintaining backward compatibility for traditional Logic Apps.
- Adds a new environment variable check for Logic App codeful mode
- Modifies worker indexing logic to allow indexing for Logic Apps when codeful mode is enabled
- Disables runtime/payload metadata mismatch validation for Logic Apps in codeful mode
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/WebJobs.Script/Environment/EnvironmentSettingNames.cs | Adds the new environment variable constant for Logic App codeful mode |
| src/WebJobs.Script/Environment/EnvironmentExtensions.cs | Implements the extension method to check if Logic App codeful mode is enabled |
| src/WebJobs.Script/Utility.cs | Updates worker indexing logic to allow indexing for Logic Apps in codeful mode |
| src/WebJobs.Script/Host/ScriptHost.cs | Disables runtime/payload metadata validation for Logic Apps in codeful mode |
| if (!cancellationToken.IsCancellationRequested) | ||
| { | ||
| bool throwOnWorkerRuntimeAndPayloadMetadataMismatch = true; | ||
| bool throwOnWorkerRuntimeAndPayloadMetadataMismatch = _environment.IsLogicApp() && _environment.IsLogicAppCodefulModeEnabled() ? false: true; |
There was a problem hiding this comment.
The ternary operator can be simplified. Since the condition already evaluates to a boolean, you can negate it directly: bool throwOnWorkerRuntimeAndPayloadMetadataMismatch = !(_environment.IsLogicApp() && _environment.IsLogicAppCodefulModeEnabled());
| bool throwOnWorkerRuntimeAndPayloadMetadataMismatch = _environment.IsLogicApp() && _environment.IsLogicAppCodefulModeEnabled() ? false: true; | |
| bool throwOnWorkerRuntimeAndPayloadMetadataMismatch = !(_environment.IsLogicApp() && _environment.IsLogicAppCodefulModeEnabled()); |
Copilot uses AI. Check for mistakes.
apranaseth
force-pushed
the
apseth/in-proc
branch
from
504c0cd to
0b7ff55
Compare
…ions-host into apseth/in-proc
|
@apranaseth you will need to rebase off in-proc branch to fix your CI build. |
This is to enable worker indexing for Logic Apps workflow app kind behind an environment variable. The settings used by Logic Apps are "FUNCTIONS_INPROC_NET8_ENABLED": "1", "FUNCTIONS_WORKER_RUNTIME": "dotnet" and we are bringing up a "dotnet" worker.
resolves #11386
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information