Fix OTel test env var reset logic (#1066)

Author: andystaples

test/Unit/OpenTelemetry/OpenTelemetryControllerTests.cs

@@ -10,13 +10,15 @@ namespace Microsoft.Azure.Functions.PowerShellWorker.Test.OpenTelemetry
 {
     using PowerShell = System.Management.Automation.PowerShell;
 
+    [Collection("Sequence")]
     public class OpenTelemetryControllerTests
     {
         // These constant values will work because they are not actually passed to the module
         // The module would fail with these inputs, it needs real invocation id and trace information
         private const string FakeInvocationID = "Fake InvocationID";
         private const string FakeTraceParent = "Fake TraceParent";
 
+        private const string OTelEnabledEnvironmentVariableName = "OTEL_FUNCTIONS_WORKER_ENABLED";
         private readonly Mock<ILogger> _mockLogger = new Mock<ILogger>(MockBehavior.Strict);
         private readonly Mock<IPowerShellServicesForOpenTelemetry> _mockOtelServices;
 
@@ -26,22 +28,23 @@ public OpenTelemetryControllerTests()
         }
 
         [Theory]
-        [InlineData("true", true)]
-        [InlineData("false", false)]
         [InlineData("True", true)]
         [InlineData("False", false)]
+        [InlineData("true", true)]
+        [InlineData("false", false)]
         [InlineData(null, false)]
         internal void OpenTelemetryEnvironmentVariableCheckWorks(string? environmentVariableValue, bool desiredResult)
         {
             try
             {
-                Environment.SetEnvironmentVariable("OTEL_FUNCTIONS_WORKER_ENABLED", environmentVariableValue);
+                Environment.SetEnvironmentVariable(OTelEnabledEnvironmentVariableName, environmentVariableValue);
+                OpenTelemetryController.ResetOpenTelemetryModuleStatus();
 
                 Assert.Equal(desiredResult, OpenTelemetryController.IsOpenTelemetryEnvironmentEnabled());
             }
             finally
             {
-                Environment.SetEnvironmentVariable("OTEL_FUNCTIONS_WORKER_ENABLED", null);
+                Environment.SetEnvironmentVariable(OTelEnabledEnvironmentVariableName, null);
                 OpenTelemetryController.ResetOpenTelemetryModuleStatus();
             }
         }