Fix test cases, remove extra cmdlet import

Author: Anthony Staples

src/RequestProcessor.cs

@@ -376,8 +376,6 @@ private StreamingMessage ProcessFunctionMetadataRequest(StreamingMessage request
 
             response.FunctionMetadataResponse.FunctionMetadataResults.AddRange(WorkerIndexingHelper.IndexFunctions(request.FunctionsMetadataRequest.FunctionAppDirectory));
 
-            string rawresp = JsonSerializer.Serialize<FunctionMetadataResponse>(response.FunctionMetadataResponse);
-
             return response;
         }
 

src/WorkerIndexing/WorkerIndexingHelper.cs

@@ -19,12 +19,11 @@ internal static IEnumerable<RpcFunctionMetadata> IndexFunctions(string baseDir)
             List<RpcFunctionMetadata> indexedFunctions = new List<RpcFunctionMetadata>();
 
             InitialSessionState initial = InitialSessionState.CreateDefault();
-            initial.ImportPSModule(new string[] { "AzureFunctionsHelpers" });
             Runspace runspace = RunspaceFactory.CreateRunspace(initial);
             runspace.Open();
             System.Management.Automation.PowerShell ps = System.Management.Automation.PowerShell.Create();
             ps.Runspace = runspace;
-            //ps.AddCommand("Import-Module").AddArgument("C:\\Program Files\\WindowsPowerShell\\Modules\\AzureFunctionsHelpers\\AzureFunctionsHelpers.dll").Invoke();
+
             ps.AddCommand("Get-FunctionsMetadata").AddArgument(baseDir);
             string outputString = string.Empty;
             foreach (PSObject rawMetadata in ps.Invoke())

test/Unit/DependencyManagement/DependencyManagementTests.cs

@@ -74,12 +74,10 @@ private string InitializeManagedDependenciesDirectory(string functionAppRootPath
         private void TestCaseCleanup()
         {
             // We run a test case clean up to reset DependencyManager.Dependencies and DependencyManager.DependenciesPath
-            var functionFolderPath = Path.Combine(_dependencyManagementDirectory, "DirectoryThatDoesNotExist");
-            var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
 
             try
             {
-                using (var dependencyManager = new DependencyManager(functionLoadRequest.Metadata.Directory))
+                using (var dependencyManager = new DependencyManager(_dependencyManagementDirectory))
                 {
                     dependencyManager.Initialize(_testLogger);
                 }
@@ -97,14 +95,11 @@ public void TestManagedDependencyBasicRequirements()
             {
                 // Test case setup.
                 var requirementsDirectoryName = "BasicRequirements";
-                var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
                 var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
                 var managedDependenciesFolderPath = InitializeManagedDependenciesDirectory(functionAppRoot);
 
-                var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
-
                 // Create DependencyManager and process the requirements.psd1 file at the function app root.
-                using (var dependencyManager = new DependencyManager(functionLoadRequest.Metadata.Directory, logger: _testLogger))
+                using (var dependencyManager = new DependencyManager(functionAppRoot, logger: _testLogger))
                 {
                     var currentDependenciesPath = dependencyManager.Initialize(_testLogger);
 
@@ -128,13 +123,11 @@ public void TestManagedDependencyEmptyHashtableRequirement()
             {
                 // Test case setup.
                 var requirementsDirectoryName = "EmptyHashtableRequirement";
-                var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
                 var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
                 var managedDependenciesFolderPath = InitializeManagedDependenciesDirectory(functionAppRoot);
-                var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
 
                 // Create DependencyManager and process the requirements.psd1 file at the function app root.
-                using (var dependencyManager = new DependencyManager(functionLoadRequest.Metadata.Directory, logger: _testLogger))
+                using (var dependencyManager = new DependencyManager(functionAppRoot, logger: _testLogger))
                 {
                     var currentDependenciesPath = dependencyManager.Initialize(_testLogger);
 
@@ -152,10 +145,9 @@ public void TestManagedDependencyNoHashtableRequirementShouldThrow()
         {
             // Test case setup.
             var requirementsDirectoryName = "NoHashtableRequirements";
-            var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
-            var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
+            var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
 
-            using (var dependencyManager = new DependencyManager(functionLoadRequest.Metadata.Directory, logger: _testLogger))
+            using (var dependencyManager = new DependencyManager(functionAppRoot, logger: _testLogger))
             {
                 // Trying to set the functionApp dependencies should throw since requirements.psd1 is not a hash table.
                 var exception = Assert.Throws<DependencyInstallationException>(
@@ -171,10 +163,9 @@ public void TestManagedDependencyInvalidRequirementsFormatShouldThrow()
         {
             // Test case setup.
             var requirementsDirectoryName = "InvalidRequirementsFormat";
-            var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
-            var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
+            var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
 
-            using (var dependencyManager = new DependencyManager(functionLoadRequest.Metadata.Directory, logger: _testLogger))
+            using (var dependencyManager = new DependencyManager(functionAppRoot, logger: _testLogger))
             {
                 // Trying to set the functionApp dependencies should throw since the module version
                 // in requirements.psd1 is not in a valid format.
@@ -192,10 +183,9 @@ public void TestManagedDependencyNoRequirementsFileShouldThrow()
         {
             // Test case setup.
             var requirementsDirectoryName = "ModuleThatDoesNotExist";
-            var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
-            var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
+            var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
 
-            using (var dependencyManager = new DependencyManager(functionLoadRequest.Metadata.Directory, logger: _testLogger))
+            using (var dependencyManager = new DependencyManager(functionAppRoot, logger: _testLogger))
             {
                 // Trying to set the functionApp dependencies should throw since no
                 // requirements.psd1 is found at the function app root.
@@ -214,16 +204,14 @@ public void TestManagedDependencySuccessfulModuleDownload()
             {
                 // Test case setup.
                 var requirementsDirectoryName = "BasicRequirements";
-                var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
                 var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
                 var managedDependenciesFolderPath = InitializeManagedDependenciesDirectory(functionAppRoot);
-                var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
 
                 // Configure MockModuleProvider to mimic a successful download.
                 var mockModuleProvider = new MockModuleProvider { SuccessfulDownload = true };
 
                 // Create DependencyManager and process the requirements.psd1 file at the function app root.
-                using (var dependencyManager = new DependencyManager(functionLoadRequest.Metadata.Directory, mockModuleProvider, logger: _testLogger))
+                using (var dependencyManager = new DependencyManager(functionAppRoot, mockModuleProvider, logger: _testLogger))
                 {
                     dependencyManager.Initialize(_testLogger);
 
@@ -260,17 +248,14 @@ public void TestManagedDependencySuccessfulModuleDownloadAfterTwoTries()
             {
                 // Test case setup
                 var requirementsDirectoryName = "BasicRequirements";
-                var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
                 var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
                 var managedDependenciesFolderPath = InitializeManagedDependenciesDirectory(functionAppRoot);
 
-                var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
-
                 // Configure MockModuleProvider to not throw in the RunSaveModuleCommand call after 2 tries.
                 var mockModuleProvider = new MockModuleProvider { ShouldNotThrowAfterCount = 2 };
 
                 // Create DependencyManager and process the requirements.psd1 file at the function app root.
-                using (var dependencyManager = new DependencyManager(functionLoadRequest.Metadata.Directory, mockModuleProvider, logger: _testLogger))
+                using (var dependencyManager = new DependencyManager(functionAppRoot, mockModuleProvider, logger: _testLogger))
                 {
                     dependencyManager.Initialize(_testLogger);
 
@@ -320,14 +305,11 @@ public void TestManagedDependencyRetryLogicMaxNumberOfTries()
             {
                 // Test case setup
                 var requirementsDirectoryName = "BasicRequirements";
-                var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
                 var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
                 var managedDependenciesFolderPath = InitializeManagedDependenciesDirectory(functionAppRoot);
 
-                var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
-
                 // Create DependencyManager and process the requirements.psd1 file at the function app root.
-                using (var dependencyManager = new DependencyManager(functionLoadRequest.Metadata.Directory, new MockModuleProvider(), logger: _testLogger))
+                using (var dependencyManager = new DependencyManager(functionAppRoot, new MockModuleProvider(), logger: _testLogger))
                 {
                     dependencyManager.Initialize(_testLogger);
 
@@ -374,16 +356,13 @@ public void FunctionAppExecutionShouldStopIfNoPreviousDependenciesAreInstalled()
             {
                 // Test case setup
                 var requirementsDirectoryName = "BasicRequirements";
-                var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
                 var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
                 var managedDependenciesFolderPath = InitializeManagedDependenciesDirectory(functionAppRoot);
 
-                var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
-
                 // Create DependencyManager and configure it to mimic being unable to reach
                 // the PSGallery to retrieve the latest module version
                 using (var dependencyManager = new DependencyManager(
-                    functionLoadRequest.Metadata.Directory,
+                    functionAppRoot,
                     new MockModuleProvider { GetLatestModuleVersionThrows = true },
                     logger: _testLogger))
                 {
@@ -411,15 +390,13 @@ public void FunctionAppExecutionShouldContinueIfPreviousDependenciesExist()
             {
                 // Test case setup
                 var requirementsDirectoryName = "BasicRequirements";
-                var functionFolderPath = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName, "FunctionDirectory");
                 var functionAppRoot = Path.Combine(_dependencyManagementDirectory, requirementsDirectoryName);
                 var managedDependenciesFolderPath = InitializeManagedDependenciesDirectory(functionAppRoot);
-                var functionLoadRequest = GetFuncLoadRequest(functionFolderPath, true);
 
                 // Create DependencyManager and configure it to mimic being unable to reach
                 // the PSGallery to retrive the latest module version
                 using (var dependencyManager = new DependencyManager(
-                    functionLoadRequest.Metadata.Directory,
+                    functionAppRoot,
                     new MockModuleProvider { GetLatestModuleVersionThrows = true },
                     logger: _testLogger))
                 {