Skip to content

Commit 803caec

Browse files
authored
Update opentelemetry(_sdk) to 0.27, tracing-opentelemetry 0.28, fix build issues (#161)
* Update opentelemetry_sdk requirement from 0.26 to 0.27 Updates the requirements on [opentelemetry_sdk](https://github.com/open-telemetry/opentelemetry-rust) to permit the latest version. - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry_sdk-0.26.0...opentelemetry_sdk-0.27.1) --- updated-dependencies: - dependency-name: opentelemetry_sdk dependency-type: direct:production ... * Update opentelemetry requirement from 0.26 to 0.27 Updates the requirements on [opentelemetry](https://github.com/open-telemetry/opentelemetry-rust) to permit the latest version. - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry-0.26.0...opentelemetry-0.27.1) --- updated-dependencies: - dependency-name: opentelemetry dependency-type: direct:production ... * Update tracing-opentelemetry requirement from 0.27 to 0.28 Updates the requirements on [tracing-opentelemetry](https://github.com/tokio-rs/tracing-opentelemetry) to permit the latest version. - [Release notes](https://github.com/tokio-rs/tracing-opentelemetry/releases) - [Changelog](https://github.com/tokio-rs/tracing-opentelemetry/blob/v0.1.x/CHANGELOG.md) - [Commits](tokio-rs/tracing-opentelemetry@v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: tracing-opentelemetry dependency-type: direct:production ... * Do not use with_config for opentelemetry 0.27 As opentelemetry 0.27 or newer does not have a method `with_config` for TraceBuilder, it is necessary to call `with_sampler` directly from TraceBuilder without `with_config`. Needed to fix build issues with opentelemetry(_sdk) 0.27 or newer as well as tracing-opentelemetry 0.28 or newer. See also open-telemetry/opentelemetry-rust#2303. --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Dongsu Park <[email protected]>
1 parent fa2dc77 commit 803caec

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ tracing = "0.1.40"
1818
clap = { version = "4.5.21", features = ["derive", "cargo", "env"] }
1919
sysinfo = "0.33"
2020
tracing-subscriber = { version = "0.3.18", features = ["env-filter"] }
21-
opentelemetry = "0.26"
22-
opentelemetry_sdk = "0.26"
23-
tracing-opentelemetry = "0.27"
21+
opentelemetry = "0.27"
22+
opentelemetry_sdk = "0.27"
23+
tracing-opentelemetry = "0.28"
2424
uuid = { version = "1.2", features = ["v4"] }
2525
chrono = "0.4"
2626

src/logging.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
use opentelemetry::{global, trace::TracerProvider};
55
use opentelemetry_sdk::trace::{
6-
self as sdktrace, Config, Sampler, TracerProvider as SdkTracerProvider,
6+
self as sdktrace, Sampler, TracerProvider as SdkTracerProvider,
77
};
88
use tracing::{event, Level};
99
use tracing_opentelemetry::OpenTelemetryLayer;
@@ -15,9 +15,9 @@ use tracing_subscriber::{
1515
use crate::kvp::EmitKVPLayer;
1616

1717
pub fn initialize_tracing() -> sdktrace::Tracer {
18-
let config = Config::default().with_sampler(Sampler::AlwaysOn);
19-
20-
let provider = SdkTracerProvider::builder().with_config(config).build();
18+
let provider = SdkTracerProvider::builder()
19+
.with_sampler(Sampler::AlwaysOn)
20+
.build();
2121

2222
global::set_tracer_provider(provider.clone());
2323
provider.tracer("azure-kvp")

0 commit comments

Comments
 (0)