feat!: registry endpoint management command updates and preview flag removal (#738)

Author: c-ryan-k

azext_edge/edge/_help.py

@@ -754,41 +754,40 @@ def load_iotops_help():
     """
 
     helps[
-        "iot ops registry add"
+        "iot ops registry create"
     ] = """
         type: command
-        short-summary: Add a container registry endpoint to an instance.
+        short-summary: Create a container registry endpoint for an instance.
         long-summary: |
-          Only Azure Container Registry (ACR) endpoints are supported.
           By default, the registry endpoint will use System Assigned Managed Identity authentication.
           Use the --no-auth flag to explicitly configure anonymous authentication.
 
         examples:
-        - name: Add a registry endpoint with default System Assigned Managed Identity authentication.
+        - name: Create a registry endpoint with default System Assigned Managed Identity authentication.
           text: >
-            az iot ops registry add -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
-        - name: Add a registry endpoint with explicit anonymous authentication.
+            az iot ops registry create -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
+        - name: Create a registry endpoint with explicit anonymous authentication.
           text: >
-            az iot ops registry add -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup --no-auth
-        - name: Add a registry endpoint with system-assigned managed identity and optional audience configuration
+            az iot ops registry create -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup --no-auth
+        - name: Create a registry endpoint with system-assigned managed identity and optional audience configuration
           text: >
-            az iot ops registry add -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
+            az iot ops registry create -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
             --auth-type SystemAssignedManagedIdentity --aud myaudience
-        - name: Add a registry endpoint with kubernetes secret reference authentication
+        - name: Create a registry endpoint with kubernetes secret reference authentication
           text: >
-            az iot ops registry add -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
+            az iot ops registry create -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
             --auth-type ArtifactPullSecret --secret-ref mysecret
-        - name: Add a registry endpoint with user-assigned managed identity configuration
+        - name: Create a registry endpoint with user-assigned managed identity configuration
           text: >
-            az iot ops registry add -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
+            az iot ops registry create -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
             --auth-type UserAssignedManagedIdentity --scope myscope --cid myclientid --tid mytenantid
-        - name: Add a registry endpoint with a code signing CA secret reference
+        - name: Create a registry endpoint with a code signing CA secret reference
           text: >
-            az iot ops registry add -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
+            az iot ops registry create -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
             --cs-secret-refs mysecret
-        - name: Add a registry endpoint with multiple code signing CA secret and configmap references
+        - name: Create a registry endpoint with multiple code signing CA secret and configmap references
           text: >
-            az iot ops registry add -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
+            az iot ops registry create -n myregistry --host myregistry.azurecr.io -i myinstance -g myresourcegroup
             --cs-config-map-refs configmap1 configmap2 --cs-secret-refs secret1 secret2
     """
 
@@ -837,15 +836,15 @@ def load_iotops_help():
     """
 
     helps[
-        "iot ops registry remove"
+        "iot ops registry delete"
     ] = """
         type: command
-        short-summary: Remove a container registry endpoint.
+        short-summary: Delete a container registry endpoint.
 
         examples:
-        - name: Remove a registry endpoint.
+        - name: Delete a registry endpoint.
           text: >
-            az iot ops registry remove -n myregistry -i myinstance -g myresourcegroup
+            az iot ops registry delete -n myregistry -i myinstance -g myresourcegroup
     """
 
     helps[

azext_edge/edge/command_map.py

@@ -182,12 +182,11 @@ def load_iotops_commands(self, _):
     with self.command_group(
         "iot ops registry",
         command_type=registry_endpoint_resource_ops,
-        is_preview=True,
     ) as cmd_group:
         cmd_group.command("list", "list_registry_endpoints")
-        cmd_group.command("add", "add_registry_endpoint")
+        cmd_group.command("create", "create_registry_endpoint")
         cmd_group.command("update", "update_registry_endpoint")
-        cmd_group.command("remove", "remove_registry_endpoint")
+        cmd_group.command("delete", "delete_registry_endpoint")
         cmd_group.show_command("show", "show_registry_endpoint")
 
     with self.command_group(

azext_edge/edge/commands_registry_endpoints.py

@@ -13,7 +13,7 @@
 from .providers.orchestration.resources import RegistryEndpoints
 
 
-def add_registry_endpoint(
+def create_registry_endpoint(
     cmd,
     instance_name: str,
     resource_group_name: str,
@@ -30,8 +30,8 @@ def add_registry_endpoint(
     code_signing_secret_refs: Optional[list] = None,
     **kwargs,
 ) -> dict:
-    """Add a registry endpoint to an IoT Operations instance."""
-    return RegistryEndpoints(cmd).add(
+    """Create a registry endpoint for an IoT Operations instance."""
+    return RegistryEndpoints(cmd).create(
         instance_name=instance_name,
         resource_group_name=resource_group_name,
         registry_endpoint_name=registry_endpoint_name,
@@ -102,16 +102,16 @@ def list_registry_endpoints(cmd, instance_name: str, resource_group_name: str) -
     )
 
 
-def remove_registry_endpoint(
+def delete_registry_endpoint(
     cmd,
     registry_endpoint_name: str,
     instance_name: str,
     resource_group_name: str,
     confirm_yes: Optional[bool] = None,
     **kwargs,
 ) -> None:
-    """Remove a registry endpoint from an IoT Operations instance."""
-    return RegistryEndpoints(cmd).remove(
+    """Delete a registry endpoint from an IoT Operations instance."""
+    return RegistryEndpoints(cmd).delete(
         instance_name=instance_name,
         resource_group_name=resource_group_name,
         registry_endpoint_name=registry_endpoint_name,

azext_edge/edge/providers/orchestration/resources/registryendpoints.py

@@ -183,7 +183,7 @@ def _process_code_signing_cas(
 
         return cas
 
-    def add(
+    def create(
         self,
         instance_name: str,
         resource_group_name: str,
@@ -201,7 +201,7 @@ def add(
         **kwargs,
     ) -> dict:
         """
-        Add a registry endpoint to an IoT Operations instance.
+        Create a registry endpoint for an IoT Operations Instance.
 
         :param instance_name: Name of the IoT Operations instance.
         :param resource_group_name: Name of the resource group.
@@ -223,7 +223,7 @@ def add(
         status_text = kwargs.pop("status_text", "Working...")
         no_status = kwargs.pop("no_status", False)
         headers = kwargs.pop("headers", None)
-        operation_kwargs = {"headers": headers or {"CommandName": "iot ops registry add"}}
+        operation_kwargs = {"headers": headers or {"CommandName": "iot ops registry create"}}
 
         # Process authentication configuration
         auth_config = self._process_registry_endpoint_authentication(
@@ -347,7 +347,7 @@ def update(
             )
             return wait_for_terminal_state(poller, **kwargs)
 
-    def remove(
+    def delete(
         self,
         instance_name: str,
         resource_group_name: str,
@@ -356,7 +356,7 @@ def remove(
         **kwargs,
     ) -> None:
         """
-        Remove a registry endpoint from an IoT Operations instance.
+        Delete a registry endpoint from an IoT Operations instance.
 
         :param instance_name: Name of the IoT Operations instance.
         :param resource_group_name: Name of the resource group.
@@ -368,14 +368,14 @@ def remove(
         if should_bail:
             return
 
-        with console.status(f"Removing registry endpoint '{registry_endpoint_name}'..."):
+        with console.status(f"Deleting registry endpoint '{registry_endpoint_name}'..."):
             poller = self.registry_endpoints.begin_delete(
                 resource_group_name=resource_group_name,
                 instance_name=instance_name,
                 registry_endpoint_name=registry_endpoint_name,
             )
             wait_for_terminal_state(poller, **kwargs)
-        logger.info(f"Registry endpoint '{registry_endpoint_name}' removed successfully.")
+        logger.info(f"Registry endpoint '{registry_endpoint_name}' deleted successfully.")
 
     def _identify_authentication_method(
         self,

azext_edge/edge/providers/orchestration/upgrade2.py

@@ -297,7 +297,7 @@ def _apply_instance_update(self, needs_adr_update: bool, needs_spc_update: bool,
         )
 
     def _create_default_registry_endpoint(self, headers: dict) -> dict:
-        return self.registry_endpoints.add(
+        return self.registry_endpoints.create(
             instance_name=self.instance_name,
             resource_group_name=self.resource_group_name,
             registry_endpoint_name="default",

azext_edge/tests/edge/orchestration/resources/registry_endpoint/test_registry_endpoints_int.py

@@ -42,7 +42,7 @@ def test_registry_endpoint_lifecycle_anonymous(registry_endpoint_test_setup, tra
     try:
         # CREATE - SAMI authentication (default)
         registry_endpoint = run(
-            f"az iot ops registry add -n {registry_endpoint_name} "
+            f"az iot ops registry create -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} "
             f"--host {host}"
         )
@@ -93,7 +93,7 @@ def test_registry_endpoint_lifecycle_anonymous(registry_endpoint_test_setup, tra
 
         # REMOVE
         run(
-            f"az iot ops registry remove -n {registry_endpoint_name} "
+            f"az iot ops registry delete -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} -y"
         )
         tracked_resources.remove(registry_endpoint["id"])
@@ -108,7 +108,7 @@ def test_registry_endpoint_lifecycle_anonymous(registry_endpoint_test_setup, tra
         if registry_endpoint.get("id") in tracked_resources:
             try:
                 run(
-                    f"az iot ops registry remove -n {registry_endpoint_name} "
+                    f"az iot ops registry delete -n {registry_endpoint_name} "
                     f"-g {resource_group} --instance {instance_name} -y"
                 )
                 tracked_resources.remove(registry_endpoint["id"])
@@ -128,7 +128,7 @@ def test_registry_endpoint_artifact_pull_secret(registry_endpoint_test_setup, tr
     try:
         # CREATE - ArtifactPullSecret authentication
         registry_endpoint = run(
-            f"az iot ops registry add -n {registry_endpoint_name} "
+            f"az iot ops registry create -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} "
             f"--host {host} --secret-ref {secret_ref}"
         )
@@ -158,7 +158,7 @@ def test_registry_endpoint_artifact_pull_secret(registry_endpoint_test_setup, tr
 
         # REMOVE
         run(
-            f"az iot ops registry remove -n {registry_endpoint_name} "
+            f"az iot ops registry delete -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} -y"
         )
         tracked_resources.remove(registry_endpoint["id"])
@@ -168,7 +168,7 @@ def test_registry_endpoint_artifact_pull_secret(registry_endpoint_test_setup, tr
         if registry_endpoint.get("id") in tracked_resources:
             try:
                 run(
-                    f"az iot ops registry remove -n {registry_endpoint_name} "
+                    f"az iot ops registry delete -n {registry_endpoint_name} "
                     f"-g {resource_group} --instance {instance_name} -y"
                 )
                 tracked_resources.remove(registry_endpoint["id"])
@@ -188,7 +188,7 @@ def test_registry_endpoint_system_assigned_auth(registry_endpoint_test_setup, tr
     try:
         # CREATE - SystemAssigned authentication with audience
         registry_endpoint = run(
-            f"az iot ops registry add -n {registry_endpoint_name} "
+            f"az iot ops registry create -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} "
             f"--host {host} --auth-type SystemAssignedManagedIdentity --audience {audience}"
         )
@@ -218,7 +218,7 @@ def test_registry_endpoint_system_assigned_auth(registry_endpoint_test_setup, tr
 
         # REMOVE
         run(
-            f"az iot ops registry remove -n {registry_endpoint_name} "
+            f"az iot ops registry delete -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} -y"
         )
         tracked_resources.remove(registry_endpoint["id"])
@@ -228,7 +228,7 @@ def test_registry_endpoint_system_assigned_auth(registry_endpoint_test_setup, tr
         if registry_endpoint.get("id") in tracked_resources:
             try:
                 run(
-                    f"az iot ops registry remove -n {registry_endpoint_name} "
+                    f"az iot ops registry delete -n {registry_endpoint_name} "
                     f"-g {resource_group} --instance {instance_name} -y"
                 )
                 tracked_resources.remove(registry_endpoint["id"])
@@ -250,7 +250,7 @@ def test_registry_endpoint_user_assigned_auth(registry_endpoint_test_setup, trac
     try:
         # CREATE - UserAssigned authentication with full parameters
         registry_endpoint = run(
-            f"az iot ops registry add -n {registry_endpoint_name} "
+            f"az iot ops registry create -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} "
             f"--host {host} --auth-type UserAssignedManagedIdentity "
             f"--client-id {client_id} --tenant-id {tenant_id} --scope {scope}"
@@ -281,7 +281,7 @@ def test_registry_endpoint_user_assigned_auth(registry_endpoint_test_setup, trac
 
         # REMOVE
         run(
-            f"az iot ops registry remove -n {registry_endpoint_name} "
+            f"az iot ops registry delete -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} -y"
         )
         tracked_resources.remove(registry_endpoint["id"])
@@ -291,7 +291,7 @@ def test_registry_endpoint_user_assigned_auth(registry_endpoint_test_setup, trac
         if registry_endpoint.get("id") in tracked_resources:
             try:
                 run(
-                    f"az iot ops registry remove -n {registry_endpoint_name} "
+                    f"az iot ops registry delete -n {registry_endpoint_name} "
                     f"-g {resource_group} --instance {instance_name} -y"
                 )
                 tracked_resources.remove(registry_endpoint["id"])
@@ -335,7 +335,7 @@ def test_registry_endpoint_authentication_auto_detection(registry_endpoint_test_
         # Auto-detect ArtifactPullSecret (secret_ref provided)
         name1 = f"test-registry-{generate_random_string(force_lower=True, size=8)}"
         endpoint1 = run(
-            f"az iot ops registry add -n {name1} "
+            f"az iot ops registry create -n {name1} "
             f"-g {resource_group} --instance {instance_name} "
             f"--host registry1.azurecr.io --secret-ref my-secret"
         )
@@ -352,7 +352,7 @@ def test_registry_endpoint_authentication_auto_detection(registry_endpoint_test_
         # Auto-detect SystemAssigned (no auth parameters provided)
         name2 = f"test-registry-{generate_random_string(force_lower=True, size=8)}"
         endpoint2 = run(
-            f"az iot ops registry add -n {name2} "
+            f"az iot ops registry create -n {name2} "
             f"-g {resource_group} --instance {instance_name} "
             f"--host registry2.azurecr.io"
         )
@@ -369,7 +369,7 @@ def test_registry_endpoint_authentication_auto_detection(registry_endpoint_test_
         # Auto-detect UserAssigned (client-id and tenant-id provided)
         name3 = f"test-registry-{generate_random_string(force_lower=True, size=8)}"
         endpoint3 = run(
-            f"az iot ops registry add -n {name3} "
+            f"az iot ops registry create -n {name3} "
             f"-g {resource_group} --instance {instance_name} "
             f"--host registry3.azurecr.io --client-id my-client --tenant-id my-tenant"
         )
@@ -386,7 +386,7 @@ def test_registry_endpoint_authentication_auto_detection(registry_endpoint_test_
         # Auto-detect Anonymous --no-auth
         name4 = f"test-registry-{generate_random_string(force_lower=True, size=8)}"
         endpoint4 = run(
-            f"az iot ops registry add -n {name4} "
+            f"az iot ops registry create -n {name4} "
             f"-g {resource_group} --instance {instance_name} "
             f"--host registry4.azurecr.io --no-auth"
         )
@@ -402,15 +402,15 @@ def test_registry_endpoint_authentication_auto_detection(registry_endpoint_test_
 
         # Cleanup all endpoints
         for ep_id, ep_name in endpoints_to_cleanup:
-            run(f"az iot ops registry remove -n {ep_name} " f"-g {resource_group} --instance {instance_name} -y")
+            run(f"az iot ops registry delete -n {ep_name} " f"-g {resource_group} --instance {instance_name} -y")
             tracked_resources.append(ep_id)  # Add to tracked for safety
             tracked_resources.remove(ep_id)  # Remove after successful deletion
 
     except Exception:
         # Cleanup in case of failure
         for ep_id, ep_name in endpoints_to_cleanup:
             try:
-                run(f"az iot ops registry remove -n {ep_name} " f"-g {resource_group} --instance {instance_name} -y")
+                run(f"az iot ops registry delete -n {ep_name} " f"-g {resource_group} --instance {instance_name} -y")
             except Exception:
                 pass  # Best effort cleanup
         raise
@@ -432,7 +432,7 @@ def test_registry_endpoint_code_signing_cas(registry_endpoint_test_setup, tracke
     try:
         # CREATE - with one configmap
         registry_endpoint = run(
-            f"az iot ops registry add -n {registry_endpoint_name} "
+            f"az iot ops registry create -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} "
             f"--host {host} --cs-config-map-refs {configmap1}"
         )
@@ -514,7 +514,7 @@ def test_registry_endpoint_code_signing_cas(registry_endpoint_test_setup, tracke
 
         # REMOVE
         run(
-            f"az iot ops registry remove -n {registry_endpoint_name} "
+            f"az iot ops registry delete -n {registry_endpoint_name} "
             f"-g {resource_group} --instance {instance_name} -y"
         )
         tracked_resources.remove(registry_endpoint["id"])
@@ -524,7 +524,7 @@ def test_registry_endpoint_code_signing_cas(registry_endpoint_test_setup, tracke
         if registry_endpoint.get("id") in tracked_resources:
             try:
                 run(
-                    f"az iot ops registry remove -n {registry_endpoint_name} "
+                    f"az iot ops registry delete -n {registry_endpoint_name} "
                     f"-g {resource_group} --instance {instance_name} -y"
                 )
                 tracked_resources.remove(registry_endpoint["id"])