Have forceDisconnect as an option #1234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivakar
requested review from
avishekpant,
clecompt-msft,
Copilot and
ewertons
and removed request for
Copilot
clecompt-msft
approved these changes
Aug 20, 2025
device/core/src/interfaces.ts
Outdated
| /** | ||
| * Boolean flag indicating whether to force disconnection in high throughput scenarios to cause messages to be properly dropped. | ||
| */ | ||
| forceFlag?: boolean; |
Collaborator
There was a problem hiding this comment.
nit: Is there a more descriptive name here?
avishekpant
approved these changes
Aug 22, 2025
ewertons
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When experiencing message loss due to high throughput, the force flag in disconnectClient can be set to true to cause messages to be properly dropped and thus re-sent.
Original ICM ID 567171345
Now default is False otherwise set to True