More lint fixes

Author: AsafMah

azure-kusto-data/azure/kusto/data/helpers.py

@@ -129,7 +129,7 @@ def parse_datetime(frame, col):
         # if frame contains ".", replace "Z" with ".000Z"
         # == False is not a mistake - that's the pandas way to do it
         contains_dot = frame[col].str.contains(".")
-        frame.loc[contains_dot == False, col] = frame.loc[contains_dot == False, col].str.replace("Z", ".000Z")
+        frame.loc[not contains_dot, col] = frame.loc[not contains_dot, col].str.replace("Z", ".000Z")
     frame[col] = pd.to_datetime(frame[col], errors="coerce", **args)
     return frame[col]
 

azure-kusto-data/tests/aio/test_async_token_providers.py

@@ -67,7 +67,6 @@ def get_token_value(self, token: dict):
         assert token is not None
         assert TokenConstants.MSAL_ERROR not in token
 
-        value = None
         if TokenConstants.MSAL_ACCESS_TOKEN in token:
             return token[TokenConstants.MSAL_ACCESS_TOKEN]
         elif TokenConstants.AZ_ACCESS_TOKEN in token:

azure-kusto-data/tests/aio/test_kusto_client.py

@@ -80,7 +80,7 @@ async def test_raise_network(self):
             self._mock_query(aioresponses_mock)
             async with KustoClient(self.HOST) as client:
                 with pytest.raises(KustoNetworkError):
-                    response = await client.execute_query("PythonTest", "raiseNetwork")
+                    await client.execute_query("PythonTest", "raiseNetwork")
 
     @aio_documented_by(KustoClientTestsSync.test_sanity_control_command)
     @pytest.mark.asyncio

azure-kusto-data/tests/test_client_request_properties.py

@@ -127,7 +127,6 @@ def test_custom_crp_tracing_properties_override_kcsb():
 def test_set_connector_name_and_version():
     kcsb = KustoConnectionStringBuilder("test")
     kcsb._set_connector_details("myConnector", "myVersion", send_user=False)
-    crp = ClientRequestProperties()
 
     params = ExecuteRequestParams._from_query(
         "somequery",
@@ -150,7 +149,6 @@ def test_set_connector_name_and_version():
 def test_set_connector_no_app_version():
     kcsb = KustoConnectionStringBuilder("test")
     kcsb._set_connector_details("myConnector", "myVersion", app_name="myApp", send_user=True)
-    crp = ClientRequestProperties()
 
     params = ExecuteRequestParams._from_query(
         "somequery",

azure-kusto-data/tests/test_helpers.py

@@ -49,7 +49,7 @@ def test_dataframe_from_result_table():
 for k, v in {"year": 2021, "month": 12, "day": 22, "hour": 11, "minute": 43, "second": 00}.items():
     assert getattr(df.iloc[0].RecordTime, k) == v
 assert type(df.iloc[0].RecordBool) is numpy.bool_
-assert df.iloc[0].RecordBool == True
+assert df.iloc[0].RecordBool
 assert type(df.iloc[0].RecordInt) is numpy.int32
 assert df.iloc[0].RecordInt == 5678
 assert type(df.iloc[0].RecordInt64) is numpy.int64

azure-kusto-data/tests/test_kusto_client.py

@@ -42,7 +42,7 @@ def test_raise_network(self, mock_post, method):
         """Test query V2."""
         with KustoClient(self.HOST) as client:
             with pytest.raises(KustoNetworkError):
-                response = method.__call__(client, "PythonTest", "raiseNetwork")
+                method.__call__(client, "PythonTest", "raiseNetwork")
 
     @patch("requests.Session.post", side_effect=mocked_requests_post)
     def test_sanity_control_command(self, mock_post):
@@ -100,7 +100,7 @@ def test_partial_results(self, mock_post, method):
             with pytest.raises(KustoMultiApiError) as e:
                 response = method.__call__(client, "PythonTest", query, properties=properties)
                 if type(response) == KustoStreamingResponseDataSet:
-                    results = list(get_response_first_primary_result(response))
+                    list(get_response_first_primary_result(response))
             errors = e.value.get_api_errors()
             assert len(errors) == 1
             assert errors[0].code == "LimitsExceeded"

azure-kusto-data/tests/test_kusto_connection_string_builder.py

@@ -270,7 +270,7 @@ def test_add_msi(self):
 
         exception_occurred = False
         try:
-            fault = KustoConnectionStringBuilder.with_aad_managed_service_identity_authentication("localhost", client_id=client_guid, object_id=object_guid)
+            KustoConnectionStringBuilder.with_aad_managed_service_identity_authentication("localhost", client_id=client_guid, object_id=object_guid)
         except ValueError:
             exception_occurred = True
         finally:

azure-kusto-data/tests/test_security.py

@@ -42,8 +42,6 @@ def test_msi_auth():
     Please be prudent in adding any future tests!
     """
     client_guid = "kjhjk"
-    object_guid = "87687687"
-    res_guid = "kajsdghdijewhag"
 
     """
     Use of object_id and msi_res_id is disabled pending support of azure-identity

azure-kusto-data/tests/test_token_providers.py

@@ -113,7 +113,6 @@ def get_token_value(token: dict):
         assert token is not None
         assert TokenConstants.MSAL_ERROR not in token
 
-        value = None
         if TokenConstants.MSAL_ACCESS_TOKEN in token:
             return token[TokenConstants.MSAL_ACCESS_TOKEN]
         elif TokenConstants.AZ_ACCESS_TOKEN in token:
@@ -287,7 +286,7 @@ def test_app_key_provider_when_url_not_valid():
         if app_auth:
             with pytest.raises(KustoNetworkError):
                 with ApplicationKeyTokenProvider("NoURI", app_auth.auth_id, app_auth.app_id, app_auth.app_key) as provider:
-                    token = provider.get_token()
+                    provider.get_token()
 
     @staticmethod
     def test_app_cert_provider():