[Az.Resources] Fix unexplicable error message when subscription and scope are both null. (#22730)

* Fix unexplicate error message when subscription and scope are both null

* Delete unnecessary namespace

* Delete unnecessary namespace

* Update ChangeLog

* Resolve comments

* Resolve Comments

Author: NoriZC

src/Resources/Resources/ChangeLog.md

@@ -19,6 +19,7 @@
 -->
 
 ## Upcoming Release
+* Fixed unexplicable error message when subscription and scope are neither provided in `Get-AzRoleDefinition`. [#22716]
 
 ## Version 6.10.0
 * Added breaking change warnings for Azure Policy cmdlets.

src/Resources/Resources/Models.ResourceGroups/ResourcesBaseCmdlet.cs

@@ -17,6 +17,8 @@ namespace Microsoft.Azure.Commands.Resources.Models
 {
     using Authorization;
     using ResourceManager.Common;
+    using System.Management.Automation;
+    using System;
 
     /// <summary> 
     /// Base class for all resources cmdlets
@@ -114,5 +116,10 @@ public virtual string DetermineParameterSetName()
         {
             return ParameterSetName;
         }
+
+        protected void WriteTerminatingError(string message, params object[] args)
+        {
+            ThrowTerminatingError(new ErrorRecord(new Exception(String.Format(message, args)), "Error", ErrorCategory.NotSpecified, null));
+        }
     }
 }

src/Resources/Resources/Properties/Resources.Designer.cs

@@ -463,4 +463,7 @@ This means the role assignment was not able to be created. Please assign a role
   <data name="SuccessfullRARemove" xml:space="preserve">
     <value>Succesfully removed role assignment for AD object '{0}' on scope '{1}' with role definition '{2}'</value>
   </data>
+  <data name="ScopeAndSubscriptionNeitherProvided" xml:space="preserve">
+    <value>No subscription was found in the default profile and no scope was specified. Either specify a scope or use a tenant with a subscription to run the command.</value>
+  </data>
 </root>

src/Resources/Resources/Properties/Resources.resx

@@ -21,6 +21,7 @@
 using System;
 using System.Collections.Generic;
 using System.Management.Automation;
+using ProjectResources = Microsoft.Azure.Commands.Resources.Properties.Resources;
 
 namespace Microsoft.Azure.Commands.Resources
 {
@@ -245,6 +246,11 @@ public override void ExecuteCmdlet()
                 IncludeClassicAdministrators = IncludeClassicAdministrators.IsPresent,
             };
 
+            if (options.Scope == null && options.ResourceIdentifier.Subscription == null)
+            {
+                WriteTerminatingError(ProjectResources.ScopeAndSubscriptionNeitherProvided);
+            }
+
             AuthorizationClient.ValidateScope(options.Scope, true);
 
             List<PSRoleAssignment> ra = PoliciesClient.FilterRoleAssignments(options, DefaultProfile.DefaultContext.Subscription.Id);

src/Resources/Resources/RoleAssignments/GetAzureRoleAssignmentCommand.cs

@@ -24,6 +24,7 @@
 using System;
 using System.IO;
 using System.Management.Automation;
+using ProjectResources = Microsoft.Azure.Commands.Resources.Properties.Resources;
 
 namespace Microsoft.Azure.Commands.Resources
 {
@@ -323,14 +324,19 @@ public override void ExecuteCmdlet()
                     ResourceGroupName = ResourceGroupName,
                     ResourceName = ResourceName,
                     ResourceType = ResourceType,
-                    Subscription = DefaultProfile.DefaultContext.Subscription != null ? DefaultProfile.DefaultContext.Subscription.Id : "",
+                    Subscription = DefaultProfile.DefaultContext.Subscription?.Id?.ToString(),
                 },
                 CanDelegate = AllowDelegation.IsPresent ? true : false,
                 Description = Description,
                 Condition = Condition,
                 ConditionVersion = ConditionVersion,
             };
 
+            if (parameters.Scope == null && parameters.ResourceIdentifier.Subscription == null)
+            {
+                WriteTerminatingError(ProjectResources.ScopeAndSubscriptionNeitherProvided);
+            }
+
             AuthorizationClient.ValidateScope(parameters.Scope, true);
 
             WriteObject(PoliciesClient.CreateRoleAssignment(parameters, RoleAssignmentId));

src/Resources/Resources/RoleAssignments/NewAzureRoleAssignmentCommand.cs

@@ -188,14 +188,19 @@ public override void ExecuteCmdlet()
                     ResourceGroupName = ResourceGroupName,
                     ResourceName = ResourceName,
                     ResourceType = ResourceType,
-                    Subscription = DefaultProfile.DefaultContext.Subscription.Id
+                    Subscription = DefaultProfile.DefaultContext.Subscription?.Id?.ToString()
                 },
                 // we should never expand principal groups in the Delete scenario
                 ExpandPrincipalGroups = false,
                 // never include classic administrators in the Delete scenario
                 IncludeClassicAdministrators = false
             };
 
+            if (options.Scope == null && options.ResourceIdentifier.Subscription == null)
+            {
+                WriteTerminatingError(ProjectResources.ScopeAndSubscriptionNeitherProvided);
+            }
+
             AuthorizationClient.ValidateScope(options.Scope, true);
             ConfirmAction(
                 string.Format(ProjectResources.RemovingRoleAssignment, ObjectId, Scope, RoleDefinitionName),

src/Resources/Resources/RoleAssignments/RemoveAzureRoleAssignmentCommand.cs

@@ -21,6 +21,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Management.Automation;
+using ProjectResources = Microsoft.Azure.Commands.Resources.Properties.Resources;
 
 namespace Microsoft.Azure.Commands.Resources
 {
@@ -61,15 +62,15 @@ public override void ExecuteCmdlet()
                 Scope = Scope,
                 ResourceIdentifier = new ResourceIdentifier
                 {
-                    Subscription = DefaultProfile.DefaultContext.Subscription.Id?.ToString()
+                    Subscription = DefaultProfile.DefaultContext.Subscription?.Id?.ToString()
                 },
                 RoleDefinitionId = Id,
                 RoleDefinitionName = Name,
             };
 
             if (options.Scope == null && options.ResourceIdentifier.Subscription == null)
             {
-                WriteTerminatingError("No subscription was found in the default profile and no scope was specified. Either specify a scope or use a tenant with a subscription to run the command.");
+                WriteTerminatingError(ProjectResources.ScopeAndSubscriptionNeitherProvided);
             }
 
             AuthorizationClient.ValidateScope(options.Scope, true);
@@ -87,10 +88,7 @@ public override void ExecuteCmdlet()
                 WriteObject(filteredRoleDefinitions, enumerateCollection: true);
             }
         }
-
-        private void WriteTerminatingError(string message, params object[] args)
-        {
-            ThrowTerminatingError(new ErrorRecord(new Exception(String.Format(message, args)), "Error", ErrorCategory.NotSpecified, null));
-        }
+        
+        
     }
 }

src/Resources/Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs

@@ -89,10 +89,15 @@ public override void ExecuteCmdlet()
                 Scope = Scope,
                 ResourceIdentifier = new ResourceIdentifier
                 {
-                    Subscription = DefaultProfile.DefaultContext.Subscription.Id.ToString()
+                    Subscription = DefaultProfile.DefaultContext.Subscription?.Id?.ToString()
                 }
             };
 
+            if (options.Scope == null && options.ResourceIdentifier.Subscription == null)
+            {
+                WriteTerminatingError(ProjectResources.ScopeAndSubscriptionNeitherProvided);
+            }
+
             AuthorizationClient.ValidateScope(options.Scope, true);
 
             ConfirmAction(