[Resources] Fix an issue where What-If shows two resource group scopes with different casing (#13299)

* Normalize scope casing when group resource changes

* Update change log

* Update ChangeLog.md

Co-authored-by: Yeming Liu <[email protected]>

Author: shenglol

src/Resources/ResourceManager/Formatters/WhatIfOperationResultFormatter.cs

@@ -176,18 +176,18 @@ private void FormatResourceChanges(IList<PSWhatIfChange> resourceChanges)
                 return;
             }
 
-            int scopeCount = resourceChanges.Select(rc => rc.Scope).Distinct().Count();
+            int scopeCount = resourceChanges.Select(rc => rc.Scope.ToUpperInvariant()).Distinct().Count();
 
             this.Builder
                 .AppendLine()
                 .Append("The deployment will update the following ")
                 .AppendLine(scopeCount == 1 ? "scope:" : "scopes:");
 
             resourceChanges
-                .OrderBy(rc => rc.Scope)
-                .GroupBy(rc => rc.Scope)
+                .OrderBy(rc => rc.Scope.ToUpperInvariant())
+                .GroupBy(rc => rc.Scope.ToUpperInvariant())
                 .ToDictionary(g => g.Key, g => g.ToList())
-                .ForEach(kvp => FormatResourceChangesInScope(kvp.Key, kvp.Value));
+                .ForEach(kvp => FormatResourceChangesInScope(kvp.Value[0].Scope, kvp.Value));
         }
 
         private void FormatResourceChangesInScope(string scope, IList<PSWhatIfChange> resourceChanges)

src/Resources/Resources.Test/Formatters/WhatIfOperationResultFormatterTests.cs

@@ -173,12 +173,12 @@ public void Format_NonEmptyResourceChanges_SortsAndGroupsByScopeAndChangeType()
             {
                 new WhatIfChange
                 {
-                    ResourceId = "/subscriptions/00000000-0000-0000-0000-000000000001/resourceGroups/rg1/providers/p1/foo1",
+                    ResourceId = "/Subscriptions/00000000-0000-0000-0000-000000000001/resourceGroups/RG1/providers/p1/foo1",
                     ChangeType = ChangeType.Create
                 },
                 new WhatIfChange
                 {
-                    ResourceId = "/subscriptions/00000000-0000-0000-0000-000000000001/resourceGroups/rg1/providers/p2/bar",
+                    ResourceId = "/Subscriptions/00000000-0000-0000-0000-000000000001/resourceGroups/rg1/providers/p2/bar",
                     ChangeType = ChangeType.Create
                 },
                 new WhatIfChange
@@ -188,7 +188,7 @@ public void Format_NonEmptyResourceChanges_SortsAndGroupsByScopeAndChangeType()
                 },
                 new WhatIfChange
                 {
-                    ResourceId = "/subscriptions/00000000-0000-0000-0000-000000000002/providers/p3/foobar1",
+                    ResourceId = "/SUBSCRIPTIONS/00000000-0000-0000-0000-000000000002/providers/p3/foobar1",
                     ChangeType = ChangeType.Ignore
                 },
                 new WhatIfChange
@@ -204,7 +204,7 @@ public void Format_NonEmptyResourceChanges_SortsAndGroupsByScopeAndChangeType()
             };
 
             string changesInfo = $@"
-Scope: /subscriptions/00000000-0000-0000-0000-000000000001/resourceGroups/rg1
+Scope: /subscriptions/00000000-0000-0000-0000-000000000001/resourceGroups/RG1
 {Color.Green}
   + p1/foo1
   + p2/bar

src/Resources/Resources/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fixed an issue where What-If shows two resource group scopes with different casing
 * Updated `Export-AzResourceGroup` to use the SDK.
 
 ## Version 3.0.0